[{"id":1375,"web_url":"https://patchwork.libcamera.org/comment/1375/","msgid":"<20190415233627.GA16492@bigcity.dyn.berto.se>","date":"2019-04-15T23:36:27","subject":"Re: [libcamera-devel] [PATCH v5 1/7] libcamera: stream: Make Stream\n\tinheritable","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2019-04-16 01:18:53 +0200, Jacopo Mondi wrote:\n> In preparation for multiple streams support prepare to allow sub-classing\n> the Stream class by removing the 'final' specifier from the class\n> definition and make its private members protected.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/stream.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> index d0f7b0e12485..8a47930f8614 100644\n> --- a/include/libcamera/stream.h\n> +++ b/include/libcamera/stream.h\n> @@ -43,7 +43,7 @@ private:\n> \tSize size_;\n> };\n> \n> -class Stream final\n> +class Stream\n> {\n> public:\n> \tclass StillCapture : public StreamUsage\n> @@ -68,7 +68,7 @@ public:\n> \tBufferPool &bufferPool() { return bufferPool_; }\n> \tconst StreamConfiguration &configuration() const { return configuration_; }\n> \n> -private:\n> +protected:\n> \tfriend class Camera;\n> \n> \tBufferPool bufferPool_;\n> -- \n> 2.21.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13E7A60B2E\n\tfor ;\n\tTue, 16 Apr 2019 01:36:29 +0200 (CEST)","by mail-lf1-x141.google.com with SMTP id h5so11520789lfm.1\n\tfor ;\n\tMon, 15 Apr 2019 16:36:29 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tv141sm2719001lfa.52.2019.04.15.16.36.27\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 15 Apr 2019 16:36:27 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=9J7jOwnMUCTE1WJSiV9yk1SOSuShHzFcFQHBFuD0vEo=;\n\tb=YPg8JqtVK+9Gzf/GgMlVt+x19p9c8mVYL78U8CnUkM9mEINXKhPP/MUYlNsBHTs8gr\n\tnIRlDNAMsE9acylBDgE2oSOejz8k20TaYkxtlRHyOBjV0Xr7mp7dYyoP6O8l8EVgwqJ1\n\t/PwAy0qrE7YO/fG61mgpFGAQrlITj3jDXyMiYSFaT0664+NAyOC52/3t9bgCjVUNPDxM\n\t6qRLIzO8Tkh+sZsELEarS0o0aXZZH2g2ibDoPvBykGnQmikCOJgVN2VL7koK7p3r+6gm\n\tSWo35eybu/yiERiJ62RqaI6Gi6nI3HFDRsRK4e11u6wrAgXMce2LFhOdJhoHw8mJInQ/\n\t8UXQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=9J7jOwnMUCTE1WJSiV9yk1SOSuShHzFcFQHBFuD0vEo=;\n\tb=l+h9i/ersK0F5mLKDDljENUBaQyoMb3RXgACHmSo0WHJSy09le+G2vomrPQw8Kzrh/\n\t6dnh2YDSG2zqNbAlX9blYqGOXDKMG3IoZqA/AXzbebtmTUsxRb+/Re6IsnwfPF7lDsaj\n\tlPYVWZhOERcpukc7MIR31iLRsM351b0eIcnvbAZ02Me4to5lGWLDHAXtkTSNS7o485mH\n\tk8BWIsERTazMsyEcn1FR5h87qZlgqT+0gU/bSXArR1+4F0+1aezlXnETGVnglCY4It+Q\n\tgNHiWG1Jmulae9Fi8G4s0cB9BjYOUq8U8zVcj6N5Bb/lM9Ygkkn7wswVrD00yV6DZr+S\n\tnHng==","X-Gm-Message-State":"APjAAAXcco4Z3BXYVagBTJXi6KEDqIOBoaKrgVnqyWqkqwHFR0gRP+VK\n\tVpvl5aE9Yij8aWe6l0j8GLikxGM9UvA=","X-Google-Smtp-Source":"APXvYqxWnQZ1lfWkDti4HpF6mtadjHlvBczDqbN7uG+jUt3QmHdqPckG0WXy81iI+4XLhgY3vAWf0A==","X-Received":"by 2002:a05:6512:248:: with SMTP id\n\tb8mr21451882lfo.127.1555371388390; \n\tMon, 15 Apr 2019 16:36:28 -0700 (PDT)","Date":"Tue, 16 Apr 2019 01:36:27 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190415233627.GA16492@bigcity.dyn.berto.se>","References":"<20190415231859.9747-1-jacopo@jmondi.org>\n\t<20190415231859.9747-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190415231859.9747-2-jacopo@jmondi.org>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH v5 1/7] libcamera: stream: Make Stream\n\tinheritable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 15 Apr 2019 23:36:29 -0000"}},{"id":1379,"web_url":"https://patchwork.libcamera.org/comment/1379/","msgid":"<20190416105356.GA4832@pendragon.ideasonboard.com>","date":"2019-04-16T10:53:56","subject":"Re: [libcamera-devel] [PATCH v5 1/7] libcamera: stream: Make Stream\n\tinheritable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Apr 16, 2019 at 01:18:53AM +0200, Jacopo Mondi wrote:\n> In preparation for multiple streams support prepare to allow sub-classing\n> the Stream class by removing the 'final' specifier from the class\n> definition and make its private members protected.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/stream.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> index d0f7b0e12485..8a47930f8614 100644\n> --- a/include/libcamera/stream.h\n> +++ b/include/libcamera/stream.h\n> @@ -43,7 +43,7 @@ private:\n> \tSize size_;\n> };\n> \n> -class Stream final\n> +class Stream\n> {\n> public:\n> \tclass StillCapture : public StreamUsage\n> @@ -68,7 +68,7 @@ public:\n> \tBufferPool &bufferPool() { return bufferPool_; }\n> \tconst StreamConfiguration &configuration() const { return configuration_; }\n> \n> -private:\n> +protected:\n> \tfriend class Camera;\n> \n> \tBufferPool bufferPool_;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6267560DB4\n\tfor ;\n\tTue, 16 Apr 2019 12:54:06 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A6356E2;\n\tTue, 16 Apr 2019 12:54:05 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1555412045;\n\tbh=+E3TDTGtcyYU3VhpSRnd8bGQZrMjzByyNJIeTK1/FVc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vlPw2RSie3Pgjh7bPgnuCwyDd6spTNNmhLxo7O/KzgJw2DCkmuTtlbaJk8t24lSNa\n\tkBSBmmeHUtnn5Ls9oLdrovAdsGCpaHd9fJghoTjhnJmgwbkOJH2jJaEcS768TdacuU\n\tFOow8uA2QEDuZ7yviUz62NOvT2obfyVswRjUSVyI=","Date":"Tue, 16 Apr 2019 13:53:56 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190416105356.GA4832@pendragon.ideasonboard.com>","References":"<20190415231859.9747-1-jacopo@jmondi.org>\n\t<20190415231859.9747-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190415231859.9747-2-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v5 1/7] libcamera: stream: Make Stream\n\tinheritable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 16 Apr 2019 10:54:06 -0000"}}]