{"id":9928,"url":"https://patchwork.libcamera.org/api/patches/9928/?format=json","web_url":"https://patchwork.libcamera.org/patch/9928/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201002143154.468162-21-paul.elder@ideasonboard.com>","date":"2020-10-02T14:31:36","name":"[libcamera-devel,v3,20/38] libcamera: IPAInterface: Remove all functions from IPAInterface","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8d0a7d0f597e245ccf371b5e1d96166347af0b65","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9928/mbox/","series":[{"id":1348,"url":"https://patchwork.libcamera.org/api/series/1348/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1348","date":"2020-10-02T14:31:16","name":"IPA isolation implementation","version":3,"mbox":"https://patchwork.libcamera.org/series/1348/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9928/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9928/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C84B0C3B5C\n\tfor ;\n\tFri, 2 Oct 2020 14:32:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D4C963BD9;\n\tFri, 2 Oct 2020 16:32:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 977BE63BBF\n\tfor ;\n\tFri, 2 Oct 2020 16:32:55 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B22CFFD1;\n\tFri, 2 Oct 2020 16:32:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NnkllJ4b\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601649175;\n\tbh=qcqCyccBHvkyaRral2w9MjvwGzk9SDzrQQfh151xDYQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NnkllJ4bpif7tFirh0gyn0ay9e2fHvzH8IdeAQwf2ZBMNYFnKA6r2FLiVyY7sXLrE\n\t2FvhhFuAIy+iSxmWi7lgWprTiYj6dzCXg91eoIrXjipis1oW6VTQpPRpPfJ/4ln0Dv\n\tumuTgXIPYdT9W9BCruP0COh1qSaEjHxWdRUe56oI=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 2 Oct 2020 23:31:36 +0900","Message-Id":"<20201002143154.468162-21-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20201002143154.468162-1-paul.elder@ideasonboard.com>","References":"<20201002143154.468162-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 20/38] libcamera: IPAInterface: Remove\n\tall functions from IPAInterface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that all the functions in the IPA interface are defined in the data\ndefinition file and a specialized IPAInterface is generated per pipeline\nhandler, remove all the functions from the case IPAInterface.\n\nSigned-off-by: Paul Elder \n\n---\nNo change in v3\n\nNo change in v2\n---\n include/libcamera/ipa/ipa_interface.h | 16 ----------------\n 1 file changed, 16 deletions(-)","diff":"diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\nindex 38334ab9..97f14477 100644\n--- a/include/libcamera/ipa/ipa_interface.h\n+++ b/include/libcamera/ipa/ipa_interface.h\n@@ -46,22 +46,6 @@ class IPAInterface\n {\n public:\n \tvirtual ~IPAInterface() {}\n-\n-\tvirtual int init(const IPASettings &settings) = 0;\n-\tvirtual int start() = 0;\n-\tvirtual void stop() = 0;\n-\n-\tvirtual void configure(const CameraSensorInfo &sensorInfo,\n-\t\t\t const std::map &streamConfig,\n-\t\t\t const std::map &entityControls,\n-\t\t\t const IPAOperationData &ipaConfig,\n-\t\t\t IPAOperationData *result) = 0;\n-\n-\tvirtual void mapBuffers(const std::vector &buffers) = 0;\n-\tvirtual void unmapBuffers(const std::vector &ids) = 0;\n-\n-\tvirtual void processEvent(const IPAOperationData &data) = 0;\n-\tSignal queueFrameAction;\n };\n \n } /* namespace libcamera */\n","prefixes":["libcamera-devel","v3","20/38"]}