[{"id":12952,"web_url":"https://patchwork.libcamera.org/comment/12952/","msgid":"<20201004084949.GA8774@pendragon.ideasonboard.com>","date":"2020-10-04T08:49:49","subject":"Re: [libcamera-devel] [PATCH v3 08/38] utils: ipc: add parser script","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Oct 02, 2020 at 11:31:24PM +0900, Paul Elder wrote:\n> On some systems, python2 might still be the default python. Enforce\n> python3 by wrapping the mojo parser script in a python3 script. This\n> also has the benefit of not modifying mojo.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> New in v3\n> ---\n> utils/ipc/parser.py | 20 ++++++++++++++++++++\n> 1 file changed, 20 insertions(+)\n> create mode 100755 utils/ipc/parser.py\n> \n> diff --git a/utils/ipc/parser.py b/utils/ipc/parser.py\n> new file mode 100755\n> index 00000000..f46820fa\n> --- /dev/null\n> +++ b/utils/ipc/parser.py\n> @@ -0,0 +1,20 @@\n> +#!/usr/bin/env python3\n> +# SPDX-License-Identifier: BSD-3-Clause\n> +# Copyright (C) 2020, Google Inc.\n> +#\n> +# Author: Paul Elder \n> +#\n> +# parser.py - Run mojo parser with python3\n> +\n> +import os\n> +import sys\n> +\n> +# TODO set sys.pycache_prefix for >= python3.8\n> +sys.dont_write_bytecode = True\n> +\n> +# Make sure that mojom_parser.py can import mojom\n> +sys.path.append(f'{os.path.dirname(__file__)}/mojo/public/tools/mojom')\n> +\n> +import mojo.public.tools.mojom.mojom_parser as parser\n> +\n> +parser.Run(sys.argv[1:])","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6D45C3B5C\n\tfor ;\n\tSun, 4 Oct 2020 08:50:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 463AB63B2B;\n\tSun, 4 Oct 2020 10:50:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD055609FF\n\tfor ;\n\tSun, 4 Oct 2020 10:50:27 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4818F2A2;\n\tSun, 4 Oct 2020 10:50:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JJB5/HVu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601801427;\n\tbh=wf/IhDNFP/IWyLJ11Wbg+paspYAhYcJ03MBmE9NduIA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JJB5/HVuPsNEFiGa6H65rZaMsfcEVd4d4+ZCxtr1YDVToBiM+Ig4HDywhtvmEWsga\n\tTrWk5OJ5LLm++DWivEno9S24TeioMxunm/x57Uxu64846JNZ7mf1obPlv7mw6zu+sP\n\tEsoiAQKj3ZZsdizRwg6Lwjk9H11VP1N+zokQwrEQ=","Date":"Sun, 4 Oct 2020 11:49:49 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20201004084949.GA8774@pendragon.ideasonboard.com>","References":"<20201002143154.468162-1-paul.elder@ideasonboard.com>\n\t<20201002143154.468162-9-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201002143154.468162-9-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 08/38] utils: ipc: add parser script","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]