{"id":9912,"url":"https://patchwork.libcamera.org/api/patches/9912/?format=json","web_url":"https://patchwork.libcamera.org/patch/9912/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201002143154.468162-4-paul.elder@ideasonboard.com>","date":"2020-10-02T14:31:19","name":"[libcamera-devel,v3,03/38] libcamera: PipelineHandler: Move printing pipeline names to CameraManager","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0b5f6b8c3baefa1b913f86373c9f91d96b945f11","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9912/mbox/","series":[{"id":1348,"url":"https://patchwork.libcamera.org/api/series/1348/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1348","date":"2020-10-02T14:31:16","name":"IPA isolation implementation","version":3,"mbox":"https://patchwork.libcamera.org/series/1348/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9912/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9912/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B29DC3B5C\n\tfor ;\n\tFri, 2 Oct 2020 14:32:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A3B363B72;\n\tFri, 2 Oct 2020 16:32:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9AB2763B6A\n\tfor ;\n\tFri, 2 Oct 2020 16:32:13 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 38F402A2;\n\tFri, 2 Oct 2020 16:32:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UU5SFXn8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601649133;\n\tbh=C5e/tYKbcIgAGB36WLEAVYnxBQ8EfsCOOgtMfV9F9kQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=UU5SFXn8iOEohy21RaRn8Lk3O3emOkv+d5KM4g738o0HpajW3WX7h26sBGdjGmMcz\n\tLNHr94XEoca/uXV+lnngupwymfVXa2j2C1hnzJ2og7++0r8oXUP35osZdNVgXQLnjA\n\tpTYri9ICBsHdU2EebEh6/qK00WG5edGQua2eKyW0=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 2 Oct 2020 23:31:19 +0900","Message-Id":"<20201002143154.468162-4-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20201002143154.468162-1-paul.elder@ideasonboard.com>","References":"<20201002143154.468162-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 03/38] libcamera: PipelineHandler: Move\n\tprinting pipeline names to CameraManager","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Since pipeline registration is done with declaring static factory\nobjects, there is a risk that pipeline factories will be constructed\nbefore libcamera facilities are ready. For example, logging in the\nconstructor of a pipeline handler factory may cause a segfault if\nthreading isn't ready yet. Avoid this issue by moving printing the\nregistration of the pipeline handler to the camera manager.\n\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \nReviewed-by: Jacopo Mondi \n\n---\nNo change in v3\n\nCosmetic changes in v2\n---\n src/libcamera/camera_manager.cpp | 3 +++\n src/libcamera/pipeline_handler.cpp | 3 ---\n 2 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex b8d3ccc8..756f5b2b 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -142,6 +142,9 @@ void CameraManager::Private::createPipelineHandlers()\n \t\tPipelineHandlerFactory::factories();\n \n \tfor (PipelineHandlerFactory *factory : factories) {\n+\t\tLOG(Camera, Debug)\n+\t\t\t<< \"Found registered pipeline handler '\"\n+\t\t\t<< factory->name() << \"'\";\n \t\t/*\n \t\t * Try each pipeline handler until it exhaust\n \t\t * all pipelines it can provide.\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 918aea1e..894200ee 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -689,9 +689,6 @@ void PipelineHandlerFactory::registerType(PipelineHandlerFactory *factory)\n \tstd::vector &factories = PipelineHandlerFactory::factories();\n \n \tfactories.push_back(factory);\n-\n-\tLOG(Pipeline, Debug)\n-\t\t<< \"Registered pipeline handler \\\"\" << factory->name() << \"\\\"\";\n }\n \n /**\n","prefixes":["libcamera-devel","v3","03/38"]}