[{"id":12934,"web_url":"https://patchwork.libcamera.org/comment/12934/","msgid":"","date":"2020-10-02T10:45:37","subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Sensor flips\n\tshould be applied unconditionally","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for this patch.\n\nOn Fri, 2 Oct 2020 at 10:08, Naushir Patuck wrote:\n>\n> The code in pipeline_handler::start() that applies the flips were in a\n> block that was conditional on the RPi::IPA_CONFIG_STAGGERED_WRITE return\n> result. This should be applied unconditionally.\n\nAgree. This seems correct, though I guess it wasn't actually making\nany difference in practice.\n\nReviewed-by: David Plowman \n\nBest regards\nDavid\n\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> .../pipeline/raspberrypi/raspberrypi.cpp | 26 +++++++++----------\n> 1 file changed, 13 insertions(+), 13 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index d4d04c0d..1052bdce 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1172,19 +1172,6 @@ int RPiCameraData::configureIPA(const CameraConfiguration *config)\n> { V4L2_CID_EXPOSURE, result.data[resultIdx++] } });\n> sensorMetadata_ = result.data[resultIdx++];\n> }\n> -\n> - /*\n> - * Configure the H/V flip controls based on the combination of\n> - * the sensor and user transform.\n> - */\n> - if (supportsFlips_) {\n> - ControlList ctrls(unicam_[Unicam::Image].dev()->controls());\n> - ctrls.set(V4L2_CID_HFLIP,\n> - static_cast(!!(rpiConfig->combinedTransform_ & Transform::HFlip)));\n> - ctrls.set(V4L2_CID_VFLIP,\n> - static_cast(!!(rpiConfig->combinedTransform_ & Transform::VFlip)));\n> - unicam_[Unicam::Image].dev()->setControls(&ctrls);\n> - }\n> }\n>\n> if (result.operation & RPi::IPA_CONFIG_SENSOR) {\n> @@ -1198,6 +1185,19 @@ int RPiCameraData::configureIPA(const CameraConfiguration *config)\n> dropFrameCount_ = result.data[resultIdx++];\n> }\n>\n> + /*\n> + * Configure the H/V flip controls based on the combination of\n> + * the sensor and user transform.\n> + */\n> + if (supportsFlips_) {\n> + ControlList ctrls(unicam_[Unicam::Image].dev()->controls());\n> + ctrls.set(V4L2_CID_HFLIP,\n> + static_cast(!!(rpiConfig->combinedTransform_ & Transform::HFlip)));\n> + ctrls.set(V4L2_CID_VFLIP,\n> + static_cast(!!(rpiConfig->combinedTransform_ & Transform::VFlip)));\n> + unicam_[Unicam::Image].dev()->setControls(&ctrls);\n> + }\n> +\n> return 0;\n> }\n>\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E18EC3B5B\n\tfor ;\n\tFri, 2 Oct 2020 10:45:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8FBC5623B6;\n\tFri, 2 Oct 2020 12:45:50 +0200 (CEST)","from mail-oi1-x244.google.com (mail-oi1-x244.google.com\n\t[IPv6:2607:f8b0:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E7286035D\n\tfor ;\n\tFri, 2 Oct 2020 12:45:49 +0200 (CEST)","by mail-oi1-x244.google.com with SMTP id m7so828772oie.0\n\tfor ;\n\tFri, 02 Oct 2020 03:45:49 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"kYPHYVeC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=0SeFLGaJ8lYrnDO9nrA2OE1oroEoKw4wz2hjLlmkmdg=;\n\tb=kYPHYVeCb1OKFIWknhthknXQMlgQyZVqqb8CwOptsT2c7BxhxUA2SDjdsdXUD34r/X\n\t1RqzMOU0++ZTyiSPqEt+sE9KkH4u/oYxl1LwxGIlZA4YxieL5KgfrXgFjvdBlmURpdro\n\tpFmipnfOTqqGQ4cjFGsxinflRwzvJ9MUCJxNdMwgboDALssUrZgAoLFv8NhvfqcEQ8/R\n\tcmzQxOUSo5nVTePhhg2u+reyMUoOPKEUSYM0MkH+ESP2R+Q942T4aQPy8mhNyJjs4cGD\n\tOY3/vgo+mzvOHPhqxOceA+v12VzB/rjIS/oQCrVfX+DEOWgVOaLtUkQGi9wFCT7BNDY0\n\t3Imw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=0SeFLGaJ8lYrnDO9nrA2OE1oroEoKw4wz2hjLlmkmdg=;\n\tb=ADzoBNxEVHMBnthG1JmpMOTJEwc6p3yzW7CZBbdXjQbla4R/AOGXII65r9a1jw5L7q\n\t6cKeRzigxQ5rtvCUyFlBu3jOpZhLVZmh15rU4BHMY6H+5x4N8AMKOwT+y5s102YsADyv\n\tCaOE1w77294iCXUMZbHSk5AVAcFuiK5tXaKdAmTTAae6Yhq6FDit79bnqS1GK+kiw1bw\n\txZfDtHgC96/y/i58JYVzmX+cekPDBJhCOJHN9wfGxkfxpP4LmrzLO769EFzxDW+zpcHb\n\t4HZC2KfsGvZ+WxKJu4/q1CczxMUG8U/5pbGNe5BFdFTugV0oYbgqQ0B9LCGfZtGdj3fR\n\t1fBw==","X-Gm-Message-State":"AOAM530W/qO0QmtskJWJX60uPcrEF0vHhSgyAabgFzOXMgAfqHKlBdd6\n\tmA/2puwqLgqLPp3nASaAx88q5QQwV2XqF7qK3c6mbQ==","X-Google-Smtp-Source":"ABdhPJwYDE8ADlGJ2VRxILVjdGTOaCqwykIL+CIA1e/Mt/85HTgnkPPKNxowXpQHGWEJ3CznAzsnRe0n19H9vFTob3Q=","X-Received":"by 2002:aca:ef89:: with SMTP id n131mr803986oih.22.1601635548022;\n\tFri, 02 Oct 2020 03:45:48 -0700 (PDT)","MIME-Version":"1.0","References":"<20201002090807.108859-1-naush@raspberrypi.com>","In-Reply-To":"<20201002090807.108859-1-naush@raspberrypi.com>","From":"David Plowman ","Date":"Fri, 2 Oct 2020 11:45:37 +0100","Message-ID":"","To":"Naushir Patuck ","Subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Sensor flips\n\tshould be applied unconditionally","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12950,"web_url":"https://patchwork.libcamera.org/comment/12950/","msgid":"<05f85272-ce91-2428-9bf5-df3cd69b972f@ideasonboard.com>","date":"2020-10-02T15:00:31","subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Sensor flips\n\tshould be applied unconditionally","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 02/10/2020 10:08, Naushir Patuck wrote:\n> The code in pipeline_handler::start() that applies the flips were in a\n> block that was conditional on the RPi::IPA_CONFIG_STAGGERED_WRITE return\n> result. This should be applied unconditionally.\n> \n> Signed-off-by: Naushir Patuck \n\nThis sounds and looks fine to me.\n\nI see David has also given it a tag, so I'll merge this now for you.\n\nReviewed-by: Kieran Bingham \n\n\n\n> ---\n> .../pipeline/raspberrypi/raspberrypi.cpp | 26 +++++++++----------\n> 1 file changed, 13 insertions(+), 13 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index d4d04c0d..1052bdce 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1172,19 +1172,6 @@ int RPiCameraData::configureIPA(const CameraConfiguration *config)\n> \t\t\t\t\t { V4L2_CID_EXPOSURE, result.data[resultIdx++] } });\n> \t\t\tsensorMetadata_ = result.data[resultIdx++];\n> \t\t}\n> -\n> -\t\t/*\n> -\t\t * Configure the H/V flip controls based on the combination of\n> -\t\t * the sensor and user transform.\n> -\t\t */\n> -\t\tif (supportsFlips_) {\n> -\t\t\tControlList ctrls(unicam_[Unicam::Image].dev()->controls());\n> -\t\t\tctrls.set(V4L2_CID_HFLIP,\n> -\t\t\t\t static_cast(!!(rpiConfig->combinedTransform_ & Transform::HFlip)));\n> -\t\t\tctrls.set(V4L2_CID_VFLIP,\n> -\t\t\t\t static_cast(!!(rpiConfig->combinedTransform_ & Transform::VFlip)));\n> -\t\t\tunicam_[Unicam::Image].dev()->setControls(&ctrls);\n> -\t\t}\n> \t}\n> \n> \tif (result.operation & RPi::IPA_CONFIG_SENSOR) {\n> @@ -1198,6 +1185,19 @@ int RPiCameraData::configureIPA(const CameraConfiguration *config)\n> \t\tdropFrameCount_ = result.data[resultIdx++];\n> \t}\n> \n> +\t/*\n> +\t * Configure the H/V flip controls based on the combination of\n> +\t * the sensor and user transform.\n> +\t */\n> +\tif (supportsFlips_) {\n> +\t\tControlList ctrls(unicam_[Unicam::Image].dev()->controls());\n> +\t\tctrls.set(V4L2_CID_HFLIP,\n> +\t\t\t static_cast(!!(rpiConfig->combinedTransform_ & Transform::HFlip)));\n> +\t\tctrls.set(V4L2_CID_VFLIP,\n> +\t\t\t static_cast(!!(rpiConfig->combinedTransform_ & Transform::VFlip)));\n> +\t\tunicam_[Unicam::Image].dev()->setControls(&ctrls);\n> +\t}\n> +\n> \treturn 0;\n> }\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 516DAC3B5B\n\tfor ;\n\tFri, 2 Oct 2020 15:00:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1AEEA63BDD;\n\tFri, 2 Oct 2020 17:00:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5F6063BBF\n\tfor ;\n\tFri, 2 Oct 2020 17:00:35 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EA8C52A2;\n\tFri, 2 Oct 2020 17:00:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eVUFqmv/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601650834;\n\tbh=ESGafET5lVdmDKJ9cLs+29Ne1vci48oFtcPV5F5zuFs=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=eVUFqmv/L4GuA8OBYWPRV+S2/R34Tr7KfaLtzF6feugPmrW45ERtHu4CBqESIJOOc\n\tCQEMsJASeZxfDOCDcKN6JvYQiPlf9mGIXqK5QKmcy5QgX/lLSPibip/3LITputJ9sV\n\tcqD+OjwCCNpD1ns6Ej9QVmKDdlAFOFDSKNjuUHTI=","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201002090807.108859-1-naush@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<05f85272-ce91-2428-9bf5-df3cd69b972f@ideasonboard.com>","Date":"Fri, 2 Oct 2020 16:00:31 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201002090807.108859-1-naush@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Sensor flips\n\tshould be applied unconditionally","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]