{"id":9895,"url":"https://patchwork.libcamera.org/api/patches/9895/?format=json","web_url":"https://patchwork.libcamera.org/patch/9895/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201001154600.2722718-7-niklas.soderlund@ragnatech.se>","date":"2020-10-01T15:46:00","name":"[libcamera-devel,v2,6/6] libcamera: pipeline: rkisp1: Add support for XRGB8888","commit_ref":"d4432da031b76a17d437d4f4b6ff56d657a08051","pull_url":null,"state":"accepted","archived":false,"hash":"ce3ba62bb274ace867ef7a90fd7824dd3aea000f","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9895/mbox/","series":[{"id":1342,"url":"https://patchwork.libcamera.org/api/series/1342/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1342","date":"2020-10-01T15:45:54","name":"libcamera: pipeline: rkisp1: Refresh to match upstream","version":2,"mbox":"https://patchwork.libcamera.org/series/1342/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9895/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9895/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F36F9C3B5E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  1 Oct 2020 15:46:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A20EA623B0;\n\tThu,  1 Oct 2020 17:46:19 +0200 (CEST)","from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B92F62396\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  1 Oct 2020 17:46:17 +0200 (CEST)","from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 3d1b81ea-03fd-11eb-9823-005056917f90;\n\tThu, 01 Oct 2020 17:46:15 +0200 (CEST)"],"X-Halon-ID":"3d1b81ea-03fd-11eb-9823-005056917f90","Authorized-sender":"niklas.soderlund@fsdn.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","To":"libcamera-devel@lists.libcamera.org","Date":"Thu,  1 Oct 2020 17:46:00 +0200","Message-Id":"<20201001154600.2722718-7-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20201001154600.2722718-1-niklas.soderlund@ragnatech.se>","References":"<20201001154600.2722718-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 6/6] libcamera: pipeline: rkisp1: Add\n\tsupport for XRGB8888","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"The self path supports XRGB8888, list it as a supported format.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n* Changes since v1\n- Spelling commit message.\n---\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\nindex ff995286073db2a3..e98515c878aa451b 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n@@ -219,7 +219,7 @@ constexpr std::array<PixelFormat, 6> RKISP1_RSZ_MP_FORMATS{\n \n constexpr Size RKISP1_RSZ_SP_SRC_MIN{ 32, 16 };\n constexpr Size RKISP1_RSZ_SP_SRC_MAX{ 1920, 1920 };\n-constexpr std::array<PixelFormat, 7> RKISP1_RSZ_SP_FORMATS{\n+constexpr std::array<PixelFormat, 8> RKISP1_RSZ_SP_FORMATS{\n \tformats::YUYV,\n \tformats::NV16,\n \tformats::NV61,\n@@ -227,7 +227,7 @@ constexpr std::array<PixelFormat, 7> RKISP1_RSZ_SP_FORMATS{\n \tformats::NV12,\n \tformats::R8,\n \tformats::RGB565,\n-\t/* \\todo Add support for BGR888 */\n+\tformats::XRGB8888,\n };\n } /* namespace */\n \n","prefixes":["libcamera-devel","v2","6/6"]}