[{"id":12942,"web_url":"https://patchwork.libcamera.org/comment/12942/","msgid":"<20201002141209.rqvgq77u57ofvivf@uno.localdomain>","date":"2020-10-02T14:12:09","subject":"Re: [libcamera-devel] [PATCH v2 5/6] libcamera: Add support for\n\tXRGB8888 and XBGR8888","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Thu, Oct 01, 2020 at 05:45:59PM +0200, Niklas Söderlund wrote:\n> Add support for XRGB8888 and XBGR8888 formats.\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> * Changes since v1\n> - Fix type in v4l2_pixelformat.cpp where V4L2_PIX_FMT_XBGR32 was added\n> twice instead of adding V4L2_PIX_FMT_XBGR32 and V4L2_PIX_FMT_XRGB32.\n> ---\n> src/libcamera/formats.cpp | 20 ++++++++++++++++++++\n> src/libcamera/v4l2_pixelformat.cpp | 2 ++\n> 2 files changed, 22 insertions(+)\n>\n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index ebaae9be3d75fe58..cc6e579005b2d4b6 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -175,6 +175,26 @@ const std::map pixelFormatInfo{\n> \t\t.pixelsPerGroup = 1,\n> \t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n> \t} },\n> +\t{ formats::XRGB8888, {\n> +\t\t.name = \"XRGB8888\",\n> +\t\t.format = formats::XRGB8888,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_XBGR32),\n> +\t\t.bitsPerPixel = 32,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +\t\t.packed = false,\n> +\t\t.pixelsPerGroup = 1,\n> +\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t} },\n> +\t{ formats::XBGR8888, {\n> +\t\t.name = \"XBGR8888\",\n> +\t\t.format = formats::XBGR8888,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_XRGB32),\n> +\t\t.bitsPerPixel = 32,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +\t\t.packed = false,\n> +\t\t.pixelsPerGroup = 1,\n> +\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t} },\n\nJust to make sure: is it intented that XRGB maps to V4L2's XBGR and\nXBGR to XRGB ? (note the RGB->BGR permutation) ?\n\n> \t{ formats::ABGR8888, {\n> \t\t.name = \"ABGR8888\",\n> \t\t.format = formats::ABGR8888,\n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 30c94bb98f442b08..6b05909f56ae975b 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -48,6 +48,8 @@ const std::map vpf2pf{\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB565), formats::RGB565 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), formats::BGR888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), formats::RGB888 },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_XBGR32), formats::XRGB8888 },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_XRGB32), formats::XBGR8888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32), formats::ABGR8888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_ABGR32), formats::ARGB8888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_ARGB32), formats::BGRA8888 },\n> --\n> 2.28.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F5A3C3B5B\n\tfor ;\n\tFri, 2 Oct 2020 14:08:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B958263B72;\n\tFri, 2 Oct 2020 16:08:14 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F10263B59\n\tfor ;\n\tFri, 2 Oct 2020 16:08:13 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id EE37FFF818;\n\tFri, 2 Oct 2020 14:08:12 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Fri, 2 Oct 2020 16:12:09 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20201002141209.rqvgq77u57ofvivf@uno.localdomain>","References":"<20201001154600.2722718-1-niklas.soderlund@ragnatech.se>\n\t<20201001154600.2722718-6-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201001154600.2722718-6-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v2 5/6] libcamera: Add support for\n\tXRGB8888 and XBGR8888","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12947,"web_url":"https://patchwork.libcamera.org/comment/12947/","msgid":"<20201002144951.usae3yn7hg7rnagm@oden.dyn.berto.se>","date":"2020-10-02T14:49:51","subject":"Re: [libcamera-devel] [PATCH v2 5/6] libcamera: Add support for\n\tXRGB8888 and XBGR8888","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nOn 2020-10-02 16:12:09 +0200, Jacopo Mondi wrote:\n> Hi Niklas,\n> \n> On Thu, Oct 01, 2020 at 05:45:59PM +0200, Niklas Söderlund wrote:\n> > Add support for XRGB8888 and XBGR8888 formats.\n> >\n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > * Changes since v1\n> > - Fix type in v4l2_pixelformat.cpp where V4L2_PIX_FMT_XBGR32 was added\n> > twice instead of adding V4L2_PIX_FMT_XBGR32 and V4L2_PIX_FMT_XRGB32.\n> > ---\n> > src/libcamera/formats.cpp | 20 ++++++++++++++++++++\n> > src/libcamera/v4l2_pixelformat.cpp | 2 ++\n> > 2 files changed, 22 insertions(+)\n> >\n> > diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> > index ebaae9be3d75fe58..cc6e579005b2d4b6 100644\n> > --- a/src/libcamera/formats.cpp\n> > +++ b/src/libcamera/formats.cpp\n> > @@ -175,6 +175,26 @@ const std::map pixelFormatInfo{\n> > \t\t.pixelsPerGroup = 1,\n> > \t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n> > \t} },\n> > +\t{ formats::XRGB8888, {\n> > +\t\t.name = \"XRGB8888\",\n> > +\t\t.format = formats::XRGB8888,\n> > +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_XBGR32),\n> > +\t\t.bitsPerPixel = 32,\n> > +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +\t\t.packed = false,\n> > +\t\t.pixelsPerGroup = 1,\n> > +\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> > +\t} },\n> > +\t{ formats::XBGR8888, {\n> > +\t\t.name = \"XBGR8888\",\n> > +\t\t.format = formats::XBGR8888,\n> > +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_XRGB32),\n> > +\t\t.bitsPerPixel = 32,\n> > +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +\t\t.packed = false,\n> > +\t\t.pixelsPerGroup = 1,\n> > +\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> > +\t} },\n> \n> Just to make sure: is it intented that XRGB maps to V4L2's XBGR and\n> XBGR to XRGB ? (note the RGB->BGR permutation) ?\n\nYes this is intentional, see the ABGR8888 (and friends below). This is \none of these really nice things of the split world of fourcc right :-)\n\n> \n> > \t{ formats::ABGR8888, {\n> > \t\t.name = \"ABGR8888\",\n> > \t\t.format = formats::ABGR8888,\n> > diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> > index 30c94bb98f442b08..6b05909f56ae975b 100644\n> > --- a/src/libcamera/v4l2_pixelformat.cpp\n> > +++ b/src/libcamera/v4l2_pixelformat.cpp\n> > @@ -48,6 +48,8 @@ const std::map vpf2pf{\n> > \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB565), formats::RGB565 },\n> > \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), formats::BGR888 },\n> > \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), formats::RGB888 },\n> > +\t{ V4L2PixelFormat(V4L2_PIX_FMT_XBGR32), formats::XRGB8888 },\n> > +\t{ V4L2PixelFormat(V4L2_PIX_FMT_XRGB32), formats::XBGR8888 },\n> > \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32), formats::ABGR8888 },\n> > \t{ V4L2PixelFormat(V4L2_PIX_FMT_ABGR32), formats::ARGB8888 },\n> > \t{ V4L2PixelFormat(V4L2_PIX_FMT_ARGB32), formats::BGRA8888 },\n> > --\n> > 2.28.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EABFFC3B5C\n\tfor ;\n\tFri, 2 Oct 2020 14:49:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 84C4563BDD;\n\tFri, 2 Oct 2020 16:49:54 +0200 (CEST)","from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 625B363BBF\n\tfor ;\n\tFri, 2 Oct 2020 16:49:53 +0200 (CEST)","by mail-lf1-x141.google.com with SMTP id y17so2179497lfa.8\n\tfor ;\n\tFri, 02 Oct 2020 07:49:53 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tk203sm325829lfd.292.2020.10.02.07.49.51\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 02 Oct 2020 07:49:52 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"Z4ZgUDi1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=GYp9YPKGNmuJ76efSpPTw3w8C/23zErSq3oPYuSNEI0=;\n\tb=Z4ZgUDi1cMMSQXamcMrTYhE5b3LHC/RD8BBVTotQz/uDyKSKO7oOElx0BXlfR1IUsO\n\tHFo7Atdc/0/GgZBsQp0bOtSQOWYZeJ7cyMO/yUseTp82vVSEuGRv+IvhLI1Mg6D8LP1+\n\tdUwSmjkRQ2IFMM059UBRfTY0+rw5bku61xpRW5LjqXSP14LpHAcMa+kv3nbW16XOZ7Tr\n\t3MTla7u5TRTPeeRJYms2Wc/0Oo+ZMofQc8JAabD83LOsFbFi2EaqcCRm9X36vlcPizJN\n\t7dNSdkZDP6ghCH9jbfM0TO5uY7QYjxzNYbUzGGrSMLC+jJRMiqUYsHX/Rkuiwd4KftNe\n\tbZCA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=GYp9YPKGNmuJ76efSpPTw3w8C/23zErSq3oPYuSNEI0=;\n\tb=Cv6nrzw2zKOu/8e4Il0Sgw4KNS3bMD7cVq1n7gpXbrqqRoYzm8lLNsfWS/OdbycISt\n\tRje1wPvqpJCJDL4Ci513gg8naRXl2OEatZj3b+dmmuyfhem1/+qqyCmoH5FOInzGySru\n\tYeBGD8nFOdx9rubrN0HOM1OWHal7M2MJwarfp4yhpPH+V+rUDUCZ89iA3tOpPqawR94O\n\tAO6gJsxVrgPfuSX2/0DaGM4TRe/tclWz199OWuyei5PDlpaALuWToeEF2nK8C2FukfyA\n\tP1mIT++cxL51yHfXNsY+Js3l6u4yrZAnUPsLqJ9oDp9C+4pkAAApgGi21syApAzVLrnc\n\t6MyA==","X-Gm-Message-State":"AOAM5309xvMxmhE4tCA5wfCgtLCnOj5MLevfNi5bNNbfY2HQrqqSXo2o\n\tshc7FswALJLewSUoXToDaqnQx9eFcj8bFg==","X-Google-Smtp-Source":"ABdhPJx9TVaWnQ29evUhVs+L5SxPfmz+vptXZU7l7jsgUo4K10eOlSLb1/t6ax1Bm7xqMstiykDWRg==","X-Received":"by 2002:a19:484d:: with SMTP id v74mr949747lfa.382.1601650192668;\n\tFri, 02 Oct 2020 07:49:52 -0700 (PDT)","Date":"Fri, 2 Oct 2020 16:49:51 +0200","From":"Niklas =?utf-8?q?S=C3=B6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20201002144951.usae3yn7hg7rnagm@oden.dyn.berto.se>","References":"<20201001154600.2722718-1-niklas.soderlund@ragnatech.se>\n\t<20201001154600.2722718-6-niklas.soderlund@ragnatech.se>\n\t<20201002141209.rqvgq77u57ofvivf@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201002141209.rqvgq77u57ofvivf@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v2 5/6] libcamera: Add support for\n\tXRGB8888 and XBGR8888","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]