{"id":9893,"url":"https://patchwork.libcamera.org/api/patches/9893/?format=json","web_url":"https://patchwork.libcamera.org/patch/9893/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201001154600.2722718-5-niklas.soderlund@ragnatech.se>","date":"2020-10-01T15:45:58","name":"[libcamera-devel,v2,4/6] libcamera: pipeline: rkisp1: Add support for R8","commit_ref":"fe54a16294c1e66ae06f7a612f336ba23760e591","pull_url":null,"state":"accepted","archived":false,"hash":"0073dfe44142c144d6397376d2996cfcdfb2dc97","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9893/mbox/","series":[{"id":1342,"url":"https://patchwork.libcamera.org/api/series/1342/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1342","date":"2020-10-01T15:45:54","name":"libcamera: pipeline: rkisp1: Refresh to match upstream","version":2,"mbox":"https://patchwork.libcamera.org/series/1342/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9893/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9893/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 44A33C3B5E\n\tfor ;\n\tThu, 1 Oct 2020 15:46:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 21949623AB;\n\tThu, 1 Oct 2020 17:46:18 +0200 (CEST)","from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 49BED60576\n\tfor ;\n\tThu, 1 Oct 2020 17:46:16 +0200 (CEST)","from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 3c5562c7-03fd-11eb-9823-005056917f90;\n\tThu, 01 Oct 2020 17:46:14 +0200 (CEST)"],"X-Halon-ID":"3c5562c7-03fd-11eb-9823-005056917f90","Authorized-sender":"niklas.soderlund@fsdn.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 1 Oct 2020 17:45:58 +0200","Message-Id":"<20201001154600.2722718-5-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20201001154600.2722718-1-niklas.soderlund@ragnatech.se>","References":"<20201001154600.2722718-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 4/6] libcamera: pipeline: rkisp1: Add\n\tsupport for R8","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Both the main and self path support R8, list it as a supported format.\n\nSigned-off-by: Niklas Söderlund \nReviewed-by: Paul Elder \n---\n* Changes since v1\n- Spelling commit message.\n---\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\nindex 277aa226fcd428be..ff995286073db2a3 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n@@ -207,23 +207,25 @@ void RkISP1Path::stop()\n namespace {\n constexpr Size RKISP1_RSZ_MP_SRC_MIN{ 32, 16 };\n constexpr Size RKISP1_RSZ_MP_SRC_MAX{ 4416, 3312 };\n-constexpr std::array RKISP1_RSZ_MP_FORMATS{\n+constexpr std::array RKISP1_RSZ_MP_FORMATS{\n \tformats::YUYV,\n \tformats::NV16,\n \tformats::NV61,\n \tformats::NV21,\n \tformats::NV12,\n-\t/* \\todo Add support for 8-bit greyscale to DRM formats */\n+\tformats::R8,\n+\t/* \\todo Add support for RAW formats. */\n };\n \n constexpr Size RKISP1_RSZ_SP_SRC_MIN{ 32, 16 };\n constexpr Size RKISP1_RSZ_SP_SRC_MAX{ 1920, 1920 };\n-constexpr std::array RKISP1_RSZ_SP_FORMATS{\n+constexpr std::array RKISP1_RSZ_SP_FORMATS{\n \tformats::YUYV,\n \tformats::NV16,\n \tformats::NV61,\n \tformats::NV21,\n \tformats::NV12,\n+\tformats::R8,\n \tformats::RGB565,\n \t/* \\todo Add support for BGR888 */\n };\n","prefixes":["libcamera-devel","v2","4/6"]}