{"id":9891,"url":"https://patchwork.libcamera.org/api/patches/9891/?format=json","web_url":"https://patchwork.libcamera.org/patch/9891/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201001154600.2722718-3-niklas.soderlund@ragnatech.se>","date":"2020-10-01T15:45:56","name":"[libcamera-devel,v2,2/6] libcamera: pipeline: rkisp1: Fix media bus propagation for NV{12, 21}","commit_ref":"1455bd0dc25d6c5a2cc8ef99dc030b9dca3df77d","pull_url":null,"state":"accepted","archived":false,"hash":"6f20a5774ca272cbdf2fe7714f27075e31504224","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9891/mbox/","series":[{"id":1342,"url":"https://patchwork.libcamera.org/api/series/1342/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1342","date":"2020-10-01T15:45:54","name":"libcamera: pipeline: rkisp1: Refresh to match upstream","version":2,"mbox":"https://patchwork.libcamera.org/series/1342/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9891/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9891/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 699C5C3B5B\n\tfor ;\n\tThu, 1 Oct 2020 15:46:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BBCC26238E;\n\tThu, 1 Oct 2020 17:46:15 +0200 (CEST)","from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C2E1D6035F\n\tfor ;\n\tThu, 1 Oct 2020 17:46:14 +0200 (CEST)","from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 3b8a5269-03fd-11eb-9823-005056917f90;\n\tThu, 01 Oct 2020 17:46:12 +0200 (CEST)"],"X-Halon-ID":"3b8a5269-03fd-11eb-9823-005056917f90","Authorized-sender":"niklas.soderlund@fsdn.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 1 Oct 2020 17:45:56 +0200","Message-Id":"<20201001154600.2722718-3-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20201001154600.2722718-1-niklas.soderlund@ragnatech.se>","References":"<20201001154600.2722718-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 2/6] libcamera: pipeline: rkisp1: Fix\n\tmedia bus propagation for NV{12, 21}","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The upstream driver has changed how the link formats are validated when\nstarting to stream [1]. This revealed that libcamera did not adjust the\nmedia bus format from the link between {main,self} resizer source pad\nand the capture video device as expected by the driver.\n\nThe media bus code YUYV8_2X8 was hardcoded to MEDIA_BUS_FMT_YUYV8_2X8\nfor all pixel formats while it must be adjusted to YUYV8_1_5X8 for NV12\nand NV21, fix this.\n\n1. 6803a9e0e1e43e9e (\"media: staging: rkisp1: cap: simplify link validation by comparing media bus code\")\n\nSigned-off-by: Niklas Söderlund \nReviewed-by: Paul Elder \n---\n* Changes since v1\n- Spelling commit message.\n---\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\nindex 410e9f5d94607f44..63c643f22affc74a 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n@@ -7,6 +7,8 @@\n \n #include \"rkisp1_path.h\"\n \n+#include \n+\n #include \n #include \n \n@@ -125,6 +127,16 @@ int RkISP1Path::configure(const StreamConfiguration &config,\n \t\t<< \"Configuring \" << name_ << \" resizer output pad with \"\n \t\t<< ispFormat.toString();\n \n+\tswitch (config.pixelFormat) {\n+\tcase formats::NV12:\n+\tcase formats::NV21:\n+\t\tispFormat.mbus_code = MEDIA_BUS_FMT_YUYV8_1_5X8;\n+\t\tbreak;\n+\tdefault:\n+\t\tispFormat.mbus_code = MEDIA_BUS_FMT_YUYV8_2X8;\n+\t\tbreak;\n+\t}\n+\n \tret = resizer_->setFormat(1, &ispFormat);\n \tif (ret < 0)\n \t\treturn ret;\n","prefixes":["libcamera-devel","v2","2/6"]}