[{"id":12918,"web_url":"https://patchwork.libcamera.org/comment/12918/","msgid":"<20201001032208.GD45948@pyrite.rasen.tech>","date":"2020-10-01T03:22:08","subject":"Re: [libcamera-devel] [PATCH 6/6] libcamera: pipeline: rkisp1: Add\n\tsupport for XRGB8888","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Sep 30, 2020 at 10:08:31PM +0200, Niklas Söderlund wrote:\n> The self path support XRGB8888, list it as a supported format.\n\ns/support/supports\n\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> index ff995286073db2a3..e98515c878aa451b 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> @@ -219,7 +219,7 @@ constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> \n> constexpr Size RKISP1_RSZ_SP_SRC_MIN{ 32, 16 };\n> constexpr Size RKISP1_RSZ_SP_SRC_MAX{ 1920, 1920 };\n> -constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> +constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> \tformats::YUYV,\n> \tformats::NV16,\n> \tformats::NV61,\n> @@ -227,7 +227,7 @@ constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> \tformats::NV12,\n> \tformats::R8,\n> \tformats::RGB565,\n> -\t/* \\todo Add support for BGR888 */\n> +\tformats::XRGB8888,\n> };\n> } /* namespace */\n> \n> -- \n> 2.28.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 834B8C3B5C\n\tfor ;\n\tThu, 1 Oct 2020 03:22:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4FB676221D;\n\tThu, 1 Oct 2020 05:22:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C75360394\n\tfor ;\n\tThu, 1 Oct 2020 05:22:15 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0BDA0255;\n\tThu, 1 Oct 2020 05:22:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fabLAj+Z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601522535;\n\tbh=Y3qjOzGTh/wkQMXEO+SpdFxI2hc9+FbxhPMl1tPlQVY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fabLAj+ZQFMfdkT7RoioVGmtr2dhEsg8KhOee9p9wFExII/jn5GegRY6I5yEmdMfz\n\tcoYVs2WJBocMIniAXtyTzSoN0UbF6MRcH2U9GRLjPCjG68b2mRkSSvroGQVAvHL9aK\n\tlz9HIF1sDQiJiGVTvwp8FPuIvn57eLqZGK0ic0SU=","Date":"Thu, 1 Oct 2020 12:22:08 +0900","From":"paul.elder@ideasonboard.com","To":"Niklas =?iso-8859-1?q?S=F6derlund?= ","Message-ID":"<20201001032208.GD45948@pyrite.rasen.tech>","References":"<20200930200831.2066751-1-niklas.soderlund@ragnatech.se>\n\t<20200930200831.2066751-7-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200930200831.2066751-7-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 6/6] libcamera: pipeline: rkisp1: Add\n\tsupport for XRGB8888","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]