[{"id":12917,"web_url":"https://patchwork.libcamera.org/comment/12917/","msgid":"<20201001032030.GC45948@pyrite.rasen.tech>","date":"2020-10-01T03:20:30","subject":"Re: [libcamera-devel] [PATCH 5/6] libcamera: Add support for\n\tXRGB8888 and XBGR8888","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Sep 30, 2020 at 10:08:30PM +0200, Niklas Söderlund wrote:\n> Add support for XRGB8888 and XBGR8888 formats.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/formats.cpp | 20 ++++++++++++++++++++\n> src/libcamera/v4l2_pixelformat.cpp | 2 ++\n> 2 files changed, 22 insertions(+)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index ebaae9be3d75fe58..cc6e579005b2d4b6 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -175,6 +175,26 @@ const std::map pixelFormatInfo{\n> \t\t.pixelsPerGroup = 1,\n> \t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n> \t} },\n> +\t{ formats::XRGB8888, {\n> +\t\t.name = \"XRGB8888\",\n> +\t\t.format = formats::XRGB8888,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_XBGR32),\n> +\t\t.bitsPerPixel = 32,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +\t\t.packed = false,\n> +\t\t.pixelsPerGroup = 1,\n> +\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t} },\n> +\t{ formats::XBGR8888, {\n> +\t\t.name = \"XBGR8888\",\n> +\t\t.format = formats::XBGR8888,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_XRGB32),\n> +\t\t.bitsPerPixel = 32,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +\t\t.packed = false,\n> +\t\t.pixelsPerGroup = 1,\n> +\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t} },\n> \t{ formats::ABGR8888, {\n> \t\t.name = \"ABGR8888\",\n> \t\t.format = formats::ABGR8888,\n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 30c94bb98f442b08..ea4eef2c19461d52 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -48,6 +48,8 @@ const std::map vpf2pf{\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB565), formats::RGB565 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), formats::BGR888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), formats::RGB888 },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_XBGR32), formats::XRGB8888 },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_XBGR32), formats::XBGR8888 },\n\nV4L2_PIX_FMT_XRGB32 ?\n\n\nPaul\n\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32), formats::ABGR8888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_ABGR32), formats::ARGB8888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_ARGB32), formats::BGRA8888 },\n> -- \n> 2.28.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E7BBC3B5C\n\tfor ;\n\tThu, 1 Oct 2020 03:20:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A4084622E7;\n\tThu, 1 Oct 2020 05:20:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9605E60394\n\tfor ;\n\tThu, 1 Oct 2020 05:20:38 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 12363255;\n\tThu, 1 Oct 2020 05:20:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ulUQ6HoH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601522438;\n\tbh=5qJt8KxnYvO7CMcwk4CtSJExQfUWQjGhfmFzW52SDxg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ulUQ6HoHbcknN6agzfJdaQt8hdxisqywu50paOcAd4RQKCqGO54G4Y6LmyOCJYWM9\n\tuHoKbPdlQLnycxstYqpRxiuOi33RjerRJ0PUqvdfxIl/z5FjIyzGFgSIvYoteQvRi1\n\tkGPNY98wks6+aCtOQ9Ixrd+qodBENIDsEnJ39v6w=","Date":"Thu, 1 Oct 2020 12:20:30 +0900","From":"paul.elder@ideasonboard.com","To":"Niklas =?iso-8859-1?q?S=F6derlund?= ","Message-ID":"<20201001032030.GC45948@pyrite.rasen.tech>","References":"<20200930200831.2066751-1-niklas.soderlund@ragnatech.se>\n\t<20200930200831.2066751-6-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200930200831.2066751-6-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 5/6] libcamera: Add support for\n\tXRGB8888 and XBGR8888","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]