[{"id":12913,"web_url":"https://patchwork.libcamera.org/comment/12913/","msgid":"<20201001031504.GY45948@pyrite.rasen.tech>","date":"2020-10-01T03:15:04","subject":"Re: [libcamera-devel] [PATCH 1/6] libcamera: pipeline: rkisp1:\n\tRemove support for YVYU and VYUY","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Sep 30, 2020 at 10:08:26PM +0200, Niklas Söderlund wrote:\n> The upstream driver have dropped support for YVYU and VYUY [1], remove\n\ns/have/has\n\n> support from the pipeline handler.\n> \n> 1. 3acb3e06baf64e28 (\"media: staging: rkisp1: cap: remove unsupported formats\")\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 8 ++------\n> 1 file changed, 2 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> index ee152c043224f205..410e9f5d94607f44 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> @@ -195,10 +195,8 @@ void RkISP1Path::stop()\n> namespace {\n> constexpr Size RKISP1_RSZ_MP_SRC_MIN{ 32, 16 };\n> constexpr Size RKISP1_RSZ_MP_SRC_MAX{ 4416, 3312 };\n> -constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> +constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> \tformats::YUYV,\n> -\tformats::YVYU,\n> -\tformats::VYUY,\n> \tformats::NV16,\n> \tformats::NV61,\n> \tformats::NV21,\n> @@ -208,10 +206,8 @@ constexpr std::array RKISP1_RSZ_MP_FORMATS{\n> \n> constexpr Size RKISP1_RSZ_SP_SRC_MIN{ 32, 16 };\n> constexpr Size RKISP1_RSZ_SP_SRC_MAX{ 1920, 1920 };\n> -constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> +constexpr std::array RKISP1_RSZ_SP_FORMATS{\n> \tformats::YUYV,\n> -\tformats::YVYU,\n> -\tformats::VYUY,\n> \tformats::NV16,\n> \tformats::NV61,\n> \tformats::NV21,\n> -- \n> 2.28.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 683C6C3B5B\n\tfor ;\n\tThu, 1 Oct 2020 03:15:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC21D622E7;\n\tThu, 1 Oct 2020 05:15:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 85E5E60394\n\tfor ;\n\tThu, 1 Oct 2020 05:15:12 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0BE0D255;\n\tThu, 1 Oct 2020 05:15:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QKZvcoJw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601522112;\n\tbh=zA8y6U3gS4x2Jlm05ONM/23D8nXPfkivr6e3O9480Fk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QKZvcoJwdKIz+ydwdJGJdE3zclBAlcgD/5s7jFePV4u3mJ3wd82QyIZpiPuWL7REP\n\tyzxOfUQpbrPTJ5g6Vux/gho1iz8bZ5hS8VU/mUO9PiOiguSbYDFp6g1lp6F9JBYxmv\n\t0JiWNnW30q1tzytXql0jBZcxtHI325vFfvdZndFA=","Date":"Thu, 1 Oct 2020 12:15:04 +0900","From":"paul.elder@ideasonboard.com","To":"Niklas =?iso-8859-1?q?S=F6derlund?= ","Message-ID":"<20201001031504.GY45948@pyrite.rasen.tech>","References":"<20200930200831.2066751-1-niklas.soderlund@ragnatech.se>\n\t<20200930200831.2066751-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200930200831.2066751-2-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 1/6] libcamera: pipeline: rkisp1:\n\tRemove support for YVYU and VYUY","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]