{"id":9877,"url":"https://patchwork.libcamera.org/api/patches/9877/?format=json","web_url":"https://patchwork.libcamera.org/patch/9877/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200930132707.19367-6-jacopo@jmondi.org>","date":"2020-09-30T13:27:03","name":"[libcamera-devel,v4,5/9] android: camera_device: Clear streams_ in close()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"84f21e40dabe0d3444bddcfcaf5cfd5a568bdc21","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9877/mbox/","series":[{"id":1340,"url":"https://patchwork.libcamera.org/api/series/1340/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1340","date":"2020-09-30T13:26:58","name":"android: camera_device: Add support for internal buffers","version":4,"mbox":"https://patchwork.libcamera.org/series/1340/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9877/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9877/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD076C3B5B\n\tfor ;\n\tWed, 30 Sep 2020 13:23:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 70711623B0;\n\tWed, 30 Sep 2020 15:23:27 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B1AD4622EE\n\tfor ;\n\tWed, 30 Sep 2020 15:23:24 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 9C52EC0015;\n\tWed, 30 Sep 2020 13:23:23 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 30 Sep 2020 15:27:03 +0200","Message-Id":"<20200930132707.19367-6-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20200930132707.19367-1-jacopo@jmondi.org>","References":"<20200930132707.19367-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 5/9] android: camera_device: Clear\n\tstreams_ in close()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When closing the CameraDevice, clear the streams_ vector to release all\nthe created CameraStream instances.\n\nSuggested-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex d73d10d9d449..8692771a4538 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -534,6 +534,7 @@ int CameraDevice::open(const hw_module_t *hardwareModule)\n \n void CameraDevice::close()\n {\n+\tstreams_.clear();\n \tallocator_.freeAll();\n \n \tcamera_->stop();\n","prefixes":["libcamera-devel","v4","5/9"]}