[{"id":12880,"web_url":"https://patchwork.libcamera.org/comment/12880/","msgid":"","date":"2020-09-29T19:53:55","subject":"Re: [libcamera-devel] [PATCH v3 2/6] libcamera: Initialise the\n\tSensorOutputSize property","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi David,\n\nOn 29/09/2020 17:39, David Plowman wrote:\n> Add a default initialisation according to the sensor resolution,\n> though it will need updating when the camera mode changes.\n> \n> Signed-off-by: David Plowman \n> Reviewed-by: Jacopo Mondi \n> ---\n> src/libcamera/camera_sensor.cpp | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index d2679a4b..c9a19b02 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -277,6 +277,12 @@ int CameraSensor::init()\n> \t */\n> \tresolution_ = sizes_.back();\n> \n> +\t/*\n> +\t * Set a default value for the SensorOutputSize, though it will have to\n> +\t * be updated when new camera modes are chosen.\n> +\t */\n> +\tproperties_.set(properties::SensorOutputSize, resolution_);\n\nI guess here, this is just an initialisation, but doesn't reflect what's\nactually set on the sensor yet.\n\nShould we also set this during setFormat() ?\n\n> +\n> \treturn 0;\n> }\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7F1EEC3B5B\n\tfor ;\n\tTue, 29 Sep 2020 19:54:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6ADC621C9;\n\tTue, 29 Sep 2020 21:53:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED22360394\n\tfor ;\n\tTue, 29 Sep 2020 21:53:58 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5E4FC9CC;\n\tTue, 29 Sep 2020 21:53:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AC0Vb5to\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601409238;\n\tbh=zvfyQVda23JC4xOEa5mIMs/2jJKKWCCQeEGcSvYef8w=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=AC0Vb5tozYfJkt3tuF4YH/8Ogs3xoiY9VlTync4FVX8CghbGwnWjlOp2aQ5AwkjmD\n\thgdFIDJQTW0C7PEMJXoc0B4k7ueXW3o2KEvB+lfkDa5qi/+i/ie11xZDzXJYDi3SEb\n\tWXBmWBVywcZCMCmV6Pndskrtj4nRtSP/6tXfgDJA=","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200929164000.15429-1-david.plowman@raspberrypi.com>\n\t<20200929164000.15429-3-david.plowman@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 29 Sep 2020 20:53:55 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200929164000.15429-3-david.plowman@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v3 2/6] libcamera: Initialise the\n\tSensorOutputSize property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12889,"web_url":"https://patchwork.libcamera.org/comment/12889/","msgid":"<20200930083226.6ve66yor62gomfzy@uno.localdomain>","date":"2020-09-30T08:32:26","subject":"Re: [libcamera-devel] [PATCH v3 2/6] libcamera: Initialise the\n\tSensorOutputSize property","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Tue, Sep 29, 2020 at 08:53:55PM +0100, Kieran Bingham wrote:\n> Hi David,\n>\n> On 29/09/2020 17:39, David Plowman wrote:\n> > Add a default initialisation according to the sensor resolution,\n> > though it will need updating when the camera mode changes.\n> >\n> > Signed-off-by: David Plowman \n> > Reviewed-by: Jacopo Mondi \n> > ---\n> > src/libcamera/camera_sensor.cpp | 6 ++++++\n> > 1 file changed, 6 insertions(+)\n> >\n> > diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> > index d2679a4b..c9a19b02 100644\n> > --- a/src/libcamera/camera_sensor.cpp\n> > +++ b/src/libcamera/camera_sensor.cpp\n> > @@ -277,6 +277,12 @@ int CameraSensor::init()\n> > \t */\n> > \tresolution_ = sizes_.back();\n> >\n> > +\t/*\n> > +\t * Set a default value for the SensorOutputSize, though it will have to\n> > +\t * be updated when new camera modes are chosen.\n> > +\t */\n> > +\tproperties_.set(properties::SensorOutputSize, resolution_);\n>\n> I guess here, this is just an initialisation, but doesn't reflect what's\n> actually set on the sensor yet.\n>\n> Should we also set this during setFormat() ?\n\nBefore the Camera is configured the value of the property is not\nrelevant. I think the property documentation reports that.\n\n>\n> > +\n> > \treturn 0;\n> > }\n> >\n> >\n>\n> --\n> Regards\n> --\n> Kieran\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69DEFC3B5C\n\tfor ;\n\tWed, 30 Sep 2020 08:28:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B0F362209;\n\tWed, 30 Sep 2020 10:28:33 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1CB760A0F\n\tfor ;\n\tWed, 30 Sep 2020 10:28:31 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 76D7460005;\n\tWed, 30 Sep 2020 08:28:30 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 30 Sep 2020 10:32:26 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20200930083226.6ve66yor62gomfzy@uno.localdomain>","References":"<20200929164000.15429-1-david.plowman@raspberrypi.com>\n\t<20200929164000.15429-3-david.plowman@raspberrypi.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v3 2/6] libcamera: Initialise the\n\tSensorOutputSize property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12893,"web_url":"https://patchwork.libcamera.org/comment/12893/","msgid":"<3789b529-8016-eb25-8c76-7bed445eb5ab@ideasonboard.com>","date":"2020-09-30T08:31:22","subject":"Re: [libcamera-devel] [PATCH v3 2/6] libcamera: Initialise the\n\tSensorOutputSize property","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 30/09/2020 09:32, Jacopo Mondi wrote:\n> Hi Kieran,\n> \n> On Tue, Sep 29, 2020 at 08:53:55PM +0100, Kieran Bingham wrote:\n>> Hi David,\n>>\n>> On 29/09/2020 17:39, David Plowman wrote:\n>>> Add a default initialisation according to the sensor resolution,\n>>> though it will need updating when the camera mode changes.\n>>>\n>>> Signed-off-by: David Plowman \n>>> Reviewed-by: Jacopo Mondi \n>>> ---\n>>> src/libcamera/camera_sensor.cpp | 6 ++++++\n>>> 1 file changed, 6 insertions(+)\n>>>\n>>> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n>>> index d2679a4b..c9a19b02 100644\n>>> --- a/src/libcamera/camera_sensor.cpp\n>>> +++ b/src/libcamera/camera_sensor.cpp\n>>> @@ -277,6 +277,12 @@ int CameraSensor::init()\n>>> \t */\n>>> \tresolution_ = sizes_.back();\n>>>\n>>> +\t/*\n>>> +\t * Set a default value for the SensorOutputSize, though it will have to\n>>> +\t * be updated when new camera modes are chosen.\n>>> +\t */\n>>> +\tproperties_.set(properties::SensorOutputSize, resolution_);\n>>\n>> I guess here, this is just an initialisation, but doesn't reflect what's\n>> actually set on the sensor yet.\n>>\n>> Should we also set this during setFormat() ?\n> \n> Before the Camera is configured the value of the property is not\n> relevant. I think the property documentation reports that.\n\nMy point/question was - is the 'real' sensor output size modified (or\npotentially modified) when ever a call is made through setFormat, and\nthus - should the SensorOutputSize be updated to reflect that.\n\nOr is SensorOutputSize a fixed immutable thing that never changes?\n\nMaybe that's my real question.\n\n*when* and *where* does this get updated when things change.\n--\nKieran\n\n\n> \n>>\n>>> +\n>>> \treturn 0;\n>>> }\n>>>\n>>>\n>>\n>> --\n>> Regards\n>> --\n>> Kieran\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 909D8C3B5B\n\tfor ;\n\tWed, 30 Sep 2020 08:31:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C70F62218;\n\tWed, 30 Sep 2020 10:31:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 67B5462201\n\tfor ;\n\tWed, 30 Sep 2020 10:31:25 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E21E0329;\n\tWed, 30 Sep 2020 10:31:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iQUFLgp0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601454685;\n\tbh=ruPROPPzS4Rteqv5bu/L+Jh3prnEwuG57YrSfAHwpas=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=iQUFLgp0QPgIVHbK/PGsZYnPz0yCTQh13Tu+DmhW/TpHrCR8/6auPhe0dxZGeCtcn\n\tRGeKMFebhZMHYq+LocUq4FSMUDEknT9LGYPi5G+bhZgDCtgFCjzWDk2zNa4pFonOCy\n\tfBmUgZ8q9rlXZK5tWK7xx9lo5sxbXyOaBQKrVt0U=","To":"Jacopo Mondi ","References":"<20200929164000.15429-1-david.plowman@raspberrypi.com>\n\t<20200929164000.15429-3-david.plowman@raspberrypi.com>\n\t\n\t<20200930083226.6ve66yor62gomfzy@uno.localdomain>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<3789b529-8016-eb25-8c76-7bed445eb5ab@ideasonboard.com>","Date":"Wed, 30 Sep 2020 09:31:22 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200930083226.6ve66yor62gomfzy@uno.localdomain>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v3 2/6] libcamera: Initialise the\n\tSensorOutputSize property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12898,"web_url":"https://patchwork.libcamera.org/comment/12898/","msgid":"<20200930085040.7gfd37isxnasvlaj@uno.localdomain>","date":"2020-09-30T08:50:40","subject":"Re: [libcamera-devel] [PATCH v3 2/6] libcamera: Initialise the\n\tSensorOutputSize property","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Wed, Sep 30, 2020 at 09:31:22AM +0100, Kieran Bingham wrote:\n>\n>\n> On 30/09/2020 09:32, Jacopo Mondi wrote:\n> > Hi Kieran,\n> >\n> > On Tue, Sep 29, 2020 at 08:53:55PM +0100, Kieran Bingham wrote:\n> >> Hi David,\n> >>\n> >> On 29/09/2020 17:39, David Plowman wrote:\n> >>> Add a default initialisation according to the sensor resolution,\n> >>> though it will need updating when the camera mode changes.\n> >>>\n> >>> Signed-off-by: David Plowman \n> >>> Reviewed-by: Jacopo Mondi \n> >>> ---\n> >>> src/libcamera/camera_sensor.cpp | 6 ++++++\n> >>> 1 file changed, 6 insertions(+)\n> >>>\n> >>> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> >>> index d2679a4b..c9a19b02 100644\n> >>> --- a/src/libcamera/camera_sensor.cpp\n> >>> +++ b/src/libcamera/camera_sensor.cpp\n> >>> @@ -277,6 +277,12 @@ int CameraSensor::init()\n> >>> \t */\n> >>> \tresolution_ = sizes_.back();\n> >>>\n> >>> +\t/*\n> >>> +\t * Set a default value for the SensorOutputSize, though it will have to\n> >>> +\t * be updated when new camera modes are chosen.\n> >>> +\t */\n> >>> +\tproperties_.set(properties::SensorOutputSize, resolution_);\n> >>\n> >> I guess here, this is just an initialisation, but doesn't reflect what's\n> >> actually set on the sensor yet.\n> >>\n> >> Should we also set this during setFormat() ?\n> >\n> > Before the Camera is configured the value of the property is not\n> > relevant. I think the property documentation reports that.\n>\n> My point/question was - is the 'real' sensor output size modified (or\n> potentially modified) when ever a call is made through setFormat, and\n> thus - should the SensorOutputSize be updated to reflect that.\n\nAssuming the discussion on the other patch is settled (have the\nproperty in Camera and not in CameraConfiguration and thus the\nproperty is updated at Camera::configure() time), the way the\nproperty is updated is up to the pipeline handler. RPi in example does\nnot set the sensor format on the CameraSensor at all, as it happens as\na consequence of a setFormat on the CSI-2 video device node and the\nformat is propagated in kernel space.\n\n>\n> Or is SensorOutputSize a fixed immutable thing that never changes?\n\nIt does indeed change here, some pipeline might decide they always go\nfull size. Anyway applications are meant to re-query the property\nafter a Camera::configure()\n\n>\n> Maybe that's my real question.\n>\n> *when* and *where* does this get updated when things change.\n\nOn pipeline handler side. Some pipeline handlers might want to\ncalculate it themselves, other will fetch the value directly from\nCameraSensor after a CameraSensor::setFormat() (in which case the\noperation should update the property, but at the moment it is not\nrequired for the RPi specificities described here above).\n\nThanks\n j\n\n> --\n> Kieran\n>\n>\n> >\n> >>\n> >>> +\n> >>> \treturn 0;\n> >>> }\n> >>>\n> >>>\n> >>\n> >> --\n> >> Regards\n> >> --\n> >> Kieran\n> >> _______________________________________________\n> >> libcamera-devel mailing list\n> >> libcamera-devel@lists.libcamera.org\n> >> https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F725C3B5C\n\tfor ;\n\tWed, 30 Sep 2020 08:46:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 012AC62229;\n\tWed, 30 Sep 2020 10:46:47 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1271462215\n\tfor ;\n\tWed, 30 Sep 2020 10:46:45 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 53FA740006;\n\tWed, 30 Sep 2020 08:46:44 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 30 Sep 2020 10:50:40 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20200930085040.7gfd37isxnasvlaj@uno.localdomain>","References":"<20200929164000.15429-1-david.plowman@raspberrypi.com>\n\t<20200929164000.15429-3-david.plowman@raspberrypi.com>\n\t\n\t<20200930083226.6ve66yor62gomfzy@uno.localdomain>\n\t<3789b529-8016-eb25-8c76-7bed445eb5ab@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<3789b529-8016-eb25-8c76-7bed445eb5ab@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 2/6] libcamera: Initialise the\n\tSensorOutputSize property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]