[{"id":12888,"web_url":"https://patchwork.libcamera.org/comment/12888/","msgid":"<0fd0530b-38af-8e6f-4e6d-5ee7bd11afa4@ideasonboard.com>","date":"2020-09-30T08:18:26","subject":"Re: [libcamera-devel] [PATCH v6 1/7] libcamera: properties: Add\n\tmodel property","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 29/09/2020 15:46, Niklas Söderlund wrote:\n> The model name must to the extent possible describe the sensor. For most\n> devices this is the model name of the sensor. While for some devices the\n> sensor model is unavailable as the sensor or the entire camera is part\n> of a larger unit and exposed as a black-box to the system. In such cases\n> the model name of the smallest component closest to the sensor must be\n> used.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> * Changes since v5\n> - Expand description.\n> - Changes so much by now I reluctantly have to drop Kieran's R-b :-(\n\nWhat? Oh ok I'll take another look. :-D\n\n\n> * Changes since v4\n> - Expand description.\n> \n> * Changes since v3\n> - s/as ASCII/in ASCII/\n> ---\n> src/libcamera/property_ids.yaml | 23 +++++++++++++++++++++++\n> 1 file changed, 23 insertions(+)\n> \n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index 74ad0195d6310367..3f634503a7f201e3 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -387,6 +387,29 @@ controls:\n> | |\n> +--------------------+\n> \n> + - Model:\n> + type: string\n> + description: |\n> + The model name must to the extent possible describe the sensor. For most\n> + devices this is the model name of the sensor. While for some devices the\n> + sensor model is unavailable as the sensor or the entire camera is part\n> + of a larger unit and exposed as a black-box to the system. In such cases\n> + the model name of the smallest component closest to the sensor must be\n> + used.\n\nI'm not sure I understand this ... as in ... like the CSI2\nreceiver/port? would that be a potential name used?\n\n> +\n> + The model name is not meant to be a camera name displayed to the\n> + end-user, but may be combined with other camera information to create a\n> + camera name.\n> +\n> + The model name is not guaranteed to be unique in the system nor is\n> + it guaranteed to be stable or have any other properties required to make\n> + it a good candidate to be used as a permanent identifier of a camera.\n> +\n> + The model name shall describe the camera in a human readable format and\n> + shall be encoded in ASCII.\n> +\n> + Example model names are 'ov5670', 'imx219' or 'Logitech Webcam C930e'.\n> +\n> - UnitCellSize:\n> type: Size\n> description: |\n> \n\nExcept for a small potential confusion on 'what the smallest component\nclosest to the sensor' might be interpreted as\n\nReviewed-by: Kieran Bingham \n\nBut perhaps that will be more evident to whomever has to deal with this\nin the future, as it sounds like a catch-all phrase to support what to\ndo if you can't get the sensor name directly, so I don't object to it.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E567C3B5B\n\tfor ;\n\tWed, 30 Sep 2020 08:18:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D1C506220F;\n\tWed, 30 Sep 2020 10:18:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ADA2E60A0F\n\tfor ;\n\tWed, 30 Sep 2020 10:18:29 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2B3A4329;\n\tWed, 30 Sep 2020 10:18:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KtoBAEjO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601453909;\n\tbh=8xaQsPC+Y8rvIb1v9hYki81G9iqJtHePoWa0x+eX7Qo=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=KtoBAEjORdRtCtNmq5T02/2lCfgvjqDz6sU81gxcSAOzz91f+jHSXoN9vNsEKSjo1\n\tlo9jcf4qaCy6tujSOVL4dZyP69E2jIre5b3VGggs6zWj6N4M3d8MIVstG9KNNgoVc9\n\tMu+w5QnMPyuRFJCS5pSjbNuX6hYfG/BL2s7nevm8=","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200929144648.429397-1-niklas.soderlund@ragnatech.se>\n\t<20200929144648.429397-2-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<0fd0530b-38af-8e6f-4e6d-5ee7bd11afa4@ideasonboard.com>","Date":"Wed, 30 Sep 2020 09:18:26 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200929144648.429397-2-niklas.soderlund@ragnatech.se>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v6 1/7] libcamera: properties: Add\n\tmodel property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12928,"web_url":"https://patchwork.libcamera.org/comment/12928/","msgid":"<20201002021959.GW3722@pendragon.ideasonboard.com>","date":"2020-10-02T02:19:59","subject":"Re: [libcamera-devel] [PATCH v6 1/7] libcamera: properties: Add\n\tmodel property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas and Kieran,\n\nOn Wed, Sep 30, 2020 at 09:18:26AM +0100, Kieran Bingham wrote:\n> On 29/09/2020 15:46, Niklas Söderlund wrote:\n> > The model name must to the extent possible describe the sensor. For most\n> > devices this is the model name of the sensor. While for some devices the\n> > sensor model is unavailable as the sensor or the entire camera is part\n> > of a larger unit and exposed as a black-box to the system. In such cases\n> > the model name of the smallest component closest to the sensor must be\n> > used.\n> > \n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > * Changes since v5\n> > - Expand description.\n> > - Changes so much by now I reluctantly have to drop Kieran's R-b :-(\n> \n> What? Oh ok I'll take another look. :-D\n> \n> > * Changes since v4\n> > - Expand description.\n> > \n> > * Changes since v3\n> > - s/as ASCII/in ASCII/\n> > ---\n> > src/libcamera/property_ids.yaml | 23 +++++++++++++++++++++++\n> > 1 file changed, 23 insertions(+)\n> > \n> > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > index 74ad0195d6310367..3f634503a7f201e3 100644\n> > --- a/src/libcamera/property_ids.yaml\n> > +++ b/src/libcamera/property_ids.yaml\n> > @@ -387,6 +387,29 @@ controls:\n> > | |\n> > +--------------------+\n> > \n> > + - Model:\n\nI've initially thought we could come up with a good definition of what\nwould be a generic camera model, but it's quite difficult. We can't\nalways use the sensor name, mostly because of UVC cameras, but I can\nalso imagine using the name of a GMSL, FPD-Link III or MIPI A-PHY camera\nbox instead of the sensor name in the future). There's also the issue of\nlogical cameras using multiple sensors that should be taken into\naccount.\n\nFor all of these reasons, I think we'll end up reworking this in the\nfuture when more use cases will emerge, I'll stop trying to reach\nperfection. As the model name is the sensor name in the normal case, I'd\nbe fine if we renamed this SensorModel. Up to you.\n\n> > + type: string\n> > + description: |\n> > + The model name must to the extent possible describe the sensor. For most\n\ns/must/shall/\n\n> > + devices this is the model name of the sensor. While for some devices the\n> > + sensor model is unavailable as the sensor or the entire camera is part\n> > + of a larger unit and exposed as a black-box to the system. In such cases\n> > + the model name of the smallest component closest to the sensor must be\n\nDitto.\n\n> > + used.\n> \n> I'm not sure I understand this ... as in ... like the CSI2\n> receiver/port? would that be a potential name used?\n\nIt's a bit confusing indeed. Maybe \"[...] the model name of the smallest\ndevice that contains the camera sensor [...]\" ?\n\n> > +\n> > + The model name is not meant to be a camera name displayed to the\n> > + end-user, but may be combined with other camera information to create a\n> > + camera name.\n> > +\n> > + The model name is not guaranteed to be unique in the system nor is\n> > + it guaranteed to be stable or have any other properties required to make\n> > + it a good candidate to be used as a permanent identifier of a camera.\n\nDo you foresee cases where it won't be stable ?\n\nReviewed-by: Laurent Pinchart \n\n> > +\n> > + The model name shall describe the camera in a human readable format and\n> > + shall be encoded in ASCII.\n> > +\n> > + Example model names are 'ov5670', 'imx219' or 'Logitech Webcam C930e'.\n> > +\n> > - UnitCellSize:\n> > type: Size\n> > description: |\n> \n> Except for a small potential confusion on 'what the smallest component\n> closest to the sensor' might be interpreted as\n> \n> Reviewed-by: Kieran Bingham \n> \n> But perhaps that will be more evident to whomever has to deal with this\n> in the future, as it sounds like a catch-all phrase to support what to\n> do if you can't get the sensor name directly, so I don't object to it.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B9A6DC3B5B\n\tfor ;\n\tFri, 2 Oct 2020 02:20:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4DE056229F;\n\tFri, 2 Oct 2020 04:20:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C0EBA60BCD\n\tfor ;\n\tFri, 2 Oct 2020 04:20:37 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 34B4B528;\n\tFri, 2 Oct 2020 04:20:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aZxalPjG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601605237;\n\tbh=swj3Amv/ZtmT6FWiGMpMIbiin7n2OPo8YchnuovWo9s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=aZxalPjG43MLcWUw6TIQiIC2qdWAPHuaBGefZsUJAssZDxa/hVKWk2t972NKtjuqF\n\tQ5UaUkF4caZLoJpPY1tetgVzOCUvyrzc2PzR1W4LF9Djxo9xn0YqMpuiUeH+zeqqVq\n\tHofMhAjc+GjnXnekV3P4vlpYreuggisQ572Ub3T0=","Date":"Fri, 2 Oct 2020 05:19:59 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20201002021959.GW3722@pendragon.ideasonboard.com>","References":"<20200929144648.429397-1-niklas.soderlund@ragnatech.se>\n\t<20200929144648.429397-2-niklas.soderlund@ragnatech.se>\n\t<0fd0530b-38af-8e6f-4e6d-5ee7bd11afa4@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<0fd0530b-38af-8e6f-4e6d-5ee7bd11afa4@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v6 1/7] libcamera: properties: Add\n\tmodel property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]