[{"id":1363,"web_url":"https://patchwork.libcamera.org/comment/1363/","msgid":"<20190415202504.GU1980@bigcity.dyn.berto.se>","date":"2019-04-15T20:25:04","subject":"Re: [libcamera-devel] [PATCH 04/11] libcamera: geometry: Sort\n\tclasses alphabetically","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-04-15 19:56:53 +0300, Laurent Pinchart wrote:\n> Move the Size class before the SizeRange class. No functional change.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/geometry.h | 30 +++++++++----------\n> src/libcamera/geometry.cpp | 58 ++++++++++++++++++------------------\n> 2 files changed, 44 insertions(+), 44 deletions(-)\n> \n> diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\n> index f41017aa47bf..7704ab5add21 100644\n> --- a/include/libcamera/geometry.h\n> +++ b/include/libcamera/geometry.h\n> @@ -21,6 +21,21 @@ struct Rectangle {\n> \tconst std::string toString() const;\n> };\n> \n> +struct Size {\n> +\tSize()\n> +\t\t: Size(0, 0)\n> +\t{\n> +\t}\n> +\n> +\tSize(unsigned int w, unsigned int h)\n> +\t\t: width(w), height(h)\n> +\t{\n> +\t}\n> +\n> +\tunsigned int width;\n> +\tunsigned int height;\n> +};\n> +\n> struct SizeRange {\n> \tSizeRange()\n> \t\t: SizeRange(0, 0, 0, 0)\n> @@ -40,21 +55,6 @@ struct SizeRange {\n> \tunsigned int maxHeight;\n> };\n> \n> -struct Size {\n> -\tSize()\n> -\t\t: Size(0, 0)\n> -\t{\n> -\t}\n> -\n> -\tSize(unsigned int w, unsigned int h)\n> -\t\t: width(w), height(h)\n> -\t{\n> -\t}\n> -\n> -\tunsigned int width;\n> -\tunsigned int height;\n> -};\n> -\n> } /* namespace libcamera */\n> \n> #endif /* __LIBCAMERA_GEOMETRY_H__ */\n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index d63eceaf827b..1f875bbe5f48 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -62,6 +62,35 @@ const std::string Rectangle::toString() const\n> \treturn ss.str();\n> }\n> \n> +/**\n> + * \\struct Size\n> + * \\brief Describe a two-dimensional size\n> + *\n> + * The Size structure defines a two-dimensional size with integer precision.\n> + */\n> +\n> +/**\n> + * \\fn Size::Size()\n> + * \\brief Construct a Size with width and height set to 0\n> + */\n> +\n> +/**\n> + * \\fn Size::Size(unsigned int width, unsigned int height)\n> + * \\brief Construct a Size with given \\a width and \\a height\n> + * \\param width The Size width\n> + * \\param height The Size height\n> + */\n> +\n> +/**\n> + * \\var Size::width\n> + * \\brief The Size width\n> + */\n> +\n> +/**\n> + * \\var Size::height\n> + * \\brief The Size height\n> + */\n> +\n> /**\n> * \\struct SizeRange\n> * \\brief Describe a range of image sizes\n> @@ -105,33 +134,4 @@ const std::string Rectangle::toString() const\n> * \\brief The maximum image height\n> */\n> \n> -/**\n> - * \\struct Size\n> - * \\brief Describe a two-dimensional size\n> - *\n> - * The Size structure defines a two-dimensional size with integer precision.\n> - */\n> -\n> -/**\n> - * \\fn Size::Size()\n> - * \\brief Construct a Size with width and height set to 0\n> - */\n> -\n> -/**\n> - * \\fn Size::Size(unsigned int width, unsigned int height)\n> - * \\brief Construct a Size with given \\a width and \\a height\n> - * \\param width The Size width\n> - * \\param height The Size height\n> - */\n> -\n> -/**\n> - * \\var Size::width\n> - * \\brief The Size width\n> - */\n> -\n> -/**\n> - * \\var Size::height\n> - * \\brief The Size height\n> - */\n> -\n> } /* namespace libcamera */\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x236.google.com (mail-lj1-x236.google.com\n\t[IPv6:2a00:1450:4864:20::236])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0FFEE60B2E\n\tfor ;\n\tMon, 15 Apr 2019 22:25:06 +0200 (CEST)","by mail-lj1-x236.google.com with SMTP id h16so16911744ljg.11\n\tfor ;\n\tMon, 15 Apr 2019 13:25:06 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tr1sm10191690lfm.7.2019.04.15.13.25.04\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 15 Apr 2019 13:25:04 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=RlPBEBtj1n3CsRX/QOXFgWDC4VC4lngIJe5M9SA+qMQ=;\n\tb=OQtcsCmSzN7fxIJgXBcva/pa9kAeYC/O8oEfG2hNn1NAS84WeF7qpvfBBxHuQUd5uN\n\tjVlkYTIiJIXxzcSviiFMEbz96/rA6VIJc5edR0BNv0WtIecW+kh8s84Obx7kVkUTevSg\n\tJXglRGtg+fjkY9POENXYK0VLOZCxWfDyN0vsCFyCYHvm9IkKovZPP49Tayp5mQUNDcdE\n\tup0heHmfDAXvb5YQgsVCLitaMG67CX89Zg3eeZ2Jt1ucnsHITVw3Db5doAE/em7Tp9bn\n\tqklU8s8tEbl28BWTbKfl93Bjng1oDMQbtquVpB39ZXOyTD7Za6zKR1o/x+h2SjVvWDgX\n\tWq4w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=RlPBEBtj1n3CsRX/QOXFgWDC4VC4lngIJe5M9SA+qMQ=;\n\tb=XvDZU4MILa5RC+u6NZ/87/lUSoqX8mNqZSlQrkxks+3ly2S6QoqT8O/L6IwrlnUZD+\n\tFGNHl0DnwUtneFJceNi+1bArOndK/NxsBXAp0YtrloEKlLu+dw0LNLB3p1Uud2mIHIw8\n\t526e5GQ9W2ZRwXhiEqGSxW/a9fF5R8jOJlNENUSDd/rClawnw1lDhHRo8ZadOND/sPta\n\tzbSTrECFPlbMDtEUMjXVIQu3nA7/2TFI6UFCJd4fKFcpMmvzWQFgzywKVBjCBtgUBvPp\n\t2K6uGKPdqrTijqHpUtwB6i/VS8NeDGIhkQYzJ92534KGll0i+5EC4Cr4euy2oF4ZYmxE\n\t9+oA==","X-Gm-Message-State":"APjAAAX+TlkGOI7uWX+ifsf0GaXos0JlgeLDl0pG53yw2s66jeJwv3Mz\n\tZ2IqpTtD7DdIQHbvHUKhVQZ/KQ==","X-Google-Smtp-Source":"APXvYqz5GaNabBUhIbnN3/LQpsoI480wRkKKUG0yc6gHDiDJC5ruOiC8M691d5laE2B/GmiSV3NMrw==","X-Received":"by 2002:a2e:87cd:: with SMTP id\n\tv13mr40180087ljj.98.1555359905523; \n\tMon, 15 Apr 2019 13:25:05 -0700 (PDT)","Date":"Mon, 15 Apr 2019 22:25:04 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190415202504.GU1980@bigcity.dyn.berto.se>","References":"<20190415165700.22970-1-laurent.pinchart@ideasonboard.com>\n\t<20190415165700.22970-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190415165700.22970-5-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH 04/11] libcamera: geometry: Sort\n\tclasses alphabetically","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 15 Apr 2019 20:25:06 -0000"}},{"id":1390,"web_url":"https://patchwork.libcamera.org/comment/1390/","msgid":"<20190416150119.zavtmvrekuklo5qp@uno.localdomain>","date":"2019-04-16T15:01:19","subject":"Re: [libcamera-devel] [PATCH 04/11] libcamera: geometry: Sort\n\tclasses alphabetically","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Apr 15, 2019 at 07:56:53PM +0300, Laurent Pinchart wrote:\n> Move the Size class before the SizeRange class. No functional change.\n>\n> Signed-off-by: Laurent Pinchart \n\nThanks\nReviewed-by: Jacopo Mondi \n\n> ---\n> include/libcamera/geometry.h | 30 +++++++++----------\n> src/libcamera/geometry.cpp | 58 ++++++++++++++++++------------------\n> 2 files changed, 44 insertions(+), 44 deletions(-)\n>\n> diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\n> index f41017aa47bf..7704ab5add21 100644\n> --- a/include/libcamera/geometry.h\n> +++ b/include/libcamera/geometry.h\n> @@ -21,6 +21,21 @@ struct Rectangle {\n> \tconst std::string toString() const;\n> };\n>\n> +struct Size {\n> +\tSize()\n> +\t\t: Size(0, 0)\n> +\t{\n> +\t}\n> +\n> +\tSize(unsigned int w, unsigned int h)\n> +\t\t: width(w), height(h)\n> +\t{\n> +\t}\n> +\n> +\tunsigned int width;\n> +\tunsigned int height;\n> +};\n> +\n> struct SizeRange {\n> \tSizeRange()\n> \t\t: SizeRange(0, 0, 0, 0)\n> @@ -40,21 +55,6 @@ struct SizeRange {\n> \tunsigned int maxHeight;\n> };\n>\n> -struct Size {\n> -\tSize()\n> -\t\t: Size(0, 0)\n> -\t{\n> -\t}\n> -\n> -\tSize(unsigned int w, unsigned int h)\n> -\t\t: width(w), height(h)\n> -\t{\n> -\t}\n> -\n> -\tunsigned int width;\n> -\tunsigned int height;\n> -};\n> -\n> } /* namespace libcamera */\n>\n> #endif /* __LIBCAMERA_GEOMETRY_H__ */\n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index d63eceaf827b..1f875bbe5f48 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -62,6 +62,35 @@ const std::string Rectangle::toString() const\n> \treturn ss.str();\n> }\n>\n> +/**\n> + * \\struct Size\n> + * \\brief Describe a two-dimensional size\n> + *\n> + * The Size structure defines a two-dimensional size with integer precision.\n> + */\n> +\n> +/**\n> + * \\fn Size::Size()\n> + * \\brief Construct a Size with width and height set to 0\n> + */\n> +\n> +/**\n> + * \\fn Size::Size(unsigned int width, unsigned int height)\n> + * \\brief Construct a Size with given \\a width and \\a height\n> + * \\param width The Size width\n> + * \\param height The Size height\n> + */\n> +\n> +/**\n> + * \\var Size::width\n> + * \\brief The Size width\n> + */\n> +\n> +/**\n> + * \\var Size::height\n> + * \\brief The Size height\n> + */\n> +\n> /**\n> * \\struct SizeRange\n> * \\brief Describe a range of image sizes\n> @@ -105,33 +134,4 @@ const std::string Rectangle::toString() const\n> * \\brief The maximum image height\n> */\n>\n> -/**\n> - * \\struct Size\n> - * \\brief Describe a two-dimensional size\n> - *\n> - * The Size structure defines a two-dimensional size with integer precision.\n> - */\n> -\n> -/**\n> - * \\fn Size::Size()\n> - * \\brief Construct a Size with width and height set to 0\n> - */\n> -\n> -/**\n> - * \\fn Size::Size(unsigned int width, unsigned int height)\n> - * \\brief Construct a Size with given \\a width and \\a height\n> - * \\param width The Size width\n> - * \\param height The Size height\n> - */\n> -\n> -/**\n> - * \\var Size::width\n> - * \\brief The Size width\n> - */\n> -\n> -/**\n> - * \\var Size::height\n> - * \\brief The Size height\n> - */\n> -\n> } /* namespace libcamera */\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA20560DB4\n\tfor ;\n\tTue, 16 Apr 2019 17:00:27 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 38BEF20010;\n\tTue, 16 Apr 2019 15:00:27 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Tue, 16 Apr 2019 17:01:19 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190416150119.zavtmvrekuklo5qp@uno.localdomain>","References":"<20190415165700.22970-1-laurent.pinchart@ideasonboard.com>\n\t<20190415165700.22970-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"fak52sv3pvclq5tw\"","Content-Disposition":"inline","In-Reply-To":"<20190415165700.22970-5-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 04/11] libcamera: geometry: Sort\n\tclasses alphabetically","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 16 Apr 2019 15:00:28 -0000"}}]