[{"id":12854,"web_url":"https://patchwork.libcamera.org/comment/12854/","msgid":"<20200929023355.GS45948@pyrite.rasen.tech>","date":"2020-09-29T02:33:55","subject":"Re: [libcamera-devel] [PATCH] libcamera: span: Use default copy\n\tassignemnt operator","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Tue, Sep 29, 2020 at 04:18:50AM +0300, Laurent Pinchart wrote:\n> The custom implementation of the copy assignment operator is identical\n> to the one the compiler would generate. Replace it by the default.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> include/libcamera/span.h | 7 +------\n> 1 file changed, 1 insertion(+), 6 deletions(-)\n> \n> diff --git a/include/libcamera/span.h b/include/libcamera/span.h\n> index 738af6aca871..a53a80b81640 100644\n> --- a/include/libcamera/span.h\n> +++ b/include/libcamera/span.h\n> @@ -188,12 +188,7 @@ public:\n> \t}\n> \n> \tconstexpr Span(const Span &other) noexcept = default;\n> -\n> -\tconstexpr Span &operator=(const Span &other) noexcept\n> -\t{\n> -\t\tdata_ = other.data_;\n> -\t\treturn *this;\n> -\t}\n> +\tconstexpr Span &operator=(const Span &other) noexcept = default;\n> \n> \tconstexpr iterator begin() const { return data(); }\n> \tconstexpr const_iterator cbegin() const { return begin(); }\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B78A1C3B5B\n\tfor ;\n\tTue, 29 Sep 2020 02:34:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3AC8962033;\n\tTue, 29 Sep 2020 04:34:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 730AB60394\n\tfor ;\n\tTue, 29 Sep 2020 04:34:03 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CB049540;\n\tTue, 29 Sep 2020 04:34:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MiTBBGdN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601346843;\n\tbh=hIgDa4uEaybWJHplpLDlKrSC8Nd1ZAMrnceimtuAUwk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MiTBBGdNiz4U8IZC1RYd22MBL0gnscYPWtUISXOtOL/RlwtyqkvGkLy9Jp1RDkJfC\n\t6xenM5Oz97cx9j8XP2CuzMRNz3MJ37nQIERwBw6vmqfmAJKPvMISRXG+SGM278C8F5\n\tYoJoWmnbNwmjbar9/g3q6EDGj7b/M8d/0mExZ7k0=","Date":"Tue, 29 Sep 2020 11:33:55 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20200929023355.GS45948@pyrite.rasen.tech>","References":"<20200929011850.13997-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200929011850.13997-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: span: Use default copy\n\tassignemnt operator","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12864,"web_url":"https://patchwork.libcamera.org/comment/12864/","msgid":"<20200929052016.GD1052036@oden.dyn.berto.se>","date":"2020-09-29T05:20:16","subject":"Re: [libcamera-devel] [PATCH] libcamera: span: Use default copy\n\tassignemnt operator","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-09-29 04:18:50 +0300, Laurent Pinchart wrote:\n> The custom implementation of the copy assignment operator is identical\n> to the one the compiler would generate. Replace it by the default.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/span.h | 7 +------\n> 1 file changed, 1 insertion(+), 6 deletions(-)\n> \n> diff --git a/include/libcamera/span.h b/include/libcamera/span.h\n> index 738af6aca871..a53a80b81640 100644\n> --- a/include/libcamera/span.h\n> +++ b/include/libcamera/span.h\n> @@ -188,12 +188,7 @@ public:\n> \t}\n> \n> \tconstexpr Span(const Span &other) noexcept = default;\n> -\n> -\tconstexpr Span &operator=(const Span &other) noexcept\n> -\t{\n> -\t\tdata_ = other.data_;\n> -\t\treturn *this;\n> -\t}\n> +\tconstexpr Span &operator=(const Span &other) noexcept = default;\n> \n> \tconstexpr iterator begin() const { return data(); }\n> \tconstexpr const_iterator cbegin() const { return begin(); }\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C22FC3B5B\n\tfor ;\n\tTue, 29 Sep 2020 05:20:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E7A67620BC;\n\tTue, 29 Sep 2020 07:20:19 +0200 (CEST)","from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8FC0A6035E\n\tfor ;\n\tTue, 29 Sep 2020 07:20:18 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id a22so2904228ljp.13\n\tfor ;\n\tMon, 28 Sep 2020 22:20:18 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\t10sm3121407lfo.197.2020.09.28.22.20.16\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 28 Sep 2020 22:20:17 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"UKKzk6XT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=ywSEpWg05RqFGP3pCL9KhC/jEhrAjGdZBjWArMOHF+8=;\n\tb=UKKzk6XTkB6rL+IxcdBKatDjwMz/zV8J1CmicmhLL8RyTj00ITizEQryKzgAiW4ita\n\tTeEsPbsZMa4j889brdElV1IYe92smF2xr/pUUIHGew3hV/cmx2uEc3LzHjZu6QOXLoHi\n\tORxO9+Zj2CJeYT/GOZwZQX6FfdeZG/4ipIZW7LBwbVzsOthI6SNs0uMO63WoiseJ0t+Q\n\tEaRSKth3TmxXOl+gOvpOMImPIhtbo2GAq8sDxq9mYFXK40cjku3Cp3toZz7RpKEdPO+v\n\t7kLGUs5iC7G6rj78PwN1iLDt/BhWv5brjraye706PQQaAZtSvFhlGmf05YyY96X9ip/b\n\tyx7w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=ywSEpWg05RqFGP3pCL9KhC/jEhrAjGdZBjWArMOHF+8=;\n\tb=s0cMB0lE03Ogle7UOxOgY2GjX1x7U8cFU1L4Mi7XqR868mcX2tWoU9VYRq6z6ktXqa\n\tqNphuXWWknQUwoXzQQ6fbVMbX1Ehf7QHMFh1kUHYGOVqSAtqcO+yDf0gQf8YJsSuRs7C\n\tH4nTZhoF9HtaaTQk/TKsUlm6PFaBD+9fBZw3XjAcv+syqlrRNVRuQyshczo7Netk7b2p\n\tzQGnIM/rw15+etuyQbTl9yFa9P/2ZZXNUWsaPL/6gpNWDWuo0NEBOIP3A02HMmc38ceC\n\tOlXKk4Th8OAZJx70SRd7jpL3KZwWSPs7WWWn37dKHhPta8jCAVrSrq0qdf/Zv1T+u280\n\t3W9A==","X-Gm-Message-State":"AOAM533xR6NruehmGL/EuOks58nFPZdFd/RfCNfXm6sYl/FJMCTMKm9i\n\t+noH0weOwZfee+g1prhlBMEe6Q==","X-Google-Smtp-Source":"ABdhPJzTnZCgq7W4vA5KuXtP9tny/9elJiqc0sSG72Dv7T5c86rfwS826xeVJrvhs7808r0HS9j82A==","X-Received":"by 2002:a2e:b0fc:: with SMTP id h28mr643838ljl.114.1601356817767;\n\tMon, 28 Sep 2020 22:20:17 -0700 (PDT)","Date":"Tue, 29 Sep 2020 07:20:16 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200929052016.GD1052036@oden.dyn.berto.se>","References":"<20200929011850.13997-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200929011850.13997-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: span: Use default copy\n\tassignemnt operator","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]