[{"id":12821,"web_url":"https://patchwork.libcamera.org/comment/12821/","msgid":"<20200928201640.GA5543@pendragon.ideasonboard.com>","date":"2020-09-28T20:16:40","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: ipa: rkisp1: Include\n\tlinux/v4l2-controls.h","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Sep 28, 2020 at 10:13:10PM +0200, Niklas Söderlund wrote:\n> Do not depend on other headers to pull in the V4L2 controls header.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/rkisp1/rkisp1.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index d95d902adff3e244..0f5f8a8b436e60ff 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -13,6 +13,7 @@\n> #include \n> \n> #include \n> +#include \n> \n> #include \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 135DEC3B5C\n\tfor ;\n\tMon, 28 Sep 2020 20:17:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9538960BF7;\n\tMon, 28 Sep 2020 22:17:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59C5860366\n\tfor ;\n\tMon, 28 Sep 2020 22:17:15 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CDB1EA58;\n\tMon, 28 Sep 2020 22:17:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"G111M8Wg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601324235;\n\tbh=a/aK9z2qheHVyOYcBDttyY+P/ZamfAePzdBhEAAPv1w=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=G111M8Wg5sckRiFsMVbeqD/C9a0wC/mB7QqSTfTGDQvZ/51JQbR0tahYVzsCOUqjQ\n\trYbiyXDpDAxKj6ISagH0/nSpzDBfANXcODv2qbAgTFEVxT7FPlQOQ+8KaKW3O0cnFW\n\tlEFPaoTMWQ6INxyu9MvkasFifJ9W6OjvuZ0w5+Qg=","Date":"Mon, 28 Sep 2020 23:16:40 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200928201640.GA5543@pendragon.ideasonboard.com>","References":"<20200928201311.3995725-1-niklas.soderlund@ragnatech.se>\n\t<20200928201311.3995725-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200928201311.3995725-2-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: ipa: rkisp1: Include\n\tlinux/v4l2-controls.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]