[{"id":12839,"web_url":"https://patchwork.libcamera.org/comment/12839/","msgid":"<20200928230604.GA23539@pendragon.ideasonboard.com>","date":"2020-09-28T23:06:04","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: Drop setStream()\n\tfrom configure() documentation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, Sep 28, 2020 at 10:28:58AM +0200, Jacopo Mondi wrote:\n> There is no requirement for Stream to be assigned to StreamConfiguration\n> during PipelineHandler::configure().\n\nThere is a requirement, as it's documented :-) It doesn't mean we can't\ndrop the requirement if we consider it of no use.\n\n> It actually happens at validate()\n> time in most implementations right now.\n> \n> Drop this requirement from PipelineHandler::configure() documentation.\n> \n> Signed-off-by: Jacopo Mondi \n\nWith the commit message reworded, including a short explanation as for\nwhy this requirement is not needed,\n\nAcked-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline_handler.cpp | 4 ----\n> 1 file changed, 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 918aea1e8328..713fe6d1d362 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -314,10 +314,6 @@ const ControlList &PipelineHandler::properties(const Camera *camera) const\n> * perform further validation and may rely on any custom field stored in its\n> * custom CameraConfiguration derived class.\n> *\n> - * When configuring the camera the pipeline handler shall associate a Stream\n> - * instance to each StreamConfiguration entry in the CameraConfiguration using\n> - * the StreamConfiguration::setStream() method.\n> - *\n> * \\context This function is called from the CameraManager thread.\n> *\n> * \\return 0 on success or a negative error code otherwise","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8EBEC3B5B\n\tfor ;\n\tMon, 28 Sep 2020 23:06:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D94C6138F;\n\tTue, 29 Sep 2020 01:06:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D1EB60394\n\tfor ;\n\tTue, 29 Sep 2020 01:06:39 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 07192A58;\n\tTue, 29 Sep 2020 01:06:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Q/e3g0Lw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601334399;\n\tbh=ghjHrBHiv+kIBzygiJ+QBz4CJKdob2cRIJi64VJAW1s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Q/e3g0Lw1XratlgtZPlEfUyHUN2D9g3GoMGES6CD18z/ZhU3UFeYFLZDFaKPLVeRR\n\tDFnhV9ccQ0n2Nbd2zNQ3AsC31VCK/WnN2M62BDJxODmAwyncHN3O01HZOeLjJCzZZX\n\tjthvTiqwSqxXHsB/LCrMzgRLtPPwYacVeUMBY1BE=","Date":"Tue, 29 Sep 2020 02:06:04 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200928230604.GA23539@pendragon.ideasonboard.com>","References":"<20200928082858.2994-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200928082858.2994-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: Drop setStream()\n\tfrom configure() documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]