[{"id":12814,"web_url":"https://patchwork.libcamera.org/comment/12814/","msgid":"<20200928165836.GG23539@pendragon.ideasonboard.com>","date":"2020-09-28T16:58:36","subject":"Re: [libcamera-devel] [PATCH v5 5/7] libcamera: pipeline: uvcvideo:\n\tSet sensor model property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Fri, Sep 25, 2020 at 05:07:41PM +0200, Niklas Söderlund wrote:\n> Set the sensor model property from the model reported in the media\n> graph.\n> \n> Signed-off-by: Niklas Söderlund \n> Reviewed-by: Kieran Bingham \n\nProvided this will still be applicable once we agree on 1/7,\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> * Changes since v1\n> - Ensure model string only contains ASCII characters.\n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index bf12189d1044cdfc..335f0efcc1eb31c9 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -506,6 +506,7 @@ int UVCCameraData::init(MediaDevice *media)\n> \t * Until then, treat all UVC cameras as external.\n> \t */\n> \tproperties_.set(properties::Location, properties::CameraLocationExternal);\n> +\tproperties_.set(properties::Model, utils::toAscii(media->model()));\n> \n> \t/* Initialise the supported controls. */\n> \tControlInfoMap::Map ctrls;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E77FC3B5C\n\tfor ;\n\tMon, 28 Sep 2020 16:59:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E28DF60BF7;\n\tMon, 28 Sep 2020 18:59:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 096D060366\n\tfor ;\n\tMon, 28 Sep 2020 18:59:12 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8C1CA54E;\n\tMon, 28 Sep 2020 18:59:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qi8khJOt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601312351;\n\tbh=0J+q6YnKtHU2gQ74gwWiN6uq6UuIhX7Kl1Zu9H8dSjM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qi8khJOtKeaY6KWstK7G1JjR3uL7E30AiURCmklxwZ+J/ErcQKwwzdM+SLIcTlVB6\n\tCz3t9CZG7MyYfnyjHsSt29OKhF+bNJ6RVaF5Mi620WpCWwpfShs2cns/0IvIZUr42z\n\tkM8u3JV68JvdH9bzH0vsqapbZdOeU1Gh0YQJFKdM=","Date":"Mon, 28 Sep 2020 19:58:36 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200928165836.GG23539@pendragon.ideasonboard.com>","References":"<20200925150743.1822226-1-niklas.soderlund@ragnatech.se>\n\t<20200925150743.1822226-6-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200925150743.1822226-6-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v5 5/7] libcamera: pipeline: uvcvideo:\n\tSet sensor model property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]