[{"id":12806,"web_url":"https://patchwork.libcamera.org/comment/12806/","msgid":"<20200928113325.uj3njkqf4dq7kpgc@uno.localdomain>","date":"2020-09-28T11:33:25","subject":"Re: [libcamera-devel] [PATCH v5 3/7] libcamera: camera_sensor: Set\n\tsensor model property","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Fri, Sep 25, 2020 at 05:07:39PM +0200, Niklas Söderlund wrote:\n> Set the sensor model property.\n>\n> Signed-off-by: Niklas Söderlund \n> Reviewed-by: Kieran Bingham \nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> * Changes since v1\n> - Ensure model string only contains ASCII characters.\n> ---\n> src/libcamera/camera_sensor.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index d2679a4b80ce0d42..78c7ceec7c449674 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -200,6 +200,8 @@ int CameraSensor::init()\n> \telse\n> \t\tmodel_ = entityName;\n>\n> +\tproperties_.set(properties::Model, utils::toAscii(model_));\n> +\n> \t/* Create and open the subdev. */\n> \tsubdev_ = std::make_unique(entity_);\n> \tint ret = subdev_->open();\n> --\n> 2.28.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 10367C3B5C\n\tfor ;\n\tMon, 28 Sep 2020 11:29:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DEE0360BD7;\n\tMon, 28 Sep 2020 13:29:31 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EC6A160364\n\tfor ;\n\tMon, 28 Sep 2020 13:29:29 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 82A8F60005;\n\tMon, 28 Sep 2020 11:29:29 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Mon, 28 Sep 2020 13:33:25 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200928113325.uj3njkqf4dq7kpgc@uno.localdomain>","References":"<20200925150743.1822226-1-niklas.soderlund@ragnatech.se>\n\t<20200925150743.1822226-4-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200925150743.1822226-4-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v5 3/7] libcamera: camera_sensor: Set\n\tsensor model property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12813,"web_url":"https://patchwork.libcamera.org/comment/12813/","msgid":"<20200928165731.GF23539@pendragon.ideasonboard.com>","date":"2020-09-28T16:57:31","subject":"Re: [libcamera-devel] [PATCH v5 3/7] libcamera: camera_sensor: Set\n\tsensor model property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Fri, Sep 25, 2020 at 05:07:39PM +0200, Niklas Söderlund wrote:\n> Set the sensor model property.\n> \n> Signed-off-by: Niklas Söderlund \n> Reviewed-by: Kieran Bingham \n\nProvided this is still applicable when 1/7 will be approved,\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> * Changes since v1\n> - Ensure model string only contains ASCII characters.\n> ---\n> src/libcamera/camera_sensor.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index d2679a4b80ce0d42..78c7ceec7c449674 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -200,6 +200,8 @@ int CameraSensor::init()\n> \telse\n> \t\tmodel_ = entityName;\n> \n> +\tproperties_.set(properties::Model, utils::toAscii(model_));\n> +\n> \t/* Create and open the subdev. */\n> \tsubdev_ = std::make_unique(entity_);\n> \tint ret = subdev_->open();","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ACF39C3B5B\n\tfor ;\n\tMon, 28 Sep 2020 16:58:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3103A60BF7;\n\tMon, 28 Sep 2020 18:58:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE0E160366\n\tfor ;\n\tMon, 28 Sep 2020 18:58:06 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 35F0D54E;\n\tMon, 28 Sep 2020 18:58:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"B8N+e6L/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601312286;\n\tbh=iYiBDvDfuwfuA/V6vsobiZIu0MhfE+0rowbXGKQvrEk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=B8N+e6L/ic5ph9G9KWPV2xmAMAnLWdGm9yUD/IqAiZLZluYMHGB9TX40IpXzJ84f1\n\tNFdULVLHYNjJpUdCnXWDdA5MOwT5NKj+JhEqNXCOxaYAx92udcY6z3adyEm3UZ8tER\n\tkQ7i32Y5gYyeP207q/EuphD0M2gem2N+TSVc0wKE=","Date":"Mon, 28 Sep 2020 19:57:31 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200928165731.GF23539@pendragon.ideasonboard.com>","References":"<20200925150743.1822226-1-niklas.soderlund@ragnatech.se>\n\t<20200925150743.1822226-4-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200925150743.1822226-4-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v5 3/7] libcamera: camera_sensor: Set\n\tsensor model property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]