[{"id":12798,"web_url":"https://patchwork.libcamera.org/comment/12798/","msgid":"<20200928102239.b5hiildkohie7hr7@uno.localdomain>","date":"2020-09-28T10:22:39","subject":"Re: [libcamera-devel] [PATCH v2 3/6] libcamera: Add IspCrop control","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi David,\n\nOn Fri, Sep 25, 2020 at 09:51:24AM +0100, David Plowman wrote:\n> The IspCrop control selects how much of the sensor's output image\n> will be scaled to form the output image. It can be used to implement\n> digital zoom.\n>\n> Signed-off-by: David Plowman \n> ---\n> src/libcamera/control_ids.yaml | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n>\n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 3560d4a..a6a73c8 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -273,4 +273,13 @@ controls:\n> order in an array of 9 floating point values.\n>\n> size: [3x3]\n> +\n> + - IspCrop:\n> + type: Rectangle\n> + description: |\n> + Sets the portion of the full sensor image, in pixels, that will be\n> + scaled up to form the whole of the final output image. This control\n\nmmm, mentioning \"the full sensor image\" makes me think this Rectangle\nis defined relatively to the pixel array active size (which is to me\nthe \"full sensor image\").\n\n> + can be used to implement digital zoom. The size of the full sensor\n> + image within which an application can crop is available from the\n> + SensorOutputSize property.\n\nWhat about\n Sets the image portion that will be scaled up to form the\n whole of the final output image. The selection rectangle is\n expressed in pixel units and defined relatively to the size\n of the frame described by the SensorOutputSize property.\n\n This control can be used to implement digital zoom.\n\n \\sa properties::SensorOutputSize\n\n?\n\nThanks\n j\n\n> ...\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 927C0C3B5C\n\tfor ;\n\tMon, 28 Sep 2020 10:18:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D64E60BD7;\n\tMon, 28 Sep 2020 12:18:46 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 104C060364\n\tfor ;\n\tMon, 28 Sep 2020 12:18:45 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 3DE6E6000D;\n\tMon, 28 Sep 2020 10:18:43 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Mon, 28 Sep 2020 12:22:39 +0200","From":"Jacopo Mondi ","To":"David Plowman ","Message-ID":"<20200928102239.b5hiildkohie7hr7@uno.localdomain>","References":"<20200925085127.17214-1-david.plowman@raspberrypi.com>\n\t<20200925085127.17214-4-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200925085127.17214-4-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v2 3/6] libcamera: Add IspCrop control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]