[{"id":12774,"web_url":"https://patchwork.libcamera.org/comment/12774/","msgid":"<20200925142936.nbpwycdwj4fjj73p@uno.localdomain>","date":"2020-09-25T14:29:36","subject":"Re: [libcamera-devel] [PATCH v3 12/22] libcamera: pipeline: rkisp1:\n\tTrack buffers for self path","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Fri, Sep 25, 2020 at 03:41:57AM +0200, Niklas Söderlund wrote:\n> In preparation of supporting both the main and self path extend\n> RkISP1FrameInfo to track buffers from the self path stream.\n>\n> Signed-off-by: Niklas Söderlund \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 13 +++++++++++--\n> 1 file changed, 11 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 28e99129498e4a0a..cd3049485746edd6 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -69,6 +69,7 @@ struct RkISP1FrameInfo {\n> \tFrameBuffer *paramBuffer;\n> \tFrameBuffer *statBuffer;\n> \tFrameBuffer *mainPathBuffer;\n> +\tFrameBuffer *selfPathBuffer;\n>\n> \tbool paramFilled;\n> \tbool paramDequeued;\n> @@ -272,6 +273,7 @@ RkISP1FrameInfo *RkISP1Frames::create(const RkISP1CameraData *data, Request *req\n> \tFrameBuffer *statBuffer = pipe_->availableStatBuffers_.front();\n>\n> \tFrameBuffer *mainPathBuffer = request->findBuffer(&data->mainPathStream_);\n> +\tFrameBuffer *selfPathBuffer = request->findBuffer(&data->selfPathStream_);\n>\n> \tpipe_->availableParamBuffers_.pop();\n> \tpipe_->availableStatBuffers_.pop();\n> @@ -282,6 +284,7 @@ RkISP1FrameInfo *RkISP1Frames::create(const RkISP1CameraData *data, Request *req\n> \tinfo->request = request;\n> \tinfo->paramBuffer = paramBuffer;\n> \tinfo->mainPathBuffer = mainPathBuffer;\n> +\tinfo->selfPathBuffer = selfPathBuffer;\n> \tinfo->statBuffer = statBuffer;\n> \tinfo->paramFilled = false;\n> \tinfo->paramDequeued = false;\n> @@ -340,7 +343,8 @@ RkISP1FrameInfo *RkISP1Frames::find(FrameBuffer *buffer)\n>\n> \t\tif (info->paramBuffer == buffer ||\n> \t\t info->statBuffer == buffer ||\n> -\t\t info->mainPathBuffer == buffer)\n> +\t\t info->mainPathBuffer == buffer ||\n> +\t\t info->selfPathBuffer == buffer)\n> \t\t\treturn info;\n> \t}\n>\n> @@ -412,7 +416,12 @@ protected:\n>\n> \t\tpipe_->param_->queueBuffer(info->paramBuffer);\n> \t\tpipe_->stat_->queueBuffer(info->statBuffer);\n> -\t\tpipe_->mainPathVideo_->queueBuffer(info->mainPathBuffer);\n> +\n> +\t\tif (info->mainPathBuffer)\n> +\t\t\tpipe_->mainPathVideo_->queueBuffer(info->mainPathBuffer);\n> +\n> +\t\tif (info->selfPathBuffer)\n> +\t\t\tpipe_->selfPathVideo_->queueBuffer(info->selfPathBuffer);\n> \t}\n>\n> private:\n> --\n> 2.28.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1D0EC3B5C\n\tfor ;\n\tFri, 25 Sep 2020 14:25:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BEF3C6302C;\n\tFri, 25 Sep 2020 16:25:45 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 69A3B62FE6\n\tfor ;\n\tFri, 25 Sep 2020 16:25:44 +0200 (CEST)","from uno.localdomain (host-87-18-63-10.retail.telecomitalia.it\n\t[87.18.63.10]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 990AEFF80B;\n\tFri, 25 Sep 2020 14:25:43 +0000 (UTC)"],"X-Originating-IP":"87.18.63.10","Date":"Fri, 25 Sep 2020 16:29:36 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200925142936.nbpwycdwj4fjj73p@uno.localdomain>","References":"<20200925014207.1455796-1-niklas.soderlund@ragnatech.se>\n\t<20200925014207.1455796-13-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200925014207.1455796-13-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v3 12/22] libcamera: pipeline: rkisp1:\n\tTrack buffers for self path","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]