[{"id":12773,"web_url":"https://patchwork.libcamera.org/comment/12773/","msgid":"<20200925142814.qy5p4sgln7o2f2my@uno.localdomain>","date":"2020-09-25T14:28:14","subject":"Re: [libcamera-devel] [PATCH v3 08/22] libcamera: pipeline: rkisp1:\n\tSet the crop rectangle","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Fri, Sep 25, 2020 at 03:41:53AM +0200, Niklas Söderlund wrote:\n> Changing resolutions back and forth can provoke the crop rectangle to go\n> out of sync, set it as part of format configuration.\n\nIs there any dependency on the kernel version ?\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Signed-off-by: Niklas Söderlund \n> Reviewed-by: Laurent Pinchart \n> ---\n> * Changes since v2\n> - Fix s/port/part/ in commit message.\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 27191b18c989aa5e..2f70bf2220fa5c84 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -629,6 +629,11 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \tif (ret < 0)\n> \t\treturn ret;\n>\n> +\tRectangle rect(0, 0, format.size);\n> +\tret = isp_->setSelection(0, V4L2_SEL_TGT_CROP, &rect);\n> +\tif (ret < 0)\n> +\t\treturn ret;\n> +\n> \tLOG(RkISP1, Debug) << \"ISP input pad configured with \" << format.toString();\n>\n> \t/* YUYV8_2X8 is required on the ISP source path pad for YUV output. */\n> --\n> 2.28.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93A78C3B5C\n\tfor ;\n\tFri, 25 Sep 2020 14:24:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6F0B66302C;\n\tFri, 25 Sep 2020 16:24:22 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B589E62FE6\n\tfor ;\n\tFri, 25 Sep 2020 16:24:21 +0200 (CEST)","from uno.localdomain (host-87-18-63-10.retail.telecomitalia.it\n\t[87.18.63.10]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 2D263C000C;\n\tFri, 25 Sep 2020 14:24:20 +0000 (UTC)"],"X-Originating-IP":"87.18.63.10","Date":"Fri, 25 Sep 2020 16:28:14 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200925142814.qy5p4sgln7o2f2my@uno.localdomain>","References":"<20200925014207.1455796-1-niklas.soderlund@ragnatech.se>\n\t<20200925014207.1455796-9-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200925014207.1455796-9-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v3 08/22] libcamera: pipeline: rkisp1:\n\tSet the crop rectangle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12783,"web_url":"https://patchwork.libcamera.org/comment/12783/","msgid":"<20200925162524.GE1757254@oden.dyn.berto.se>","date":"2020-09-25T16:25:24","subject":"Re: [libcamera-devel] [PATCH v3 08/22] libcamera: pipeline: rkisp1:\n\tSet the crop rectangle","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nOn 2020-09-25 16:28:14 +0200, Jacopo Mondi wrote:\n> Hi Niklas,\n> \n> On Fri, Sep 25, 2020 at 03:41:53AM +0200, Niklas Söderlund wrote:\n> > Changing resolutions back and forth can provoke the crop rectangle to go\n> > out of sync, set it as part of format configuration.\n> \n> Is there any dependency on the kernel version ?\n\nNot more then is mentioned in the cover-letter. But without those \npatches capture is not possible at all.\n\n> \n> Reviewed-by: Jacopo Mondi \n> \n> Thanks\n> j\n> \n> >\n> > Signed-off-by: Niklas Söderlund \n> > Reviewed-by: Laurent Pinchart \n> > ---\n> > * Changes since v2\n> > - Fix s/port/part/ in commit message.\n> > ---\n> > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +++++\n> > 1 file changed, 5 insertions(+)\n> >\n> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > index 27191b18c989aa5e..2f70bf2220fa5c84 100644\n> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > @@ -629,6 +629,11 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> > \tif (ret < 0)\n> > \t\treturn ret;\n> >\n> > +\tRectangle rect(0, 0, format.size);\n> > +\tret = isp_->setSelection(0, V4L2_SEL_TGT_CROP, &rect);\n> > +\tif (ret < 0)\n> > +\t\treturn ret;\n> > +\n> > \tLOG(RkISP1, Debug) << \"ISP input pad configured with \" << format.toString();\n> >\n> > \t/* YUYV8_2X8 is required on the ISP source path pad for YUV output. */\n> > --\n> > 2.28.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62B1AC3B5B\n\tfor ;\n\tFri, 25 Sep 2020 16:26:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D32EE6303C;\n\tFri, 25 Sep 2020 18:26:27 +0200 (CEST)","from mail-lj1-f193.google.com (mail-lj1-f193.google.com\n\t[209.85.208.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 80D9762FD8\n\tfor ;\n\tFri, 25 Sep 2020 18:26:26 +0200 (CEST)","by mail-lj1-f193.google.com with SMTP id k25so2946003ljg.9\n\tfor ;\n\tFri, 25 Sep 2020 09:26:26 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\t193sm2587584lfb.212.2020.09.25.09.25.25\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 25 Sep 2020 09:25:25 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"IAMG2KXa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=c5umF3gpCYx42uw2+iUXYPETpuqWs5aJXrGEJCj0SFI=;\n\tb=IAMG2KXavfk+2T0ldiI+Y1in9vP02PJsAmpya1IHBc2pMlFVmC9iuxDAcX0UBgSAeY\n\tuWfZG9OO7UggMuWOIuFMRHTbDNZccVCAm6Upcdx77iU6GrnwzTL0ll/ftLu/1p4aJbZZ\n\tcXLZQug/y5tJaKzY862i1I61rDrLiyJ6rRL0e/w0g2nqeYlBw3k7ikXL/4Hp04dsGlS6\n\tu3XzM07B83AtKUgKVIvULSpheiCTRX8Hk1b4JijgsAkMrtR5/9ftAIFB0UWloMva7xCL\n\tq9fGaMTHO9bxL56GMZKwx1oMJeCthDiCsWjiG3sULLUYGMPkjL0cd0E7tqSjJ0b3Vlcf\n\tX2Zw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=c5umF3gpCYx42uw2+iUXYPETpuqWs5aJXrGEJCj0SFI=;\n\tb=dH/aHz91Nohgs63teNct5FarndB7RVjFldDT/+1RDC1ootGZj9X785Pgu3Vlsv988P\n\tNNKRFRtQetfWngZeUrsClqTrgsD8PIr583YHOOdoRcasI1TwBJpyFUnjD/miNBvxdVnT\n\tEoKqbZaxqa4kQ8OkKYWWPtE+enZqvJ3uK1lyzIgUtZ69UnQuXb+ZlaRzZwlEuT+MtiMA\n\tXlA/db5df3SzJjnWUHvmTgvqbcojHoxOflV24EwLq+F08YcDqsHzzgN3T7m/v2pesDuo\n\tZIqIO6gt2CTNYHinMbjSHQm6wT92fdNa/pOqqi4QXgzt7Sq097dkGqec90CbTzpnkS5I\n\tPZTg==","X-Gm-Message-State":"AOAM530HTQHv8dauas6q7sf5EcKXNNvTOfpiB1TyVsByDm1WOlkQXxdJ\n\tg/NnVjDYP6LfuzC7/0WTfrPeLg==","X-Google-Smtp-Source":"ABdhPJzuG/QLRNRM0g2U9+GRv0ZxTWOR6oZGPbzFc5yN5c/Kgo7Z5XuqxUV50Lppf/vdrpCYdzlrog==","X-Received":"by 2002:a2e:3507:: with SMTP id z7mr1489716ljz.317.1601051126053;\n\tFri, 25 Sep 2020 09:25:26 -0700 (PDT)","Date":"Fri, 25 Sep 2020 18:25:24 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200925162524.GE1757254@oden.dyn.berto.se>","References":"<20200925014207.1455796-1-niklas.soderlund@ragnatech.se>\n\t<20200925014207.1455796-9-niklas.soderlund@ragnatech.se>\n\t<20200925142814.qy5p4sgln7o2f2my@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200925142814.qy5p4sgln7o2f2my@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v3 08/22] libcamera: pipeline: rkisp1:\n\tSet the crop rectangle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]