[{"id":12772,"web_url":"https://patchwork.libcamera.org/comment/12772/","msgid":"<20200925142701.kv5ngdjbzlakkyuq@uno.localdomain>","date":"2020-09-25T14:27:01","subject":"Re: [libcamera-devel] [PATCH v3 07/22] libcamera: pipeline: rkisp1:\n\tExport stream formats to applications","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Fri, Sep 25, 2020 at 03:41:52AM +0200, Niklas Söderlund wrote:\n> The information about stream format is available but not exported to\n> applications, fix this.\n>\n> Signed-off-by: Niklas Söderlund \n> Reviewed-by: Laurent Pinchart \n> ---\n> * Changes since v1\n> - Fix s/applicaitons/applications/ in subject\n> - Cap the max resolution reported to the sensor resolution.\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 +++++++-\n> 1 file changed, 7 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index e52aadcfdb9870a3..27191b18c989aa5e 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -582,7 +582,13 @@ CameraConfiguration *PipelineHandlerRkISP1::generateConfiguration(Camera *camera\n> \tif (roles.empty())\n> \t\treturn config;\n>\n> -\tStreamConfiguration cfg{};\n> +\tstd::map> streamFormats;\n> +\tfor (const PixelFormat &format : RKISP1_RSZ_MP_FORMATS)\n\nDo the supported formats differ between main and self path ?\nProbably with the introduction of different roles support, I'll find\nit out later ?\n\nFor now\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n\n> +\t\tstreamFormats[format] =\n> +\t\t\t{ { RKISP1_RSZ_MP_SRC_MIN, data->sensor_->resolution() } };\n> +\n> +\tStreamFormats formats(streamFormats);\n> +\tStreamConfiguration cfg(formats);\n> \tcfg.pixelFormat = formats::NV12;\n> \tcfg.size = data->sensor_->resolution();\n>\n> --\n> 2.28.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 87AC4C3B5C\n\tfor ;\n\tFri, 25 Sep 2020 14:23:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12CD163021;\n\tFri, 25 Sep 2020 16:23:11 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 165F062FD8\n\tfor ;\n\tFri, 25 Sep 2020 16:23:09 +0200 (CEST)","from uno.localdomain (host-87-18-63-10.retail.telecomitalia.it\n\t[87.18.63.10]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 577C91C0015;\n\tFri, 25 Sep 2020 14:23:08 +0000 (UTC)"],"X-Originating-IP":"87.18.63.10","Date":"Fri, 25 Sep 2020 16:27:01 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200925142701.kv5ngdjbzlakkyuq@uno.localdomain>","References":"<20200925014207.1455796-1-niklas.soderlund@ragnatech.se>\n\t<20200925014207.1455796-8-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200925014207.1455796-8-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v3 07/22] libcamera: pipeline: rkisp1:\n\tExport stream formats to applications","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12782,"web_url":"https://patchwork.libcamera.org/comment/12782/","msgid":"<20200925162000.GD1757254@oden.dyn.berto.se>","date":"2020-09-25T16:20:00","subject":"Re: [libcamera-devel] [PATCH v3 07/22] libcamera: pipeline: rkisp1:\n\tExport stream formats to applications","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nOn 2020-09-25 16:27:01 +0200, Jacopo Mondi wrote:\n> Hi Niklas,\n> \n> On Fri, Sep 25, 2020 at 03:41:52AM +0200, Niklas Söderlund wrote:\n> > The information about stream format is available but not exported to\n> > applications, fix this.\n> >\n> > Signed-off-by: Niklas Söderlund \n> > Reviewed-by: Laurent Pinchart \n> > ---\n> > * Changes since v1\n> > - Fix s/applicaitons/applications/ in subject\n> > - Cap the max resolution reported to the sensor resolution.\n> > ---\n> > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 +++++++-\n> > 1 file changed, 7 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > index e52aadcfdb9870a3..27191b18c989aa5e 100644\n> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > @@ -582,7 +582,13 @@ CameraConfiguration *PipelineHandlerRkISP1::generateConfiguration(Camera *camera\n> > \tif (roles.empty())\n> > \t\treturn config;\n> >\n> > -\tStreamConfiguration cfg{};\n> > +\tstd::map> streamFormats;\n> > +\tfor (const PixelFormat &format : RKISP1_RSZ_MP_FORMATS)\n> \n> Do the supported formats differ between main and self path ?\n> Probably with the introduction of different roles support, I'll find\n> it out later ?\n\nYes main supports RAW while self supports RGB formats. In previos \nversions I enabled RGB for self but I have now tested it more and al tho \nit works the captured frames does not look 100% so I have taken it out \nof the series.\n\n> \n> For now\n> Reviewed-by: Jacopo Mondi \n> \n> Thanks\n> j\n> \n> \n> > +\t\tstreamFormats[format] =\n> > +\t\t\t{ { RKISP1_RSZ_MP_SRC_MIN, data->sensor_->resolution() } };\n> > +\n> > +\tStreamFormats formats(streamFormats);\n> > +\tStreamConfiguration cfg(formats);\n> > \tcfg.pixelFormat = formats::NV12;\n> > \tcfg.size = data->sensor_->resolution();\n> >\n> > --\n> > 2.28.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3598FC3B5C\n\tfor ;\n\tFri, 25 Sep 2020 16:21:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EF4656303C;\n\tFri, 25 Sep 2020 18:21:02 +0200 (CEST)","from mail-lf1-f65.google.com (mail-lf1-f65.google.com\n\t[209.85.167.65])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E0D8562FD8\n\tfor ;\n\tFri, 25 Sep 2020 18:21:01 +0200 (CEST)","by mail-lf1-f65.google.com with SMTP id b12so3424518lfp.9\n\tfor ;\n\tFri, 25 Sep 2020 09:21:01 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tc20sm2624776lff.291.2020.09.25.09.20.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 25 Sep 2020 09:20:00 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"MNTaTJ05\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=XhmD5cI+E6sc5OdEFOM7SCRgFEyV2VWv7HiiEoQE/OE=;\n\tb=MNTaTJ05OzhwAwH9joX6Nbhw5Oa0fqE3/4wR2fzAAdgVXpMl+rruGG0sRLgbeIaxWi\n\tyoLZCepEY8eMvT8J7NEZ+yj6t1AeTYCXF1Ymr5nxi2HwQShJC1ftVKclR6q5kCYdNXA9\n\ttyyg46XgPj+N3tux3keA/62q4lRgE90dKJHCmXqYsRE/F4sbE+HtDqszKBA/5etYfdWy\n\twHLC/utKApEW8JulkImHt4Lup8zerWmiZJP3fmyQJUszlyvlXx+/8h4q2g1Z6+w3skDb\n\tZ79RKj3DxpBQdKu84LVEp8F3WzWhoS5UGR52/F82jprFxPg7Xz41rm13uy02Zvkfr12U\n\tE2+w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=XhmD5cI+E6sc5OdEFOM7SCRgFEyV2VWv7HiiEoQE/OE=;\n\tb=QDxFz9mt2tX2r9wXM8WqrdRs+XoUKMNW0PZU8BYFQ0x7ayWvELTHveSqsfxXJRShR4\n\t7iFfIK9XTzxMShwuOO0U8sVpP4GaoZiIcdWJqrbl8kIsC7mFLMqWMsIJ2Pi7FVBbCu6+\n\t1d7KdXM1/UL+X2iXvxHBanI80tWg4aJzaFA6gieJ5P3Ut7CmaGBnN0GLC43WqASyXAaN\n\tGNXjtBVY2Luo97hQ15AESZmdY1GbCg+YIKnHcNxhkaFRH5P/QbzT7tXYQ4CSJ3RZ2Zlx\n\taAAZ7CTSxhUciFSsROrijkIA1GEnJF9KSREPqmxhdklsR7udAr8kJZWniMcV4CIu7hzb\n\t9vkw==","X-Gm-Message-State":"AOAM5318Z1iBecQL1u3x2MgfiD5on6uP9V/B3eJBqgKp63V4TaPbc64y\n\td4BfAT7NE6nTxwNRAOgo47DNuQ==","X-Google-Smtp-Source":"ABdhPJwOawHxz2PIC9Tv650UH45YGa1RW5at8uj71TbMHObnFd6mPUm+dvS8lnYZaOIky3HnxzwdnA==","X-Received":"by 2002:a19:7e0d:: with SMTP id\n\tz13mr1520846lfc.455.1601050801430; \n\tFri, 25 Sep 2020 09:20:01 -0700 (PDT)","Date":"Fri, 25 Sep 2020 18:20:00 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200925162000.GD1757254@oden.dyn.berto.se>","References":"<20200925014207.1455796-1-niklas.soderlund@ragnatech.se>\n\t<20200925014207.1455796-8-niklas.soderlund@ragnatech.se>\n\t<20200925142701.kv5ngdjbzlakkyuq@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200925142701.kv5ngdjbzlakkyuq@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v3 07/22] libcamera: pipeline: rkisp1:\n\tExport stream formats to applications","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]