[{"id":12761,"web_url":"https://patchwork.libcamera.org/comment/12761/","msgid":"<20200925085415.dy2mvt5qbyd72q34@uno.localdomain>","date":"2020-09-25T08:54:15","subject":"Re: [libcamera-devel] [PATCH v3 02/22] libcamera: pipeline: rkisp1:\n\tRemove redundant check of buffer in Request","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Fri, Sep 25, 2020 at 03:41:47AM +0200, Niklas Söderlund wrote:\n> There is no need to check if Request contains a buffer belonging the\n> RkISP1 Camera as this is already done in Camera::queueRequest(), remove\n> the redundant check.\n>\n\nReviewed-by: Jacopo Mondi \n\nThanks\n\n> Reported-by: Laurent Pinchart \n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 -----\n> 1 file changed, 5 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 009d190d3ec828f0..77a48106ec68cb7b 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -243,11 +243,6 @@ RkISP1FrameInfo *RkISP1Frames::create(unsigned int frame, Request *request, Stre\n> \tFrameBuffer *statBuffer = pipe_->availableStatBuffers_.front();\n>\n> \tFrameBuffer *videoBuffer = request->findBuffer(stream);\n> -\tif (!videoBuffer) {\n> -\t\tLOG(RkISP1, Error)\n> -\t\t\t<< \"Attempt to queue request with invalid stream\";\n> -\t\treturn nullptr;\n> -\t}\n>\n> \tpipe_->availableParamBuffers_.pop();\n> \tpipe_->availableStatBuffers_.pop();\n> --\n> 2.28.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8FDBC3B5C\n\tfor ;\n\tFri, 25 Sep 2020 08:50:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2B25963019;\n\tFri, 25 Sep 2020 10:50:26 +0200 (CEST)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E45EC60576\n\tfor ;\n\tFri, 25 Sep 2020 10:50:22 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 33F7910000C;\n\tFri, 25 Sep 2020 08:50:21 +0000 (UTC)"],"Date":"Fri, 25 Sep 2020 10:54:15 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200925085415.dy2mvt5qbyd72q34@uno.localdomain>","References":"<20200925014207.1455796-1-niklas.soderlund@ragnatech.se>\n\t<20200925014207.1455796-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200925014207.1455796-3-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v3 02/22] libcamera: pipeline: rkisp1:\n\tRemove redundant check of buffer in Request","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]