{"id":9800,"url":"https://patchwork.libcamera.org/api/patches/9800/?format=json","web_url":"https://patchwork.libcamera.org/patch/9800/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200925014207.1455796-3-niklas.soderlund@ragnatech.se>","date":"2020-09-25T01:41:47","name":"[libcamera-devel,v3,02/22] libcamera: pipeline: rkisp1: Remove redundant check of buffer in Request","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4187905b6883c079f749620f991342ddb41d26ac","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9800/mbox/","series":[{"id":1325,"url":"https://patchwork.libcamera.org/api/series/1325/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1325","date":"2020-09-25T01:41:45","name":"libcamera: pipeline: rkisp1: Extend to support two streams","version":3,"mbox":"https://patchwork.libcamera.org/series/1325/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9800/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9800/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A364C3B5C\n\tfor ;\n\tFri, 25 Sep 2020 01:42:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D69A86301F;\n\tFri, 25 Sep 2020 03:42:44 +0200 (CEST)","from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FB3962FD8\n\tfor ;\n\tFri, 25 Sep 2020 03:42:43 +0200 (CEST)","from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 669add1a-fed0-11ea-92dc-005056917a89;\n\tFri, 25 Sep 2020 03:42:41 +0200 (CEST)"],"X-Halon-ID":"669add1a-fed0-11ea-92dc-005056917a89","Authorized-sender":"niklas.soderlund@fsdn.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 25 Sep 2020 03:41:47 +0200","Message-Id":"<20200925014207.1455796-3-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20200925014207.1455796-1-niklas.soderlund@ragnatech.se>","References":"<20200925014207.1455796-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 02/22] libcamera: pipeline: rkisp1:\n\tRemove redundant check of buffer in Request","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"There is no need to check if Request contains a buffer belonging the\nRkISP1 Camera as this is already done in Camera::queueRequest(), remove\nthe redundant check.\n\nReported-by: Laurent Pinchart \nSigned-off-by: Niklas Söderlund \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 -----\n 1 file changed, 5 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 009d190d3ec828f0..77a48106ec68cb7b 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -243,11 +243,6 @@ RkISP1FrameInfo *RkISP1Frames::create(unsigned int frame, Request *request, Stre\n \tFrameBuffer *statBuffer = pipe_->availableStatBuffers_.front();\n \n \tFrameBuffer *videoBuffer = request->findBuffer(stream);\n-\tif (!videoBuffer) {\n-\t\tLOG(RkISP1, Error)\n-\t\t\t<< \"Attempt to queue request with invalid stream\";\n-\t\treturn nullptr;\n-\t}\n \n \tpipe_->availableParamBuffers_.pop();\n \tpipe_->availableStatBuffers_.pop();\n","prefixes":["libcamera-devel","v3","02/22"]}