[{"id":12841,"web_url":"https://patchwork.libcamera.org/comment/12841/","msgid":"<20200928232130.GB14614@pendragon.ideasonboard.com>","date":"2020-09-28T23:21:30","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: ipu3: Remove dead code\n\tcheck","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Sep 24, 2020 at 04:51:42PM +0200, Jacopo Mondi wrote:\n> Since the re-implementation of the IPU3 pipeline handler\n> configuration procedure, the main output is always assigned in\n> case any YUV stream is requested.\n> \n> Remove a dead code block that checks for the main output to be\n> valid.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 6 ------\n> 1 file changed, 6 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 9cea6c7e9611..477f85a45755 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -501,12 +501,6 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> \t * the configuration of the active one for that purpose (there should\n> \t * be at least one active stream in the configuration request).\n> \t */\n> -\tif (!mainCfg) {\n> -\t\tret = imgu->configureOutput(*vfCfg, &outputFormat);\n> -\t\tif (ret)\n> -\t\t\treturn ret;\n> -\t}\n> -\n> \tif (!vfCfg) {\n> \t\tret = imgu->configureViewfinder(*mainCfg, &outputFormat);\n> \t\tif (ret)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9DEACC3B5C\n\tfor ;\n\tMon, 28 Sep 2020 23:22:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7055B60BF7;\n\tTue, 29 Sep 2020 01:22:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3668360394\n\tfor ;\n\tTue, 29 Sep 2020 01:22:06 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BF4BBA58;\n\tTue, 29 Sep 2020 01:22:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"asKM9wni\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601335324;\n\tbh=0kBRWv+Q9phlcAi90OKq+1hLC9CKUgkK4AU/eKtSrlU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=asKM9wniGWoFPGjmaFRpN8w0YYYhDoQBmEjzrHtGSR4LLkus1DTD/r1Cf6fiVL59f\n\toFvLsNFnJnRnv2OIVH9lhNq5tu1VzVDAPvz5x43knpQLgxoeGs9YryMACEUyi4mQ8r\n\t8abmqD5bRUZaLW1mNYNfJ1scaf8F2QLeqaHbMWzE=","Date":"Tue, 29 Sep 2020 02:21:30 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200928232130.GB14614@pendragon.ideasonboard.com>","References":"<20200924145143.117733-1-jacopo@jmondi.org>\n\t<20200924145143.117733-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200924145143.117733-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: ipu3: Remove dead code\n\tcheck","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12866,"web_url":"https://patchwork.libcamera.org/comment/12866/","msgid":"<20200929053527.GF1052036@oden.dyn.berto.se>","date":"2020-09-29T05:35:27","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: ipu3: Remove dead code\n\tcheck","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2020-09-24 16:51:42 +0200, Jacopo Mondi wrote:\n> Since the re-implementation of the IPU3 pipeline handler\n> configuration procedure, the main output is always assigned in\n> case any YUV stream is requested.\n> \n> Remove a dead code block that checks for the main output to be\n> valid.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 6 ------\n> 1 file changed, 6 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 9cea6c7e9611..477f85a45755 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -501,12 +501,6 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> \t * the configuration of the active one for that purpose (there should\n> \t * be at least one active stream in the configuration request).\n> \t */\n> -\tif (!mainCfg) {\n> -\t\tret = imgu->configureOutput(*vfCfg, &outputFormat);\n> -\t\tif (ret)\n> -\t\t\treturn ret;\n> -\t}\n> -\n> \tif (!vfCfg) {\n> \t\tret = imgu->configureViewfinder(*mainCfg, &outputFormat);\n> \t\tif (ret)\n> -- \n> 2.28.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C4EEC3B5B\n\tfor ;\n\tTue, 29 Sep 2020 05:35:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D256A620BC;\n\tTue, 29 Sep 2020 07:35:29 +0200 (CEST)","from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A0506035E\n\tfor ;\n\tTue, 29 Sep 2020 07:35:29 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id v23so2955448ljd.1\n\tfor ;\n\tMon, 28 Sep 2020 22:35:29 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tq24sm3111678lfo.149.2020.09.28.22.35.27\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 28 Sep 2020 22:35:28 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"LC97bpGX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=W6w8CWRc/q+h8mB7liXl5d8HE+Rw6LvMreJttsZ7onY=;\n\tb=LC97bpGXWuI27GDn4B3/PeyzCm2BeZlfZOu5rTReh+j8uvW9/e2L7PuwRldQNMtN5o\n\tAKLugmTLjHEhz1cXeTvkVIzrzpR8lBo3Z8RCXYu0NqTIBHa6yQMOy7u/jy+V+YdAoiRX\n\t2AEeeRcPh8w1AyCkcJWxZZP8u7nulkhSaRXLCV32k10qX7470d9/i2FYzu6ZPkC+LG1B\n\tJFndCDaxyUZv90fdcRDzTTh+UoeuYQ3qXxiu3/jqI6CzPBWZDXJgTE4GaHQGYfzPGQ37\n\twH/QBrAEH4sejS75dcnJWPPE+d8MCr55wfqjVUMss9LvQ0Q9ud/B2TdwS7EOdv98JyS2\n\t2Rjw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=W6w8CWRc/q+h8mB7liXl5d8HE+Rw6LvMreJttsZ7onY=;\n\tb=iZEO38hPPLL8GCVXGGV6S4tb02+e7lqFnE0h5WtA4yZ8BFv6SoJ212JJyU6dtDdQNf\n\tXiulDFEWIDlBFttAWZO3xw9d983SWa5Vve92C9XVSVM2r6forcDFxHRRkP6KCin1hZft\n\tYvgDUjp4LWvSG5MiYLQWRQ+uged2yUg74UT8cAYCN5Obn6BwwX3pn+Sg+CyHdHWGry0l\n\thU2CYX0xzV17FnHqHDsfckgQTymqDNMEpU4ACbRVBPCrzlqitqJwD03otc47+Tsmp/Vg\n\trEkPmsKpYhyo6BZE2keg8LtIqc4WTyd+v505qpLBjeNCGMHDrGhLErf1Rzy2fB9s2TzK\n\tGW1w==","X-Gm-Message-State":"AOAM5305dFcK7opHD1KwzmC3vDLvuDlrIb7voS59HjhftJ8q0c2W8Lcw\n\txGBv1XOcPGauRK1IfiyuyhG/P/8/GwTacQ==","X-Google-Smtp-Source":"ABdhPJyF9KlRPWdIraPibpioyroCtJ68SJ5B5ou0VCXZbTc7jIFn5zgAycwJzemNf3f8r5lbemVNQQ==","X-Received":"by 2002:a05:651c:209:: with SMTP id\n\ty9mr573820ljn.398.1601357728484; \n\tMon, 28 Sep 2020 22:35:28 -0700 (PDT)","Date":"Tue, 29 Sep 2020 07:35:27 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200929053527.GF1052036@oden.dyn.berto.se>","References":"<20200924145143.117733-1-jacopo@jmondi.org>\n\t<20200924145143.117733-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200924145143.117733-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: ipu3: Remove dead code\n\tcheck","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]