[{"id":1434,"web_url":"https://patchwork.libcamera.org/comment/1434/","msgid":"<20190417110316.GG4993@pendragon.ideasonboard.com>","date":"2019-04-17T11:03:16","subject":"Re: [libcamera-devel] [RFC 10/11] libcamera: pipeline_handler: Add\n\tfunctions to lock a whole pipeline","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Sun, Apr 14, 2019 at 03:35:05AM +0200, Niklas Söderlund wrote:\n> Add lock() and unlock() which backed by the MediaDevice implementation\n> can will lock all media devices claimed by a pipeline handler instance.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/include/pipeline_handler.h | 3 +++\n> src/libcamera/pipeline_handler.cpp | 18 ++++++++++++++++++\n> 2 files changed, 21 insertions(+)\n> \n> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> index d995a7e56d90f706..0e79b05035cc2abb 100644\n> --- a/src/libcamera/include/pipeline_handler.h\n> +++ b/src/libcamera/include/pipeline_handler.h\n> @@ -56,6 +56,9 @@ public:\n> \tstd::shared_ptr tryAcquire(DeviceEnumerator *enumerator,\n> \t\t\t\t\t\tconst DeviceMatch &dm);\n> \n> +\tbool lock();\n> +\tvoid unlock();\n> +\n> \tvirtual CameraConfiguration\n> \tstreamConfiguration(Camera *camera, const std::vector &usages) = 0;\n> \tvirtual int configureStreams(Camera *camera, const CameraConfiguration &config) = 0;\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 7f4035c008f95f91..317b680214d91071 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -170,6 +170,24 @@ out:\n> \treturn media;\n> }\n> \n> +bool PipelineHandler::lock()\n\nDocumentation too please :-)\n\n> +{\n> +\tfor (std::shared_ptr media : mediaDevices_) {\n> +\t\tif (!media->lock()) {\n> +\t\t\tunlock();\n> +\t\t\treturn false;\n> +\t\t}\n> +\t}\n> +\n> +\treturn true;\n> +}\n> +\n> +void PipelineHandler::unlock()\n> +{\n> +\tfor (std::shared_ptr media : mediaDevices_)\n> +\t\tmedia->unlock();\n> +}\n> +\n> /**\n> * \\fn PipelineHandler::streamConfiguration()\n> * \\brief Retrieve a group of stream configurations for a specified camera","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C6C360DBE\n\tfor ;\n\tWed, 17 Apr 2019 13:03:25 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 04530312;\n\tWed, 17 Apr 2019 13:03:24 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1555499005;\n\tbh=va7GpYgiPQq75jmhHO6Lycm+OVKX364T+soMRut1AtI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=L1sgKOylzsEctDzOmnY6mwwLAVUP6SKad0iZZrTAiwHFNlJGXrXxHlYn62/bJsYM9\n\t2vob6ySg3MYQogZIfyjQTg4iexSe0fqpfcyR4TogAxYj5mbqlESXuFaisVuY/1mMbC\n\tPUoFGaregMIL0osKM72+haJve+v5GLW0WUcBFju0=","Date":"Wed, 17 Apr 2019 14:03:16 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190417110316.GG4993@pendragon.ideasonboard.com>","References":"<20190414013506.10515-1-niklas.soderlund@ragnatech.se>\n\t<20190414013506.10515-11-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190414013506.10515-11-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [RFC 10/11] libcamera: pipeline_handler: Add\n\tfunctions to lock a whole pipeline","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 17 Apr 2019 11:03:25 -0000"}}]