[{"id":12723,"web_url":"https://patchwork.libcamera.org/comment/12723/","msgid":"<57bf9aae-119c-0b31-661a-bb4f7bd9ec6a@uajain.com>","date":"2020-09-24T10:53:30","subject":"Re: [libcamera-devel] [PATCH] src: android: exif: Set the class\n\tbyte ordering","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn 9/24/20 3:20 PM, Kieran Bingham wrote:\n> The exif object sets the byte ordering on construction, and then\n> during later calls re-states the byte ordering when setting values.\n>\n> It could be argued that this ordering should already be known to the exif\n> library and is redudant, but even so we must provide it.\n>\n> Ensure we are consistent in always using the same byte ordering by setting\n> a private class member to re-use a single value.\n>\n> Signed-off-by: Kieran Bingham \n> ---\n>\n> This patch itself feels like it might be a bit redundant, but I saw the\n> repetition, and whilst we're not likely to change the byte order, I\n> thought it might make sense to ensure it's always set from the same\n> state variable.\n>\n> If this is helpful we can add it, but if this is overkill I don't mind\n> dropping it. It's just an idea.\nIt is indeed helpful and the idea has crossed my mind in the past but \nyou got to it first. :)\n\nSo, fine by me,\n\nReviewed-by: Umang Jain \n>\n> src/android/jpeg/exif.cpp | 11 ++++++-----\n> src/android/jpeg/exif.h | 1 +\n> 2 files changed, 7 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp\n> index 1ced55343ee9..f29a7c71d1ec 100644\n> --- a/src/android/jpeg/exif.cpp\n> +++ b/src/android/jpeg/exif.cpp\n> @@ -25,7 +25,8 @@ LOG_DEFINE_CATEGORY(EXIF)\n> * data can be obtained using the data() method.\n> */\n> Exif::Exif()\n> -\t: valid_(false), data_(nullptr), exifData_(0), size_(0)\n> +\t: valid_(false), data_(nullptr), order_(EXIF_BYTE_ORDER_INTEL),\n> +\t exifData_(0), size_(0)\n> {\n> \t/* Create an ExifMem allocator to construct entries. */\n> \tmem_ = exif_mem_new_default();\n> @@ -49,7 +50,7 @@ Exif::Exif()\n> \t * Big-Endian: EXIF_BYTE_ORDER_MOTOROLA\n> \t * Little Endian: EXIF_BYTE_ORDER_INTEL\n> \t */\n> -\texif_data_set_byte_order(data_, EXIF_BYTE_ORDER_INTEL);\n> +\texif_data_set_byte_order(data_, order_);\n> \n> \t/* Create the mandatory EXIF fields with default data. */\n> \texif_data_fix(data_);\n> @@ -131,7 +132,7 @@ void Exif::setShort(ExifIfd ifd, ExifTag tag, uint16_t item)\n> \tif (!entry)\n> \t\treturn;\n> \n> -\texif_set_short(entry->data, EXIF_BYTE_ORDER_INTEL, item);\n> +\texif_set_short(entry->data, order_, item);\n> \texif_entry_unref(entry);\n> }\n> \n> @@ -141,7 +142,7 @@ void Exif::setLong(ExifIfd ifd, ExifTag tag, uint32_t item)\n> \tif (!entry)\n> \t\treturn;\n> \n> -\texif_set_long(entry->data, EXIF_BYTE_ORDER_INTEL, item);\n> +\texif_set_long(entry->data, order_, item);\n> \texif_entry_unref(entry);\n> }\n> \n> @@ -151,7 +152,7 @@ void Exif::setRational(ExifIfd ifd, ExifTag tag, ExifRational item)\n> \tif (!entry)\n> \t\treturn;\n> \n> -\texif_set_rational(entry->data, EXIF_BYTE_ORDER_INTEL, item);\n> +\texif_set_rational(entry->data, order_, item);\n> \texif_entry_unref(entry);\n> }\n> \n> diff --git a/src/android/jpeg/exif.h b/src/android/jpeg/exif.h\n> index 622de4cfd593..6e8ce04a2e67 100644\n> --- a/src/android/jpeg/exif.h\n> +++ b/src/android/jpeg/exif.h\n> @@ -46,6 +46,7 @@ private:\n> \n> \tExifData *data_;\n> \tExifMem *mem_;\n> +\tExifByteOrder order_;\n> \n> \tunsigned char *exifData_;\n> \tunsigned int size_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1BB86C3B5B\n\tfor ;\n\tThu, 24 Sep 2020 10:53:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92F8062FDE;\n\tThu, 24 Sep 2020 12:53:35 +0200 (CEST)","from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F99F60363\n\tfor ;\n\tThu, 24 Sep 2020 12:53:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"GF7fSuvH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1600944813; bh=aO55D8ljmmNejqfGdyoPOb6xmCLdgJ4qZRbcVvZJFko=;\n\th=Subject:To:References:From:In-Reply-To;\n\tb=GF7fSuvHCUVoheJlHEFBhNlq7vwvIbIyLpWcjkhsKq1DO2DdxYHRB1Bkzge/H4kiA\n\tYKDDzw5ehTN+scIfge2+0UDUF2mySp5MypHEBjcvYve9kB00G0oxeAO5Oy4el1ZV0T\n\tyxu2qH9LU5et0qjEIkhwD3Nq+GkK3VfWk5U+RCGWcQ1mB2uBCqVoLSRGTDxn+En5pC\n\thTackurV2ljgke7wty5uNYQ15LrxM0gkMGIp8UA9fk4qy43j2hPkEM+7tLmgZVH+4i\n\tTNn+tTJu3jSTEvXGO1GSqRpxvkb0xWbpiTBdqeix6Gq4ZmeDRLdFerjOBvZa3gq8FV\n\tW+93andkGbr2g==","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20200924095008.338920-1-kieran.bingham@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<57bf9aae-119c-0b31-661a-bb4f7bd9ec6a@uajain.com>","Date":"Thu, 24 Sep 2020 16:23:30 +0530","Mime-Version":"1.0","In-Reply-To":"<20200924095008.338920-1-kieran.bingham@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] src: android: exif: Set the class\n\tbyte ordering","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12931,"web_url":"https://patchwork.libcamera.org/comment/12931/","msgid":"<1c64d069-8594-9202-f578-070e89e3be7d@uajain.com>","date":"2020-10-02T05:03:37","subject":"Re: [libcamera-devel] [PATCH] src: android: exif: Set the class\n\tbyte ordering","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi,\n\nCan we get additional R-b tags to merge these trivial changes?\nThanks.\n\nOn 9/24/20 3:20 PM, Kieran Bingham wrote:\n> The exif object sets the byte ordering on construction, and then\n> during later calls re-states the byte ordering when setting values.\n>\n> It could be argued that this ordering should already be known to the exif\n> library and is redudant, but even so we must provide it.\n>\n> Ensure we are consistent in always using the same byte ordering by setting\n> a private class member to re-use a single value.\n>\n> Signed-off-by: Kieran Bingham \n> ---\n>\n> This patch itself feels like it might be a bit redundant, but I saw the\n> repetition, and whilst we're not likely to change the byte order, I\n> thought it might make sense to ensure it's always set from the same\n> state variable.\n>\n> If this is helpful we can add it, but if this is overkill I don't mind\n> dropping it. It's just an idea.\n>\n> src/android/jpeg/exif.cpp | 11 ++++++-----\n> src/android/jpeg/exif.h | 1 +\n> 2 files changed, 7 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp\n> index 1ced55343ee9..f29a7c71d1ec 100644\n> --- a/src/android/jpeg/exif.cpp\n> +++ b/src/android/jpeg/exif.cpp\n> @@ -25,7 +25,8 @@ LOG_DEFINE_CATEGORY(EXIF)\n> * data can be obtained using the data() method.\n> */\n> Exif::Exif()\n> -\t: valid_(false), data_(nullptr), exifData_(0), size_(0)\n> +\t: valid_(false), data_(nullptr), order_(EXIF_BYTE_ORDER_INTEL),\n> +\t exifData_(0), size_(0)\n> {\n> \t/* Create an ExifMem allocator to construct entries. */\n> \tmem_ = exif_mem_new_default();\n> @@ -49,7 +50,7 @@ Exif::Exif()\n> \t * Big-Endian: EXIF_BYTE_ORDER_MOTOROLA\n> \t * Little Endian: EXIF_BYTE_ORDER_INTEL\n> \t */\n> -\texif_data_set_byte_order(data_, EXIF_BYTE_ORDER_INTEL);\n> +\texif_data_set_byte_order(data_, order_);\n> \n> \t/* Create the mandatory EXIF fields with default data. */\n> \texif_data_fix(data_);\n> @@ -131,7 +132,7 @@ void Exif::setShort(ExifIfd ifd, ExifTag tag, uint16_t item)\n> \tif (!entry)\n> \t\treturn;\n> \n> -\texif_set_short(entry->data, EXIF_BYTE_ORDER_INTEL, item);\n> +\texif_set_short(entry->data, order_, item);\n> \texif_entry_unref(entry);\n> }\n> \n> @@ -141,7 +142,7 @@ void Exif::setLong(ExifIfd ifd, ExifTag tag, uint32_t item)\n> \tif (!entry)\n> \t\treturn;\n> \n> -\texif_set_long(entry->data, EXIF_BYTE_ORDER_INTEL, item);\n> +\texif_set_long(entry->data, order_, item);\n> \texif_entry_unref(entry);\n> }\n> \n> @@ -151,7 +152,7 @@ void Exif::setRational(ExifIfd ifd, ExifTag tag, ExifRational item)\n> \tif (!entry)\n> \t\treturn;\n> \n> -\texif_set_rational(entry->data, EXIF_BYTE_ORDER_INTEL, item);\n> +\texif_set_rational(entry->data, order_, item);\n> \texif_entry_unref(entry);\n> }\n> \n> diff --git a/src/android/jpeg/exif.h b/src/android/jpeg/exif.h\n> index 622de4cfd593..6e8ce04a2e67 100644\n> --- a/src/android/jpeg/exif.h\n> +++ b/src/android/jpeg/exif.h\n> @@ -46,6 +46,7 @@ private:\n> \n> \tExifData *data_;\n> \tExifMem *mem_;\n> +\tExifByteOrder order_;\n> \n> \tunsigned char *exifData_;\n> \tunsigned int size_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0D9CDC3B5B\n\tfor ;\n\tFri, 2 Oct 2020 05:03:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7448260BCD;\n\tFri, 2 Oct 2020 07:03:43 +0200 (CEST)","from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD44060A00\n\tfor ;\n\tFri, 2 Oct 2020 07:03:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"EuI+R0tq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1601615021; bh=v5dnPJAdx4Vt9jyW5oC4omE9DZQyNI1v/104qYyey0c=;\n\th=Subject:To:References:From:In-Reply-To;\n\tb=EuI+R0tqEBPRzRxZoUm1ZpBbSbIJypCFejK7zu2CMsgJkbZXkF0IJt043Tz4Fs1/3\n\t6WvmDVdP9ZkwsuANXFFEnXXgY6h5/U7kjDcRYOhFPsBFo33O0Ink0IPTVA/6Igr4SF\n\tDxVaGnOzCzJ5WKlzTUwBtS35MsyEEmGF5z8vBHY1cNu+Ov8m32bPjsK/GYQQQA0Erl\n\tTEfpk5JuTOLf5lh55aSXYoFiAARgxRF7yx7z0MbwTj8lnsszTZSGPlGognJZsQ/u/r\n\tLSNJj4PR2nwy1FICHDm3DWQgfFEySMhdOMGvo6xMTPIoJHDxKtLwkYNp1XnZV4LBGD\n\tH93Vt7708BizA==","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20200924095008.338920-1-kieran.bingham@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<1c64d069-8594-9202-f578-070e89e3be7d@uajain.com>","Date":"Fri, 2 Oct 2020 10:33:37 +0530","Mime-Version":"1.0","In-Reply-To":"<20200924095008.338920-1-kieran.bingham@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] src: android: exif: Set the class\n\tbyte ordering","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12933,"web_url":"https://patchwork.libcamera.org/comment/12933/","msgid":"<41a3ffe4-bc4d-b6a7-9401-355d0b3f7058@ideasonboard.com>","date":"2020-10-02T09:18:12","subject":"Re: [libcamera-devel] [PATCH] src: android: exif: Set the class\n\tbyte ordering","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Umang,\n\nOn 02/10/2020 06:03, Umang Jain wrote:\n> Hi,\n> \n> Can we get additional R-b tags to merge these trivial changes?\n> Thanks.\n\nI'm happy, you're happy, it's trivial. I'll merge it.\nThanks.\n\nKieran\n\n\n> \n> On 9/24/20 3:20 PM, Kieran Bingham wrote:\n>> The exif object sets the byte ordering on construction, and then\n>> during later calls re-states the byte ordering when setting values.\n>>\n>> It could be argued that this ordering should already be known to the exif\n>> library and is redudant, but even so we must provide it.\n>>\n>> Ensure we are consistent in always using the same byte ordering by\n>> setting\n>> a private class member to re-use a single value.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>>\n>> This patch itself feels like it might be a bit redundant, but I saw the\n>> repetition, and whilst we're not likely to change the byte order, I\n>> thought it might make sense to ensure it's always set from the same\n>> state variable.\n>>\n>> If this is helpful we can add it, but if this is overkill I don't mind\n>> dropping it. It's just an idea.\n>>\n>>   src/android/jpeg/exif.cpp | 11 ++++++-----\n>>   src/android/jpeg/exif.h   |  1 +\n>>   2 files changed, 7 insertions(+), 5 deletions(-)\n>>\n>> diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp\n>> index 1ced55343ee9..f29a7c71d1ec 100644\n>> --- a/src/android/jpeg/exif.cpp\n>> +++ b/src/android/jpeg/exif.cpp\n>> @@ -25,7 +25,8 @@ LOG_DEFINE_CATEGORY(EXIF)\n>>    * data can be obtained using the data() method.\n>>    */\n>>   Exif::Exif()\n>> -    : valid_(false), data_(nullptr), exifData_(0), size_(0)\n>> +    : valid_(false), data_(nullptr), order_(EXIF_BYTE_ORDER_INTEL),\n>> +      exifData_(0), size_(0)\n>>   {\n>>       /* Create an ExifMem allocator to construct entries. */\n>>       mem_ = exif_mem_new_default();\n>> @@ -49,7 +50,7 @@ Exif::Exif()\n>>        * Big-Endian: EXIF_BYTE_ORDER_MOTOROLA\n>>        * Little Endian: EXIF_BYTE_ORDER_INTEL\n>>        */\n>> -    exif_data_set_byte_order(data_, EXIF_BYTE_ORDER_INTEL);\n>> +    exif_data_set_byte_order(data_, order_);\n>>         /* Create the mandatory EXIF fields with default data. */\n>>       exif_data_fix(data_);\n>> @@ -131,7 +132,7 @@ void Exif::setShort(ExifIfd ifd, ExifTag tag,\n>> uint16_t item)\n>>       if (!entry)\n>>           return;\n>>   -    exif_set_short(entry->data, EXIF_BYTE_ORDER_INTEL, item);\n>> +    exif_set_short(entry->data, order_, item);\n>>       exif_entry_unref(entry);\n>>   }\n>>   @@ -141,7 +142,7 @@ void Exif::setLong(ExifIfd ifd, ExifTag tag,\n>> uint32_t item)\n>>       if (!entry)\n>>           return;\n>>   -    exif_set_long(entry->data, EXIF_BYTE_ORDER_INTEL, item);\n>> +    exif_set_long(entry->data, order_, item);\n>>       exif_entry_unref(entry);\n>>   }\n>>   @@ -151,7 +152,7 @@ void Exif::setRational(ExifIfd ifd, ExifTag tag,\n>> ExifRational item)\n>>       if (!entry)\n>>           return;\n>>   -    exif_set_rational(entry->data, EXIF_BYTE_ORDER_INTEL, item);\n>> +    exif_set_rational(entry->data, order_, item);\n>>       exif_entry_unref(entry);\n>>   }\n>>   diff --git a/src/android/jpeg/exif.h b/src/android/jpeg/exif.h\n>> index 622de4cfd593..6e8ce04a2e67 100644\n>> --- a/src/android/jpeg/exif.h\n>> +++ b/src/android/jpeg/exif.h\n>> @@ -46,6 +46,7 @@ private:\n>>         ExifData *data_;\n>>       ExifMem *mem_;\n>> +    ExifByteOrder order_;\n>>         unsigned char *exifData_;\n>>       unsigned int size_;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF27DC3B5B\n\tfor ;\n\tFri, 2 Oct 2020 09:18:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A03CE623B6;\n\tFri, 2 Oct 2020 11:18:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C1A46035D\n\tfor ;\n\tFri, 2 Oct 2020 11:18:15 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E149B2A2;\n\tFri, 2 Oct 2020 11:18:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BntOKJaH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601630295;\n\tbh=kQCJFz/DeQ7H6y9ENochBVlocLr5HEikyox0ag3L00U=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=BntOKJaHy5DFPtoWrC0JdRCUVwfb4MBzjKdbRon6ytoxhL1TjZEisnIT5nHStOqLn\n\tyvJzIHKJiZ9lGJaTrDIgEgBLHEos1EDXbVcIlDfjO3PZDygtkhfqKbyYAvrK1qrbiW\n\t/JNgK0NrI6LrfU8QmDcaLuI84x78ti5y0+xBBk7k=","To":"Umang Jain ,\n\tlibcamera devel ","References":"<20200924095008.338920-1-kieran.bingham@ideasonboard.com>\n\t<1c64d069-8594-9202-f578-070e89e3be7d@uajain.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<41a3ffe4-bc4d-b6a7-9401-355d0b3f7058@ideasonboard.com>","Date":"Fri, 2 Oct 2020 10:18:12 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<1c64d069-8594-9202-f578-070e89e3be7d@uajain.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] src: android: exif: Set the class\n\tbyte ordering","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]