[{"id":12734,"web_url":"https://patchwork.libcamera.org/comment/12734/","msgid":"<20200924140850.GP3968@pendragon.ideasonboard.com>","date":"2020-09-24T14:08:50","subject":"Re: [libcamera-devel] [PATCH v2 11/11] libcamera: Add a check for\n\tthe yaml module","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Ricardo,\n\nThank you for the patch.\n\nOn Thu, Sep 24, 2020 at 09:19:22AM +0200, Ricardo Ribalda wrote:\n> Yaml is not installed by default, so it needs to be checked during\n> configuration for its presence.\n> \n> Credit-to: Ezequiel Garcia \n> Cc: Ezequiel Garcia \n> Signed-off-by: Ricardo Ribalda \n\nIf you don't mind, I'll apply\nhttps://lists.libcamera.org/pipermail/libcamera-devel/2019-November/005517.html\ninstead.\n\n> ---\n> src/libcamera/meson.build | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 0e6ecf5..575bea1 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -77,6 +77,7 @@ if libudev.found()\n> ])\n> endif\n> \n> +import('python').find_installation('python3', modules : ['yaml'])\n> gen_controls = files('gen-controls.py')\n> \n> control_sources = []","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7BAF8C3B5B\n\tfor ;\n\tThu, 24 Sep 2020 14:09:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0FFFD62FDA;\n\tThu, 24 Sep 2020 16:09:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0EACC60362\n\tfor ;\n\tThu, 24 Sep 2020 16:09:25 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A187B2FD;\n\tThu, 24 Sep 2020 16:09:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AqtxHnYB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600956563;\n\tbh=EjKd3AIIxYYgyUFQ9Kb+KzP9SvLoKrqTSo9VNkkL3Wo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=AqtxHnYBpyoV4RP4KNFK4RAOXECxn+AQ1PzFKrIYeVNAFR2dHzCbfZSlVdDP35Fse\n\tdQT65KORfohInsKIYBehzcIP4qMuEZ+LEuiJYCxvr0l6fdS6C4ht0QpUXr5pGb7AJI\n\tCA/+NI0DBagzBrti7w75A2ZEswqiGQq27K6QNMwY=","Date":"Thu, 24 Sep 2020 17:08:50 +0300","From":"Laurent Pinchart ","To":"Ricardo Ribalda ","Message-ID":"<20200924140850.GP3968@pendragon.ideasonboard.com>","References":"<20200924071922.231063-1-ricardo@ribalda.com>\n\t<20200924071922.231063-12-ricardo@ribalda.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200924071922.231063-12-ricardo@ribalda.com>","Subject":"Re: [libcamera-devel] [PATCH v2 11/11] libcamera: Add a check for\n\tthe yaml module","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org,\n\tEzequiel Garcia ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12737,"web_url":"https://patchwork.libcamera.org/comment/12737/","msgid":"","date":"2020-09-24T14:39:45","subject":"Re: [libcamera-devel] [PATCH v2 11/11] libcamera: Add a check for\n\tthe yaml module","submitter":{"id":71,"url":"https://patchwork.libcamera.org/api/people/71/","name":"Ricardo Ribalda","email":"ricardo@ribalda.com"},"content":"HI\n\nOn Thu, Sep 24, 2020 at 4:09 PM Laurent Pinchart\n wrote:\n>\n> Hi Ricardo,\n>\n> Thank you for the patch.\n>\n> On Thu, Sep 24, 2020 at 09:19:22AM +0200, Ricardo Ribalda wrote:\n> > Yaml is not installed by default, so it needs to be checked during\n> > configuration for its presence.\n> >\n> > Credit-to: Ezequiel Garcia \n> > Cc: Ezequiel Garcia \n> > Signed-off-by: Ricardo Ribalda \n>\n> If you don't mind, I'll apply\n> https://lists.libcamera.org/pipermail/libcamera-devel/2019-November/005517.html\n> instead.\n\nSure!, no worries\n\n>\n> > ---\n> > src/libcamera/meson.build | 1 +\n> > 1 file changed, 1 insertion(+)\n> >\n> > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> > index 0e6ecf5..575bea1 100644\n> > --- a/src/libcamera/meson.build\n> > +++ b/src/libcamera/meson.build\n> > @@ -77,6 +77,7 @@ if libudev.found()\n> > ])\n> > endif\n> >\n> > +import('python').find_installation('python3', modules : ['yaml'])\n> > gen_controls = files('gen-controls.py')\n> >\n> > control_sources = []\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BAA4AC3B5B\n\tfor ;\n\tThu, 24 Sep 2020 14:40:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D80D62FE3;\n\tThu, 24 Sep 2020 16:40:05 +0200 (CEST)","from mail-lf1-f65.google.com (mail-lf1-f65.google.com\n\t[209.85.167.65])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 15D4760363\n\tfor ;\n\tThu, 24 Sep 2020 16:40:03 +0200 (CEST)","by mail-lf1-f65.google.com with SMTP id y17so4195688lfa.8\n\tfor ;\n\tThu, 24 Sep 2020 07:40:03 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=b4EDfgndMmIFgDqWOFC+i3+uosEjl8y3zKT+kIUkAR4=;\n\tb=RqIAKuTl6ao66UuJddcqzpCrJWEHMxy6ucj+iILZoe3aeyT6+XyFrUYyTcPUvM674y\n\t1Tag3X6iuvdLUKlEUe5KknrqwQsV4KBDrJ6T6LmV4DW1NIYkq5CHtNIqX7Aj46xXYgMW\n\tP3TbtXvulEy+seIalsjMM44roHzjqTEH9BjoVrH3Ydvz6kIPw4gmZ4o9w/BhDnkGlnJu\n\tnNXcZZf4Hgdd6IXXCMJIMkkuBymqspCs2Zm49MDbFGFTlpOlr4ElFo7lhVNWatsdyC54\n\tJreo78izijo4QD5CoRejuitnf4jY2JoOUX7zxmASKbXp+3+6wXcTPRY6D7cEKSfDPjUv\n\tGsVQ==","X-Gm-Message-State":"AOAM531FwxugJhB40GZvMOoCeja85g09UhDTjbuS9z5xXyAlBea3HhPz\n\tt/cTZaQrrdUhTmF22Cv6FhzrUszhGwnlZ8d6sJ4=","X-Google-Smtp-Source":"ABdhPJwojZssEFNi5hBuD5afMJGlVGol0r89ON77/3BubcBQndzXxKHU2qyoS6d8v4ol/Gu2J43WH+vAG1EQDIYbRBs=","X-Received":"by 2002:ac2:5b4d:: with SMTP id i13mr485857lfp.12.1600958402400; \n\tThu, 24 Sep 2020 07:40:02 -0700 (PDT)","MIME-Version":"1.0","References":"<20200924071922.231063-1-ricardo@ribalda.com>\n\t<20200924071922.231063-12-ricardo@ribalda.com>\n\t<20200924140850.GP3968@pendragon.ideasonboard.com>","In-Reply-To":"<20200924140850.GP3968@pendragon.ideasonboard.com>","From":"Ricardo Ribalda Delgado ","Date":"Thu, 24 Sep 2020 16:39:45 +0200","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v2 11/11] libcamera: Add a check for\n\tthe yaml module","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org,\n\tEzequiel Garcia ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]