[{"id":12731,"web_url":"https://patchwork.libcamera.org/comment/12731/","msgid":"<20200924135955.GM3968@pendragon.ideasonboard.com>","date":"2020-09-24T13:59:55","subject":"Re: [libcamera-devel] [PATCH v2 03/11] README: Add libboost to list\n\tof dependencies","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Ricardo,\n\nThank you for the patch.\n\nOn Thu, Sep 24, 2020 at 09:19:14AM +0200, Ricardo Ribalda wrote:\n> RPi IPA, which is enabled by default, requires libboost to compile.\n> Specify in the documentation its dependencies and how to disable the\n> IPA.\n> \n> Signed-off-by: Ricardo Ribalda \n> ---\n> README.rst | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/README.rst b/README.rst\n> index 5059ce9..46efff3 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -63,6 +63,15 @@ for generating the control definitions: [required]\n> for IPA module signing: [required]\n> libgnutls28-dev openssl\n> \n> +for building the RPi IPA: [optional]\n\nRapsberry Pi usually prefer spelling it in full, I'd write \"Raspberry Pi\nIPA\". And also s/building // as it's all for the purpose of building\nlibcamera :-)\n\n> + libboost-dev\n> +\n> + If you decide to not build the RPi IP, you should configure meson this way:\n\ns/RPi IP/Raspberry Pi IPA/\n\nThis is useful but a bit tricky, as we would have to expand this list\nwhen we add new pipeline handlers (and you're already missing the simple\npipeline handler :-)). How about just stating\n\n\tSupport for Raspberry Pi can be disabled through the meson\n\t'pipelines' option to avoid this dependency.\n\nReviewed-by: Laurent Pinchart \n\n> +\n> + .. code::\n> +\n> + -Dpipelines=vimc,uvcvideo,ipu3,rkisp1\n> +\n> for device hotplug enumeration: [optional]\n> \tpkg-config libudev-dev\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C84CCC3B5B\n\tfor ;\n\tThu, 24 Sep 2020 14:00:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5365460363;\n\tThu, 24 Sep 2020 16:00:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7EC8360362\n\tfor ;\n\tThu, 24 Sep 2020 16:00:30 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2BEBA2FD;\n\tThu, 24 Sep 2020 16:00:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WY2L5VRL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600956029;\n\tbh=tEX+UocwKLR9ey4WekcmEhElDgIKUaYmKeNHGGuQcmU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WY2L5VRLMVUmFaxEkhm/e6rHaeluuR3b/4id3rER6eeP7eiSHCx/NpR1lZI/hdFFo\n\tiTr/V0IqtTT7NdcjywVz38Avh/PWnSkl7gENsx5l6oDWmDjpGT103F7UjtDs5Jz2XS\n\tZkgUI4C01fA2/nO4T9XcUKhvR+HqNRw/yPxH2JS8=","Date":"Thu, 24 Sep 2020 16:59:55 +0300","From":"Laurent Pinchart ","To":"Ricardo Ribalda ","Message-ID":"<20200924135955.GM3968@pendragon.ideasonboard.com>","References":"<20200924071922.231063-1-ricardo@ribalda.com>\n\t<20200924071922.231063-4-ricardo@ribalda.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200924071922.231063-4-ricardo@ribalda.com>","Subject":"Re: [libcamera-devel] [PATCH v2 03/11] README: Add libboost to list\n\tof dependencies","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]