[{"id":12730,"web_url":"https://patchwork.libcamera.org/comment/12730/","msgid":"<20200924135424.GL3968@pendragon.ideasonboard.com>","date":"2020-09-24T13:54:24","subject":"Re: [libcamera-devel] [PATCH v2 01/11] README: Unify dependency\n\tnames","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Ricardo,\n\nThank you for the patch.\n\nOn Thu, Sep 24, 2020 at 09:19:12AM +0200, Ricardo Ribalda wrote:\n> All the dependencies are for libcamera, so we should move all the\n> packages under this paragraph, or make a paragraph for Meson, and a\n> second one for python3-yaml. I think the later is more clear.\n>\n> Signed-off-by: Ricardo Ribalda \n> ---\n> README.rst | 7 +++++--\n> 1 file changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/README.rst b/README.rst\n> index 40d4519..e756753 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -46,8 +46,8 @@ Other distributions may have differing package names:\n> A C++ toolchain: [required]\n> \tEither {g++, clang}\n> \n> -for libcamera: [required]\n> - meson (>= 0.47) ninja-build python3-yaml\n> +Meson Build system: [required]\n> + meson (>= 0.47) ninja-build\n> \nWouldn't it be simpler to just group all the required dependencies for\nthe libcamera core in a single section ? Splitting them doesn't bring\nthat much value I think. Maybe just\n\nfor the libcamera core: [required]\n meson (>= 0.47) ninja-build python3-yaml\n\n?\n\n> If your distribution doesn't provide a recent enough version of meson,\n> you can install or upgrade it using pip3.\n> @@ -57,6 +57,9 @@ for libcamera: [required]\n> pip3 install --user meson\n> pip3 install --user --upgrade meson\n> \n> +for generating the control definitions: [required]\n> + python3-yaml\n> +\n> for device hotplug enumeration: [optional]\n> \tpkg-config libudev-dev\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0EE4DC3B5C\n\tfor ;\n\tThu, 24 Sep 2020 13:55:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D2D760363;\n\tThu, 24 Sep 2020 15:54:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D909160362\n\tfor ;\n\tThu, 24 Sep 2020 15:54:57 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 503922FD;\n\tThu, 24 Sep 2020 15:54:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZbWvgoIG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600955697;\n\tbh=jPnRScMjUjpaCAVQZoi3Odj+UNJb7My0ISP0qDopseY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZbWvgoIGKezqNT5OeQgAxR/PKXInwKnOEW1jW4krbYkUQJz5nyDwDBf370+Nm6cJK\n\trV0jKip/t/jc/JhAhKdrwkWBMdkaemEmstJI3XfOeunK5fcN/4vH0j8gC4zXeTxRh6\n\tEoYNrm2xf/83PoJSwJjBIJoJWBGdZFYbOYPv/M1Q=","Date":"Thu, 24 Sep 2020 16:54:24 +0300","From":"Laurent Pinchart ","To":"Ricardo Ribalda ","Message-ID":"<20200924135424.GL3968@pendragon.ideasonboard.com>","References":"<20200924071922.231063-1-ricardo@ribalda.com>\n\t<20200924071922.231063-2-ricardo@ribalda.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200924071922.231063-2-ricardo@ribalda.com>","Subject":"Re: [libcamera-devel] [PATCH v2 01/11] README: Unify dependency\n\tnames","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12736,"web_url":"https://patchwork.libcamera.org/comment/12736/","msgid":"<20200924142035.GR3968@pendragon.ideasonboard.com>","date":"2020-09-24T14:20:35","subject":"Re: [libcamera-devel] [PATCH v2 01/11] README: Unify dependency\n\tnames","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Sep 24, 2020 at 04:54:24PM +0300, Laurent Pinchart wrote:\n> Hi Ricardo,\n> \n> Thank you for the patch.\n> \n> On Thu, Sep 24, 2020 at 09:19:12AM +0200, Ricardo Ribalda wrote:\n> > All the dependencies are for libcamera, so we should move all the\n> > packages under this paragraph, or make a paragraph for Meson, and a\n> > second one for python3-yaml. I think the later is more clear.\n> >\n> > Signed-off-by: Ricardo Ribalda \n> > ---\n> > README.rst | 7 +++++--\n> > 1 file changed, 5 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/README.rst b/README.rst\n> > index 40d4519..e756753 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -46,8 +46,8 @@ Other distributions may have differing package names:\n> > A C++ toolchain: [required]\n> > \tEither {g++, clang}\n> > \n> > -for libcamera: [required]\n> > - meson (>= 0.47) ninja-build python3-yaml\n> > +Meson Build system: [required]\n> > + meson (>= 0.47) ninja-build\n> > \n> Wouldn't it be simpler to just group all the required dependencies for\n> the libcamera core in a single section ? Splitting them doesn't bring\n> that much value I think. Maybe just\n> \n> for the libcamera core: [required]\n> meson (>= 0.47) ninja-build python3-yaml\n> \n> ?\n\nNow that I re-read this, I think we can also go with your patch as meson\ncan be considered in the same category as the C++ toolchain.\n\n> > If your distribution doesn't provide a recent enough version of meson,\n> > you can install or upgrade it using pip3.\n> > @@ -57,6 +57,9 @@ for libcamera: [required]\n> > pip3 install --user meson\n> > pip3 install --user --upgrade meson\n> > \n> > +for generating the control definitions: [required]\n\nI would however name this \"for the libcamra core\" as I expect we'll add\nmore dependencies there.\n\nCould you let me know of your preferred option through a v2.1 of just\nthis patch ?\n\n> > + python3-yaml\n> > +\n> > for device hotplug enumeration: [optional]\n> > \tpkg-config libudev-dev\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AFF9AC3B5C\n\tfor ;\n\tThu, 24 Sep 2020 14:21:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 254C862FDE;\n\tThu, 24 Sep 2020 16:21:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D6DA660362\n\tfor ;\n\tThu, 24 Sep 2020 16:21:10 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D266E2FD;\n\tThu, 24 Sep 2020 16:21:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NqceuJfx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600957269;\n\tbh=jm26oO7/9RPb3NJWlCN0ffze5YiIjevnczNCskB9uF8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NqceuJfx5RufmgVGwfMLtwOnv3wIv/xjJh/qkiUllAHUq3gaKGBOdemf3eFx8FeoE\n\tfUYwFLFuhCuJJSsOxYm1dB9kt31eTqJw4UdC5ZEyggZOUKoOpsbh7X4sOkDkAnC8EA\n\tFlY166wo60IKhG0k31R1uX/zMxcDThuvpxFz6iwU=","Date":"Thu, 24 Sep 2020 17:20:35 +0300","From":"Laurent Pinchart ","To":"Ricardo Ribalda ","Message-ID":"<20200924142035.GR3968@pendragon.ideasonboard.com>","References":"<20200924071922.231063-1-ricardo@ribalda.com>\n\t<20200924071922.231063-2-ricardo@ribalda.com>\n\t<20200924135424.GL3968@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200924135424.GL3968@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 01/11] README: Unify dependency\n\tnames","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]