{"id":9763,"url":"https://patchwork.libcamera.org/api/patches/9763/?format=json","web_url":"https://patchwork.libcamera.org/patch/9763/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200923164412.319079-3-kieran.bingham@ideasonboard.com>","date":"2020-09-23T16:44:10","name":"[libcamera-devel,2/4] simple-cam: Use a const stream","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"693e62e39435a9a2e84c9338a98d1dcb042a16d6","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/9763/mbox/","series":[{"id":1314,"url":"https://patchwork.libcamera.org/api/series/1314/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1314","date":"2020-09-23T16:44:08","name":"simple-cam: Update to latest API usage","version":1,"mbox":"https://patchwork.libcamera.org/series/1314/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9763/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9763/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C544BC3B5B\n\tfor ;\n\tWed, 23 Sep 2020 16:44:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C77062FE8;\n\tWed, 23 Sep 2020 18:44:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F7A960576\n\tfor ;\n\tWed, 23 Sep 2020 18:44:17 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0DC49DC4;\n\tWed, 23 Sep 2020 18:44:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Yg7C/3K3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600879457;\n\tbh=gsttiJJ+appO/ORcxGY54L/6k6PAXEtjaNa6kS+Ff1Q=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Yg7C/3K3Xm0TT8zySeBcRoNrsAcQ2P681iHt3YGc6TmWrMlwjLrXjzP+lrKC6o3gK\n\tFupY+UF/frMeZ7lLE0bgI2hEbwE7e9rA0BOodlSNbsdgpNu3d/3k3+EntwjwGiQk/y\n\tBV/g/Uz3tamjDS9NZbh/DuQFd8rJn4FSM2sZCBhM=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Wed, 23 Sep 2020 17:44:10 +0100","Message-Id":"<20200923164412.319079-3-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200923164412.319079-1-kieran.bingham@ideasonboard.com>","References":"<20200923164412.319079-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 2/4] simple-cam: Use a const stream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Erkan Diken ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The API was updated to ensure the Stream pointer referenced from the\nBufferMap is const.\n\nUpdate accordingly.\n\nReported-by: Erkan Diken \nSigned-off-by: Kieran Bingham \n---\n simple-cam.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/simple-cam.cpp b/simple-cam.cpp\nindex e2ac122546ce..3aa975e14f48 100644\n--- a/simple-cam.cpp\n+++ b/simple-cam.cpp\n@@ -70,7 +70,7 @@ static void requestComplete(Request *request)\n \n \tfor (auto it = buffers.begin(); it != buffers.end(); ++it)\n \t{\n-\t\tStream *stream = it->first;\n+\t\tconst Stream *stream = it->first;\n \t\tFrameBuffer *buffer = it->second;\n \n \t\trequest->addBuffer(stream, buffer);\n","prefixes":["libcamera-devel","2/4"]}