[{"id":12692,"web_url":"https://patchwork.libcamera.org/comment/12692/","msgid":"<08a0ab73-1e05-ffa4-15cf-a3d2ed34c1e1@ideasonboard.com>","date":"2020-09-23T20:18:32","subject":"Re: [libcamera-devel] [PATCH 9/9] libcamera: Add a check for the\n\tyaml module","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 23/09/2020 16:15, Ricardo Ribalda wrote:\n> Yaml is not installed by default, so it needs to be checked during\n> configuration for its presence.\n> \n> At this point we are aiming for meson_version >= 0.47, and the python\n> module detection has been introduced in 0.51, so the fix is added in a\n> comment under FIXME.\n> \n> Signed-off-by: Ricardo Ribalda \n> ---\n> src/libcamera/meson.build | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 0e6ecf5..43a5fde 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -77,6 +77,9 @@ if libudev.found()\n> ])\n> endif\n> \n> +#FIXME to be added if we force meson version >= 0.51.0\n> +#py = import('python').find_installation('python3', modules : ['yaml'])\n> +\n\nIndeed, this came up in a previous discussion somewhere.\n\nHaving it as an explicitly disabled addition seems like a good idea to\nme - but I'd change FIXME for TODO which is our usual style of stating\nsomething needs to be done later.\n\nWith that, I think this is helpful to 'pre-add', and sometime soon I'm\nsure we'll end up bumping the meson version.\n\nI'm already working on a patch which would require an as yet unreleased\nmeson ;-)\n\nSo with TODO instead of FIXME:\n\nReviewed-by: Kieran Bingham \n\n> gen_controls = files('gen-controls.py')\n> \n> control_sources = []\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1455C3B5B\n\tfor ;\n\tWed, 23 Sep 2020 20:18:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A6BA62FDE;\n\tWed, 23 Sep 2020 22:18:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 278CB60576\n\tfor ;\n\tWed, 23 Sep 2020 22:18:37 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9056B555;\n\tWed, 23 Sep 2020 22:18:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HAPBMyOB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600892316;\n\tbh=NYUJhp2TqGpxFP7iDz0VVusyD8tZn32BnMHHJYwHIVE=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=HAPBMyOBlD2Qd8SrI3PNuBqWkszfSOuMNQzv8U/2aoYdA843CHbvU+5SaelinZWUl\n\tiQRktjnhDoFTNczqAzVH0GzbzuCpyoGgKyRF1hdlyf8GlykqlZn1mh5bmt1aWQ0MKx\n\tFB6Ypiad/hCrzuS0VG9vXJO3cYHS/tdtsA/RSFv8=","To":"Ricardo Ribalda ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200923151522.56778-1-ricardo@ribalda.com>\n\t<20200923151522.56778-10-ricardo@ribalda.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<08a0ab73-1e05-ffa4-15cf-a3d2ed34c1e1@ideasonboard.com>","Date":"Wed, 23 Sep 2020 21:18:32 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200923151522.56778-10-ricardo@ribalda.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 9/9] libcamera: Add a check for the\n\tyaml module","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12707,"web_url":"https://patchwork.libcamera.org/comment/12707/","msgid":"<20200924030148.GX3980@pendragon.ideasonboard.com>","date":"2020-09-24T03:01:48","subject":"Re: [libcamera-devel] [PATCH 9/9] libcamera: Add a check for the\n\tyaml module","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Sep 23, 2020 at 09:18:32PM +0100, Kieran Bingham wrote:\n> On 23/09/2020 16:15, Ricardo Ribalda wrote:\n> > Yaml is not installed by default, so it needs to be checked during\n> > configuration for its presence.\n> > \n> > At this point we are aiming for meson_version >= 0.47, and the python\n> > module detection has been introduced in 0.51, so the fix is added in a\n> > comment under FIXME.\n> > \n> > Signed-off-by: Ricardo Ribalda \n> > ---\n> > src/libcamera/meson.build | 3 +++\n> > 1 file changed, 3 insertions(+)\n> > \n> > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> > index 0e6ecf5..43a5fde 100644\n> > --- a/src/libcamera/meson.build\n> > +++ b/src/libcamera/meson.build\n> > @@ -77,6 +77,9 @@ if libudev.found()\n> > ])\n> > endif\n> > \n> > +#FIXME to be added if we force meson version >= 0.51.0\n> > +#py = import('python').find_installation('python3', modules : ['yaml'])\n> > +\n> \n> Indeed, this came up in a previous discussion somewhere.\n> \n> Having it as an explicitly disabled addition seems like a good idea to\n> me - but I'd change FIXME for TODO which is our usual style of stating\n> something needs to be done later.\n> \n> With that, I think this is helpful to 'pre-add', and sometime soon I'm\n> sure we'll end up bumping the meson version.\n\nI think we can switch to meson 0.51 already, as it's available in the\nstable backports of Debian. I'd then propose merging Ezequiel's patch\nthat checks for the yaml module, as it has been posted a while ago.\n\n> I'm already working on a patch which would require an as yet unreleased\n> meson ;-)\n> \n> So with TODO instead of FIXME:\n> \n> Reviewed-by: Kieran Bingham \n>\n> > gen_controls = files('gen-controls.py')\n> > \n> > control_sources = []","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8B02C3B5B\n\tfor ;\n\tThu, 24 Sep 2020 03:02:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 454F962FD2;\n\tThu, 24 Sep 2020 05:02:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 093AE6036A\n\tfor ;\n\tThu, 24 Sep 2020 05:02:22 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 743442FD;\n\tThu, 24 Sep 2020 05:02:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ntnu4u6l\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600916541;\n\tbh=eG4QL2denMUkix7S3hHat3c3jmIfC2y6vuSaj7t321Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ntnu4u6l6F0dvjYWUl0jpdQHWiIdhiv/cGO71IOFrUdPE5pOcTgv6F5q99y2bfl1W\n\t5iYO8caJKh4P7aeIkgUuaTIhyuSF0st/fEvUeGcYhPIUVTRP5DCB5BwGU8QUsdoUEf\n\tGOQb+1Fas5Eay/LDprCdbRFb2d1Aio+g4vXJ6EXY=","Date":"Thu, 24 Sep 2020 06:01:48 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200924030148.GX3980@pendragon.ideasonboard.com>","References":"<20200923151522.56778-1-ricardo@ribalda.com>\n\t<20200923151522.56778-10-ricardo@ribalda.com>\n\t<08a0ab73-1e05-ffa4-15cf-a3d2ed34c1e1@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<08a0ab73-1e05-ffa4-15cf-a3d2ed34c1e1@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 9/9] libcamera: Add a check for the\n\tyaml module","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]