[{"id":1431,"web_url":"https://patchwork.libcamera.org/comment/1431/","msgid":"<20190417105030.GD4993@pendragon.ideasonboard.com>","date":"2019-04-17T10:50:30","subject":"Re: [libcamera-devel] [RFC 07/11] [HACK] tests: disable\n\tmedia_device_link_test","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Sun, Apr 14, 2019 at 03:35:02AM +0200, Niklas Söderlund wrote:\n> The test depends on the ability to access acquire() and release() of\n> MediaDevice. These members are about to be made private and will no\n> longer be cacheable to the test.\n> \n> This needs to be solved as the test suite needs to be able to unit test\n> classes properly. But for the purpose of this RFC lets disable it while\n> it's figured out how to solve it.\n\nAs previously discussed, I think we can make test classes friends of the\nimplementation they test, probably with a LIBCAMERA_TEST_FRIEND() or\nsimilar macro to only enable this behaviour when compiling tests.\n\n> Not-Signed-off-by: Niklas Söderlund \n> ---\n> test/media_device/meson.build | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/test/media_device/meson.build b/test/media_device/meson.build\n> index d91a022fab190abf..e4bedb79b572d655 100644\n> --- a/test/media_device/meson.build\n> +++ b/test/media_device/meson.build\n> @@ -1,6 +1,5 @@\n> media_device_tests = [\n> ['media_device_print_test', 'media_device_print_test.cpp'],\n> - ['media_device_link_test', 'media_device_link_test.cpp'],\n> ]\n> \n> foreach t : media_device_tests","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D0F6F60DBE\n\tfor ;\n\tWed, 17 Apr 2019 12:50:39 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 66A89512;\n\tWed, 17 Apr 2019 12:50:39 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1555498239;\n\tbh=XLFdl/fUPLf2Bhan24UI2sYsfi9F77RwbPLR5SUFcQs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eiuLKodga+iUzEI6aKyWjHYwxtq0/9nquALUqbUs0d57QLwieG2yc9VeDjZqodRSw\n\tHhkccGw0HbqID25t0nGTxLvF18a+WdJwzTJo6kTpeC5H6W8JIxkIq6BsbeSifflG//\n\t4AIzdATiD2VYSOtBlCq0uo+HnfYIOcc/oKfrx190=","Date":"Wed, 17 Apr 2019 13:50:30 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190417105030.GD4993@pendragon.ideasonboard.com>","References":"<20190414013506.10515-1-niklas.soderlund@ragnatech.se>\n\t<20190414013506.10515-8-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190414013506.10515-8-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [RFC 07/11] [HACK] tests: disable\n\tmedia_device_link_test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 17 Apr 2019 10:50:48 -0000"}}]