[{"id":12687,"web_url":"https://patchwork.libcamera.org/comment/12687/","msgid":"","date":"2020-09-23T20:03:15","subject":"Re: [libcamera-devel] [PATCH 4/9] README: Move pkg-config to Meson\n\tsection","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Ricardo,\n\nOn 23/09/2020 16:15, Ricardo Ribalda wrote:\n> pkg-config it is not only used to detect libudev-dev, it is used for\n> detecting gstreamer and others. So it is more correct to place it on the\n> Meson Build system section.\n> \n\nHrm, I wonder what is possible to build without pkg-config.\n\nGstreamer is an optional component, so that doesn't matter so much - I\nwonder if even cam/qcam would link against libcamera as I bet they use\npkg-config too underneath.\n\nI'd be interested to know what fails without pkg-config - but I think\nit's important enough to call it required so I don't object to this.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Ricardo Ribalda \n> ---\n> README.rst | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/README.rst b/README.rst\n> index 9013c1d..836750a 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -47,7 +47,7 @@ A C++ toolchain: [required]\n> \tEither {g++, clang}\n> \n> Meson Build system: [required]\n> - meson (>= 0.47) ninja-build python3-yaml\n> + meson (>= 0.47) ninja-build python3-yaml pkg-config\n> \n> If your distribution doesn't provide a recent enough version of meson,\n> you can install or upgrade it using pip3.\n> @@ -64,7 +64,7 @@ for IPA module signing: [required]\n> libgnutls28-dev openssl\n> \n> for device hotplug enumeration: [optional]\n> -\tpkg-config libudev-dev\n> +\tlibudev-dev\n> \n> for documentation: [optional]\n> \tpython3-sphinx doxygen\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50FD8C3B5C\n\tfor ;\n\tWed, 23 Sep 2020 20:03:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B77A262FDE;\n\tWed, 23 Sep 2020 22:03:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC7D560576\n\tfor ;\n\tWed, 23 Sep 2020 22:03:18 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4704C555;\n\tWed, 23 Sep 2020 22:03:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Et0BQrvq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600891398;\n\tbh=yfIALh1/GJavLZ0WS6eXsZD4iA1Td/xOwdVdSnOWmpY=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=Et0BQrvq1cIWrDgXkDvNePDgL348hb5FZXtTAUabh6YPG0J4tgyOh9mAYtxdQhn/r\n\tEFQ+LdJZfmEx76xbQDbH2ODu0WhZr1pPVRrcFpmtpYp+s5zOqeBowLgLef1DvibOcT\n\taoDeAVQzb9tlfkwZoE0pVxRCjYfGXL5oYXU0RgDg=","To":"Ricardo Ribalda ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200923151522.56778-1-ricardo@ribalda.com>\n\t<20200923151522.56778-5-ricardo@ribalda.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Wed, 23 Sep 2020 21:03:15 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200923151522.56778-5-ricardo@ribalda.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 4/9] README: Move pkg-config to Meson\n\tsection","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12705,"web_url":"https://patchwork.libcamera.org/comment/12705/","msgid":"<20200924024255.GV3980@pendragon.ideasonboard.com>","date":"2020-09-24T02:42:55","subject":"Re: [libcamera-devel] [PATCH 4/9] README: Move pkg-config to Meson\n\tsection","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Sep 23, 2020 at 09:03:15PM +0100, Kieran Bingham wrote:\n> On 23/09/2020 16:15, Ricardo Ribalda wrote:\n> > pkg-config it is not only used to detect libudev-dev, it is used for\n> > detecting gstreamer and others. So it is more correct to place it on the\n> > Meson Build system section.\n> \n> Hrm, I wonder what is possible to build without pkg-config.\n> \n> Gstreamer is an optional component, so that doesn't matter so much - I\n> wonder if even cam/qcam would link against libcamera as I bet they use\n> pkg-config too underneath.\n> \n> I'd be interested to know what fails without pkg-config - but I think\n> it's important enough to call it required so I don't object to this.\n\nLikewise, I don't think we need to support pkg-config being absent.\n\n> Reviewed-by: Kieran Bingham \n> \n> > Signed-off-by: Ricardo Ribalda \n> > ---\n> > README.rst | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/README.rst b/README.rst\n> > index 9013c1d..836750a 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -47,7 +47,7 @@ A C++ toolchain: [required]\n> > \tEither {g++, clang}\n> > \n> > Meson Build system: [required]\n> > - meson (>= 0.47) ninja-build python3-yaml\n> > + meson (>= 0.47) ninja-build python3-yaml pkg-config\n\nMaybe keeping these alphabetically sorted ?\n\n> > \n> > If your distribution doesn't provide a recent enough version of meson,\n> > you can install or upgrade it using pip3.\n> > @@ -64,7 +64,7 @@ for IPA module signing: [required]\n> > libgnutls28-dev openssl\n> > \n> > for device hotplug enumeration: [optional]\n> > -\tpkg-config libudev-dev\n> > +\tlibudev-dev\n> > \n> > for documentation: [optional]\n> > \tpython3-sphinx doxygen\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7473DC3B5C\n\tfor ;\n\tThu, 24 Sep 2020 02:43:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC0CC62FDE;\n\tThu, 24 Sep 2020 04:43:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C250C6036A\n\tfor ;\n\tThu, 24 Sep 2020 04:43:29 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3DEA22FD;\n\tThu, 24 Sep 2020 04:43:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nHRXfpVE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600915409;\n\tbh=7LHjhh5T5dGsWq6F84UqBA+XSh2v7LgtiW04bV6Dzpw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nHRXfpVEk/O6VlzxSag89vYYhbbrNYMssbZDOTFbMcQIh5lNj/2GtMCJDBmE0PmJr\n\tbp33YDCnZpznseIEy6JlhmS91kGxlxBdm1HpGsoDFl6HznV2+M8ZeMv91LNFN1IfxI\n\tkMxamvaCDDOrr0BV1ltFJ0i3+iLL7q3FgS/TZ98I=","Date":"Thu, 24 Sep 2020 05:42:55 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200924024255.GV3980@pendragon.ideasonboard.com>","References":"<20200923151522.56778-1-ricardo@ribalda.com>\n\t<20200923151522.56778-5-ricardo@ribalda.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 4/9] README: Move pkg-config to Meson\n\tsection","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]