[{"id":12684,"web_url":"https://patchwork.libcamera.org/comment/12684/","msgid":"<0659a6bc-62ac-59d8-30be-92e5cf4474d5@ideasonboard.com>","date":"2020-09-23T19:57:58","subject":"Re: [libcamera-devel] [PATCH 3/9] README: Add libboost to list of\n\tdependencies","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Ricardo,\n\nOn 23/09/2020 16:15, Ricardo Ribalda wrote:\n> Without it:\n> \n> Run-time dependency libudev found: NO (tried pkgconfig and cmake)\n> Run-time dependency threads found: YES\n> Run-time dependency Boost found: NO\n> \n> src/ipa/raspberrypi/meson.build:5:0: ERROR: Dependency \"boost\" not found\n\nThis one is actually optional - it's just a sub-optimal method to work\naround it.\n\nI'd really like this to be automatic so that if it's not found the\nraspberry-pi pipeline is disabled, and I even have a patch I created\nseveral weeks ago.\n\nBut I'm not particularly happy with that - and so I haven't submitted it ;-(\n\n\n> \n> Signed-off-by: Ricardo Ribalda \n> ---\n> README.rst | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/README.rst b/README.rst\n> index cfd0be7..9013c1d 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -57,6 +57,9 @@ Meson Build system: [required]\n> pip3 install --user meson\n> pip3 install --user --upgrade meson\n> \n> +Boost C++ Libraries: [required]\n\nI think we could add this as [optional], stating that it is required to\nenable the RPi IPA.\n\nThe difficulty is that the RPi IPA is enabled by default, so that's why\nit impacts users more.\n\nTo disable, you can specify -Dpipelines=vimc,uvcvideo,ipu3,rkisp1 on the\nmeson configuration line.\n\nThat's not particularly friendly either though - so maybe I should just\npost my patch to disable the RPi IPA when there is no boost library\nfound, and hash it out on there.\n\n--\nKieran\n\n\n\n> + libboost-dev\n> +\n> for IPA module signing: [required]\n> libgnutls28-dev openssl\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5CB2BC3B5B\n\tfor ;\n\tWed, 23 Sep 2020 19:58:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C09FE62FDE;\n\tWed, 23 Sep 2020 21:58:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F0C4860576\n\tfor ;\n\tWed, 23 Sep 2020 21:58:01 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 76A31555;\n\tWed, 23 Sep 2020 21:58:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Z2K0pISs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600891081;\n\tbh=ILggMb7NFgmY0jOUPUtE4fDnfgTdI/6yzbPm1ZsTnnc=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=Z2K0pISs1K+wTDsJLJtCFxuDq1V1S4iIDG8fQmfzR8BVe+eoMVOPCZcU+tWOknVLf\n\tDRv7UX8IAaX2xw+bZqEONKUu68B468yGVn5FeLUMlOkLqY75z2jHv5GNuvKtaCGYaW\n\tb9dZHZuCZUZvT/5lu8tyN6svR1ilJbzNjiV2qHUY=","To":"Ricardo Ribalda ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200923151522.56778-1-ricardo@ribalda.com>\n\t<20200923151522.56778-4-ricardo@ribalda.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<0659a6bc-62ac-59d8-30be-92e5cf4474d5@ideasonboard.com>","Date":"Wed, 23 Sep 2020 20:57:58 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200923151522.56778-4-ricardo@ribalda.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 3/9] README: Add libboost to list of\n\tdependencies","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12704,"web_url":"https://patchwork.libcamera.org/comment/12704/","msgid":"<20200924024051.GU3980@pendragon.ideasonboard.com>","date":"2020-09-24T02:40:51","subject":"Re: [libcamera-devel] [PATCH 3/9] README: Add libboost to list of\n\tdependencies","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Sep 23, 2020 at 08:57:58PM +0100, Kieran Bingham wrote:\n> Hi Ricardo,\n> \n> On 23/09/2020 16:15, Ricardo Ribalda wrote:\n> > Without it:\n> > \n> > Run-time dependency libudev found: NO (tried pkgconfig and cmake)\n> > Run-time dependency threads found: YES\n> > Run-time dependency Boost found: NO\n> > \n> > src/ipa/raspberrypi/meson.build:5:0: ERROR: Dependency \"boost\" not found\n> \n> This one is actually optional - it's just a sub-optimal method to work\n> around it.\n> \n> I'd really like this to be automatic so that if it's not found the\n> raspberry-pi pipeline is disabled, and I even have a patch I created\n> several weeks ago.\n> \n> But I'm not particularly happy with that - and so I haven't submitted it ;-(\n> \n> \n> > \n> > Signed-off-by: Ricardo Ribalda \n> > ---\n> > README.rst | 3 +++\n> > 1 file changed, 3 insertions(+)\n> > \n> > diff --git a/README.rst b/README.rst\n> > index cfd0be7..9013c1d 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -57,6 +57,9 @@ Meson Build system: [required]\n> > pip3 install --user meson\n> > pip3 install --user --upgrade meson\n> > \n> > +Boost C++ Libraries: [required]\n> \n> I think we could add this as [optional], stating that it is required to\n> enable the RPi IPA.\n> \n> The difficulty is that the RPi IPA is enabled by default, so that's why\n> it impacts users more.\n> \n> To disable, you can specify -Dpipelines=vimc,uvcvideo,ipu3,rkisp1 on the\n> meson configuration line.\n> \n> That's not particularly friendly either though - so maybe I should just\n> post my patch to disable the RPi IPA when there is no boost library\n> found, and hash it out on there.\n\nGood idea. I can already provide one review comment, even before I see\nthe code :-) I'd like this to be implemented in a generic way that will\nallow each IPA to state its dependencies in its meson.build file. I\nthink we'll then need to populate a variable to store the list of\nactually enabled pipeline handlers, and replace the\nget_options('pipelines') with that in the top-level meson.build file. It\nwould be neat if the IPA dependency could be handled in the IPA\nmeson.build file, but src/libcamera/ is included before src/ipa/, and we\nneed to select pipeline handlers in src/libcamera/pipelines/. I'm not\nsure if we could solve this one easily.\n\n> > + libboost-dev\n> > +\n> > for IPA module signing: [required]\n> > libgnutls28-dev openssl\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 98DE1C3B5B\n\tfor ;\n\tThu, 24 Sep 2020 02:41:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0BEC362FDE;\n\tThu, 24 Sep 2020 04:41:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C9386036A\n\tfor ;\n\tThu, 24 Sep 2020 04:41:25 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CBD092FD;\n\tThu, 24 Sep 2020 04:41:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZQ2qU1EA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600915285;\n\tbh=F9RYQrsQqBauD0HM65Too7ubwhv2Pmj6sRvR7+mtSP4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZQ2qU1EA0fPRoLhd3sZV0aYXQ++8P/R9yXfC4o73gnpwOB/XoEmNuwdemcf12WAHc\n\t5fu8+JT3pGbwXKBAHIE0U9m9kVKe56qTUDn2wDjhwLKLut2jjQLhVaLgjwhHhWBks6\n\teLjAYn/5VUuUIArmmDo/nUQBHwcDkx1XgKmfGZmM=","Date":"Thu, 24 Sep 2020 05:40:51 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200924024051.GU3980@pendragon.ideasonboard.com>","References":"<20200923151522.56778-1-ricardo@ribalda.com>\n\t<20200923151522.56778-4-ricardo@ribalda.com>\n\t<0659a6bc-62ac-59d8-30be-92e5cf4474d5@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<0659a6bc-62ac-59d8-30be-92e5cf4474d5@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 3/9] README: Add libboost to list of\n\tdependencies","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]