[{"id":12680,"web_url":"https://patchwork.libcamera.org/comment/12680/","msgid":"<20200923160617.GF3980@pendragon.ideasonboard.com>","date":"2020-09-23T16:06:17","subject":"Re: [libcamera-devel] [PATCH v2 3/4] src: meson: Rename\n\tipa_gen_priv_key to gen_ipa_priv_key","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Sep 23, 2020 at 03:39:48PM +0100, Kieran Bingham wrote:\n> Refactor the naming of the custom command variable to match the style\n> used in the other custom target generators, and the name of the script.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> I've chosen to keep this as a separate patch to keep the rename and move\n> distinct.\n> ---\n> src/meson.build | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/meson.build b/src/meson.build\n> index 0c5b64d68c15..db155e68e848 100644\n> --- a/src/meson.build\n> +++ b/src/meson.build\n> @@ -4,10 +4,10 @@ subdir('android')\n> \n> openssl = find_program('openssl', required : true)\n> if openssl.found()\n> - ipa_gen_priv_key = files('ipa/gen-ipa-priv-key.sh')\n> + gen_ipa_priv_key = files('ipa/gen-ipa-priv-key.sh')\n> ipa_priv_key = custom_target('ipa-priv-key',\n> output : [ 'ipa-priv-key.pem' ],\n> - command : [ ipa_gen_priv_key, '@OUTPUT@' ])\n> + command : [ gen_ipa_priv_key, '@OUTPUT@' ])\n> config_h.set('HAVE_IPA_PUBKEY', 1)\n> ipa_sign_module = true\n> else","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E960BC3B5B\n\tfor ;\n\tWed, 23 Sep 2020 16:06:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78D0E62FDE;\n\tWed, 23 Sep 2020 18:06:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D38660576\n\tfor ;\n\tWed, 23 Sep 2020 18:06:51 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 88E51555;\n\tWed, 23 Sep 2020 18:06:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l1ZO2kvP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600877210;\n\tbh=MeXnrikemdE1zWr4mMAXH8EQzncpzCm9l68oD0GzcL4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=l1ZO2kvP1hiczdcFwEXSWJ7QIec7qkRYTkY8gxf6IT9IUtDDqN463PkUmFZMacp+b\n\tfgvXi//qCI52fH2qXEfXqzuHmo49zh3WEqknKx3tGfA6+t23Ragt4peBeszVmjXZMA\n\tOWZd4WCXmp+Tgt/A3f0X7XImnjuH2aVzKhrcQbVk=","Date":"Wed, 23 Sep 2020 19:06:17 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200923160617.GF3980@pendragon.ideasonboard.com>","References":"<20200923143949.310439-1-kieran.bingham@ideasonboard.com>\n\t<20200923143949.310439-4-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200923143949.310439-4-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 3/4] src: meson: Rename\n\tipa_gen_priv_key to gen_ipa_priv_key","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]