[{"id":12859,"web_url":"https://patchwork.libcamera.org/comment/12859/","msgid":"<20200929035908.GY14614@pendragon.ideasonboard.com>","date":"2020-09-29T03:59:08","subject":"Re: [libcamera-devel] [PATCH 06/38] utils: ipc: import mojo","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Tue, Sep 22, 2020 at 10:35:05PM +0900, Paul Elder wrote:\n> Import mojo from Chromium repository, so that we can use it for\n> generating code for the IPC mechanism. The commit from which this was\n> taken is:\n> a079161ec8c6907b883f9cb84fc8c4e7896cb1d0 \"Add PPAPI constructs for\n> sending focus object to PdfAccessibilityTree\"\n> \n> This tree has been pruned to remove directories that didn't have any\n> necessary code:\n> - mojo/* except for mojo/public\n> - mojo core, docs, and misc files\n> - mojo/public/* except for mojo/public/{tools,LICENSE}\n> - language bindings for IPC, tests, and some mojo internals\n> - mojo/public/tools/{fuzzers,chrome_ipc}\n> - mojo/public/tools/bindings/generators\n> - code generation for other languages\n> \n> No files were modified.\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> Changes in v2:\n> - add chromium commit id, list of pruned directories, and list of\n> modified files to the changelog\n\nHas any file been modified, with the commit message stating \"no files\nwere modified\" ? :-)\n\n> ---\n> utils/ipc/mojo/public/LICENSE | 27 +\n> utils/ipc/mojo/public/tools/.style.yapf | 6 +\n> utils/ipc/mojo/public/tools/BUILD.gn | 18 +\n> utils/ipc/mojo/public/tools/bindings/BUILD.gn | 108 +\n> .../ipc/mojo/public/tools/bindings/README.md | 816 +++++++\n> .../chromium_bindings_configuration.gni | 51 +\n> .../tools/bindings/compile_typescript.py | 27 +\n> .../tools/bindings/concatenate-files.py | 54 +\n> ...concatenate_and_replace_closure_exports.py | 73 +\n> .../bindings/format_typemap_generator_args.py | 36 +\n> .../tools/bindings/gen_data_files_list.py | 52 +\n> .../tools/bindings/generate_type_mappings.py | 187 ++\n> .../ipc/mojo/public/tools/bindings/mojom.gni | 1941 +++++++++++++++++\n> .../bindings/mojom_bindings_generator.py | 390 ++++\n> .../mojom_bindings_generator_unittest.py | 62 +\n> .../tools/bindings/mojom_types_downgrader.py | 119 +\n> .../tools/bindings/validate_typemap_config.py | 57 +\n> utils/ipc/mojo/public/tools/mojom/README.md | 14 +\n> .../mojom/check_stable_mojom_compatibility.py | 170 ++\n> ...eck_stable_mojom_compatibility_unittest.py | 260 +++\n> .../mojo/public/tools/mojom/const_unittest.py | 90 +\n> .../mojo/public/tools/mojom/enum_unittest.py | 92 +\n> .../mojo/public/tools/mojom/mojom/BUILD.gn | 43 +\n> .../mojo/public/tools/mojom/mojom/__init__.py | 0\n> .../mojo/public/tools/mojom/mojom/error.py | 28 +\n> .../mojo/public/tools/mojom/mojom/fileutil.py | 45 +\n> .../tools/mojom/mojom/fileutil_unittest.py | 40 +\n> .../tools/mojom/mojom/generate/__init__.py | 0\n> .../mojom/mojom/generate/constant_resolver.py | 93 +\n> .../tools/mojom/mojom/generate/generator.py | 325 +++\n> .../mojom/generate/generator_unittest.py | 74 +\n> .../tools/mojom/mojom/generate/module.py | 1635 ++++++++++++++\n> .../mojom/mojom/generate/module_unittest.py | 31 +\n> .../public/tools/mojom/mojom/generate/pack.py | 258 +++\n> .../mojom/mojom/generate/pack_unittest.py | 225 ++\n> .../mojom/mojom/generate/template_expander.py | 83 +\n> .../tools/mojom/mojom/generate/translate.py | 854 ++++++++\n> .../mojom/generate/translate_unittest.py | 73 +\n> .../tools/mojom/mojom/parse/__init__.py | 0\n> .../public/tools/mojom/mojom/parse/ast.py | 427 ++++\n> .../tools/mojom/mojom/parse/ast_unittest.py | 121 +\n> .../mojom/mojom/parse/conditional_features.py | 82 +\n> .../parse/conditional_features_unittest.py | 233 ++\n> .../public/tools/mojom/mojom/parse/lexer.py | 251 +++\n> .../tools/mojom/mojom/parse/lexer_unittest.py | 198 ++\n> .../public/tools/mojom/mojom/parse/parser.py | 488 +++++\n> .../mojom/mojom/parse/parser_unittest.py | 1390 ++++++++++++\n> .../mojo/public/tools/mojom/mojom_parser.py | 361 +++\n> .../tools/mojom/mojom_parser_test_case.py | 73 +\n> .../tools/mojom/mojom_parser_unittest.py | 171 ++\n> .../tools/mojom/stable_attribute_unittest.py | 127 ++\n> .../mojom/version_compatibility_unittest.py | 397 ++++\n> .../public/tools/run_all_python_unittests.py | 28 +\n> utils/ipc/tools/diagnosis/crbug_1001171.py | 51 +\n> 54 files changed, 12855 insertions(+)\n> create mode 100644 utils/ipc/mojo/public/LICENSE\n> create mode 100644 utils/ipc/mojo/public/tools/.style.yapf\n> create mode 100644 utils/ipc/mojo/public/tools/BUILD.gn\n> create mode 100644 utils/ipc/mojo/public/tools/bindings/BUILD.gn\n> create mode 100644 utils/ipc/mojo/public/tools/bindings/README.md\n> create mode 100644 utils/ipc/mojo/public/tools/bindings/chromium_bindings_configuration.gni\n> create mode 100644 utils/ipc/mojo/public/tools/bindings/compile_typescript.py\n> create mode 100755 utils/ipc/mojo/public/tools/bindings/concatenate-files.py\n> create mode 100755 utils/ipc/mojo/public/tools/bindings/concatenate_and_replace_closure_exports.py\n> create mode 100755 utils/ipc/mojo/public/tools/bindings/format_typemap_generator_args.py\n> create mode 100644 utils/ipc/mojo/public/tools/bindings/gen_data_files_list.py\n> create mode 100755 utils/ipc/mojo/public/tools/bindings/generate_type_mappings.py\n> create mode 100644 utils/ipc/mojo/public/tools/bindings/mojom.gni\n> create mode 100755 utils/ipc/mojo/public/tools/bindings/mojom_bindings_generator.py\n> create mode 100644 utils/ipc/mojo/public/tools/bindings/mojom_bindings_generator_unittest.py\n> create mode 100755 utils/ipc/mojo/public/tools/bindings/mojom_types_downgrader.py\n> create mode 100755 utils/ipc/mojo/public/tools/bindings/validate_typemap_config.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/README.md\n> create mode 100755 utils/ipc/mojo/public/tools/mojom/check_stable_mojom_compatibility.py\n> create mode 100755 utils/ipc/mojo/public/tools/mojom/check_stable_mojom_compatibility_unittest.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/const_unittest.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/enum_unittest.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/BUILD.gn\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/__init__.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/error.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/fileutil.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/fileutil_unittest.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/__init__.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/constant_resolver.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/generator.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/generator_unittest.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/module.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/module_unittest.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/pack.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/pack_unittest.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/template_expander.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/translate.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/translate_unittest.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/__init__.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/ast.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/ast_unittest.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/conditional_features.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/conditional_features_unittest.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer_unittest.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/parser.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/parser_unittest.py\n> create mode 100755 utils/ipc/mojo/public/tools/mojom/mojom_parser.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom_parser_test_case.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom_parser_unittest.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/stable_attribute_unittest.py\n> create mode 100644 utils/ipc/mojo/public/tools/mojom/version_compatibility_unittest.py\n> create mode 100755 utils/ipc/mojo/public/tools/run_all_python_unittests.py\n> create mode 100644 utils/ipc/tools/diagnosis/crbug_1001171.py\n\nShould BUILD.gn be dropped too ?\n\nAcked-by: Laurent Pinchart \n\nIf you have to send a new version of this series, you could omit the\nchanges from this patch, just include the changelog, as it's fairly big\notherwise.\n\n\n[snip]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2570FC3B5C\n\tfor ;\n\tTue, 29 Sep 2020 03:59:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 83571620BC;\n\tTue, 29 Sep 2020 05:59:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BCA166035E\n\tfor ;\n\tTue, 29 Sep 2020 05:59:43 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 37CDA540;\n\tTue, 29 Sep 2020 05:59:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EEWivkSL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601351983;\n\tbh=QQ8LcLhmDavQWPLO9QztaBCh9in2LHrcSXXVUKx4j54=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EEWivkSLK926jNRpiaicuQHL5/G4Mk+E5iYTDkCXhuFpJh5MpzxwSF3dfmWllBs+5\n\tkrxvzcKvvz6IORHYzaEu9AFOPmigok3fWSXVV3fJwhZdoJmnuQKVlbvHULTZ9Ub1iQ\n\tMNKIDEfLWs9udZiNBRKvooOsgDXtSsv64f4Z1Pjw=","Date":"Tue, 29 Sep 2020 06:59:08 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20200929035908.GY14614@pendragon.ideasonboard.com>","References":"<20200922133537.258098-1-paul.elder@ideasonboard.com>\n\t<20200922133537.258098-7-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200922133537.258098-7-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 06/38] utils: ipc: import mojo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12872,"web_url":"https://patchwork.libcamera.org/comment/12872/","msgid":"<20200929101016.GU45948@pyrite.rasen.tech>","date":"2020-09-29T10:10:16","subject":"Re: [libcamera-devel] [PATCH 06/38] utils: ipc: import mojo","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the review.\n\nOn Tue, Sep 29, 2020 at 06:59:08AM +0300, Laurent Pinchart wrote:\n> Hi Paul,\n> \n> Thank you for the patch.\n> \n> On Tue, Sep 22, 2020 at 10:35:05PM +0900, Paul Elder wrote:\n> > Import mojo from Chromium repository, so that we can use it for\n> > generating code for the IPC mechanism. The commit from which this was\n> > taken is:\n> > a079161ec8c6907b883f9cb84fc8c4e7896cb1d0 \"Add PPAPI constructs for\n> > sending focus object to PdfAccessibilityTree\"\n> > \n> > This tree has been pruned to remove directories that didn't have any\n> > necessary code:\n> > - mojo/* except for mojo/public\n> > - mojo core, docs, and misc files\n> > - mojo/public/* except for mojo/public/{tools,LICENSE}\n> > - language bindings for IPC, tests, and some mojo internals\n> > - mojo/public/tools/{fuzzers,chrome_ipc}\n> > - mojo/public/tools/bindings/generators\n> > - code generation for other languages\n> > \n> > No files were modified.\n> > \n> > Signed-off-by: Paul Elder \n> > \n> > ---\n> > Changes in v2:\n> > - add chromium commit id, list of pruned directories, and list of\n> > modified files to the changelog\n> \n> Has any file been modified, with the commit message stating \"no files\n> were modified\" ? :-)\n\nNo file was modified :)\n\n> > ---\n> > utils/ipc/mojo/public/LICENSE | 27 +\n> > utils/ipc/mojo/public/tools/.style.yapf | 6 +\n> > utils/ipc/mojo/public/tools/BUILD.gn | 18 +\n> > utils/ipc/mojo/public/tools/bindings/BUILD.gn | 108 +\n> > .../ipc/mojo/public/tools/bindings/README.md | 816 +++++++\n> > .../chromium_bindings_configuration.gni | 51 +\n> > .../tools/bindings/compile_typescript.py | 27 +\n> > .../tools/bindings/concatenate-files.py | 54 +\n> > ...concatenate_and_replace_closure_exports.py | 73 +\n> > .../bindings/format_typemap_generator_args.py | 36 +\n> > .../tools/bindings/gen_data_files_list.py | 52 +\n> > .../tools/bindings/generate_type_mappings.py | 187 ++\n> > .../ipc/mojo/public/tools/bindings/mojom.gni | 1941 +++++++++++++++++\n> > .../bindings/mojom_bindings_generator.py | 390 ++++\n> > .../mojom_bindings_generator_unittest.py | 62 +\n> > .../tools/bindings/mojom_types_downgrader.py | 119 +\n> > .../tools/bindings/validate_typemap_config.py | 57 +\n> > utils/ipc/mojo/public/tools/mojom/README.md | 14 +\n> > .../mojom/check_stable_mojom_compatibility.py | 170 ++\n> > ...eck_stable_mojom_compatibility_unittest.py | 260 +++\n> > .../mojo/public/tools/mojom/const_unittest.py | 90 +\n> > .../mojo/public/tools/mojom/enum_unittest.py | 92 +\n> > .../mojo/public/tools/mojom/mojom/BUILD.gn | 43 +\n> > .../mojo/public/tools/mojom/mojom/__init__.py | 0\n> > .../mojo/public/tools/mojom/mojom/error.py | 28 +\n> > .../mojo/public/tools/mojom/mojom/fileutil.py | 45 +\n> > .../tools/mojom/mojom/fileutil_unittest.py | 40 +\n> > .../tools/mojom/mojom/generate/__init__.py | 0\n> > .../mojom/mojom/generate/constant_resolver.py | 93 +\n> > .../tools/mojom/mojom/generate/generator.py | 325 +++\n> > .../mojom/generate/generator_unittest.py | 74 +\n> > .../tools/mojom/mojom/generate/module.py | 1635 ++++++++++++++\n> > .../mojom/mojom/generate/module_unittest.py | 31 +\n> > .../public/tools/mojom/mojom/generate/pack.py | 258 +++\n> > .../mojom/mojom/generate/pack_unittest.py | 225 ++\n> > .../mojom/mojom/generate/template_expander.py | 83 +\n> > .../tools/mojom/mojom/generate/translate.py | 854 ++++++++\n> > .../mojom/generate/translate_unittest.py | 73 +\n> > .../tools/mojom/mojom/parse/__init__.py | 0\n> > .../public/tools/mojom/mojom/parse/ast.py | 427 ++++\n> > .../tools/mojom/mojom/parse/ast_unittest.py | 121 +\n> > .../mojom/mojom/parse/conditional_features.py | 82 +\n> > .../parse/conditional_features_unittest.py | 233 ++\n> > .../public/tools/mojom/mojom/parse/lexer.py | 251 +++\n> > .../tools/mojom/mojom/parse/lexer_unittest.py | 198 ++\n> > .../public/tools/mojom/mojom/parse/parser.py | 488 +++++\n> > .../mojom/mojom/parse/parser_unittest.py | 1390 ++++++++++++\n> > .../mojo/public/tools/mojom/mojom_parser.py | 361 +++\n> > .../tools/mojom/mojom_parser_test_case.py | 73 +\n> > .../tools/mojom/mojom_parser_unittest.py | 171 ++\n> > .../tools/mojom/stable_attribute_unittest.py | 127 ++\n> > .../mojom/version_compatibility_unittest.py | 397 ++++\n> > .../public/tools/run_all_python_unittests.py | 28 +\n> > utils/ipc/tools/diagnosis/crbug_1001171.py | 51 +\n> > 54 files changed, 12855 insertions(+)\n> > create mode 100644 utils/ipc/mojo/public/LICENSE\n> > create mode 100644 utils/ipc/mojo/public/tools/.style.yapf\n> > create mode 100644 utils/ipc/mojo/public/tools/BUILD.gn\n> > create mode 100644 utils/ipc/mojo/public/tools/bindings/BUILD.gn\n> > create mode 100644 utils/ipc/mojo/public/tools/bindings/README.md\n> > create mode 100644 utils/ipc/mojo/public/tools/bindings/chromium_bindings_configuration.gni\n> > create mode 100644 utils/ipc/mojo/public/tools/bindings/compile_typescript.py\n> > create mode 100755 utils/ipc/mojo/public/tools/bindings/concatenate-files.py\n> > create mode 100755 utils/ipc/mojo/public/tools/bindings/concatenate_and_replace_closure_exports.py\n> > create mode 100755 utils/ipc/mojo/public/tools/bindings/format_typemap_generator_args.py\n> > create mode 100644 utils/ipc/mojo/public/tools/bindings/gen_data_files_list.py\n> > create mode 100755 utils/ipc/mojo/public/tools/bindings/generate_type_mappings.py\n> > create mode 100644 utils/ipc/mojo/public/tools/bindings/mojom.gni\n> > create mode 100755 utils/ipc/mojo/public/tools/bindings/mojom_bindings_generator.py\n> > create mode 100644 utils/ipc/mojo/public/tools/bindings/mojom_bindings_generator_unittest.py\n> > create mode 100755 utils/ipc/mojo/public/tools/bindings/mojom_types_downgrader.py\n> > create mode 100755 utils/ipc/mojo/public/tools/bindings/validate_typemap_config.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/README.md\n> > create mode 100755 utils/ipc/mojo/public/tools/mojom/check_stable_mojom_compatibility.py\n> > create mode 100755 utils/ipc/mojo/public/tools/mojom/check_stable_mojom_compatibility_unittest.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/const_unittest.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/enum_unittest.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/BUILD.gn\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/__init__.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/error.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/fileutil.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/fileutil_unittest.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/__init__.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/constant_resolver.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/generator.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/generator_unittest.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/module.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/module_unittest.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/pack.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/pack_unittest.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/template_expander.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/translate.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/translate_unittest.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/__init__.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/ast.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/ast_unittest.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/conditional_features.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/conditional_features_unittest.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/lexer_unittest.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/parser.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/parse/parser_unittest.py\n> > create mode 100755 utils/ipc/mojo/public/tools/mojom/mojom_parser.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom_parser_test_case.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom_parser_unittest.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/stable_attribute_unittest.py\n> > create mode 100644 utils/ipc/mojo/public/tools/mojom/version_compatibility_unittest.py\n> > create mode 100755 utils/ipc/mojo/public/tools/run_all_python_unittests.py\n> > create mode 100644 utils/ipc/tools/diagnosis/crbug_1001171.py\n> \n> Should BUILD.gn be dropped too ?\n\nThey could be. I didn't remove them because I thought it was easier to\ntrack removed directories and not removed files. There's no harm in\nremoving them... but also I feel like it's simpler if we don't remove\nthem.\n\n> Acked-by: Laurent Pinchart \n> \n> If you have to send a new version of this series, you could omit the\n> changes from this patch, just include the changelog, as it's fairly big\n> otherwise.\n\nack\n\n\nThanks,\n\nPaul","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 738A6C3B5C\n\tfor ;\n\tTue, 29 Sep 2020 10:10:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F231562184;\n\tTue, 29 Sep 2020 12:10:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF4726035F\n\tfor ;\n\tTue, 29 Sep 2020 12:10:25 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 77CCD9CC;\n\tTue, 29 Sep 2020 12:10:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PIxTh5mq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601374224;\n\tbh=gTEKbmvYd/84TwpE5GFN/XEvrf7UrMNWK/PquScn7HQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PIxTh5mqmW4+MXcWVgwX89eNdr5PEFvGCctIfJSe/4HF2Xw1HY9BoM4MWGPXZQIAN\n\toR6qjSDcrippGUMpIzjcaW1tnqRofr1BLDyOFPgr0i2/YLxdAw3bXNJzbzl1J9yfRn\n\t8xYoiFmJv89YzuGesSWwvxF7/mIVb1YzTydjSCRk=","Date":"Tue, 29 Sep 2020 19:10:16 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20200929101016.GU45948@pyrite.rasen.tech>","References":"<20200922133537.258098-1-paul.elder@ideasonboard.com>\n\t<20200922133537.258098-7-paul.elder@ideasonboard.com>\n\t<20200929035908.GY14614@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200929035908.GY14614@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 06/38] utils: ipc: import mojo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]