[{"id":12863,"web_url":"https://patchwork.libcamera.org/comment/12863/","msgid":"<20200929042231.GC14614@pendragon.ideasonboard.com>","date":"2020-09-29T04:22:31","subject":"Re: [libcamera-devel] [PATCH 12/38] ipa: raspberrypi: meson: Add\n\tdependency on generated headers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Tue, Sep 22, 2020 at 10:35:11PM +0900, Paul Elder wrote:\n> The raspberrypi IPA clearly depends on the generated header. Add the\n\nWhich generated header ?\n\nMaybe s/clearly depends/will depend/ as that's not the case yet in this\npatch ?\n\n> dependency. Simply add all generated headers as a dependency, instead of\n> walking the list of headers.\n\n\", to simplify the implementation. This will have the effect of\ngenerating all headers before compiling the IPA, which has no drawback.\"\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: Paul Elder \n> \n> ---\n> New in v2\n> ---\n> src/ipa/raspberrypi/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/meson.build b/src/ipa/raspberrypi/meson.build\n> index 9445cd09..27c29249 100644\n> --- a/src/ipa/raspberrypi/meson.build\n> +++ b/src/ipa/raspberrypi/meson.build\n> @@ -42,7 +42,7 @@ rpi_ipa_sources = files([\n> ])\n> \n> mod = shared_module(ipa_name,\n> - rpi_ipa_sources,\n> + [rpi_ipa_sources, libcamera_generated_headers],\n> name_prefix : '',\n> include_directories : rpi_ipa_includes,\n> dependencies : rpi_ipa_deps,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9AD66C3B5C\n\tfor ;\n\tTue, 29 Sep 2020 04:23:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F36E620BC;\n\tTue, 29 Sep 2020 06:23:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 501356035E\n\tfor ;\n\tTue, 29 Sep 2020 06:23:07 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BE17B540;\n\tTue, 29 Sep 2020 06:23:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"d6ydtzm5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601353386;\n\tbh=oHfsFl60RJ5ipWITP1mM3FGR4rboYY71nYRESL/uFaY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=d6ydtzm58TjrbwG21Q9b2V2BqV5NUEDkv8spJ+bA3w72FTBhargrnSmvs3uxKktLW\n\ts1iShYrGQrYHVOavf3+l1GH4rvDvNTARS9pMgxreh9qEizVs4NVY/RjkRKWzA1tlC0\n\tAjxLCyOoSdNVxRTm9FajRs1Sy/LTnsmFkT0GUGQY=","Date":"Tue, 29 Sep 2020 07:22:31 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20200929042231.GC14614@pendragon.ideasonboard.com>","References":"<20200922133537.258098-1-paul.elder@ideasonboard.com>\n\t<20200922133537.258098-13-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200922133537.258098-13-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 12/38] ipa: raspberrypi: meson: Add\n\tdependency on generated headers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]