[{"id":12660,"web_url":"https://patchwork.libcamera.org/comment/12660/","msgid":"<20200923104441.ho3pjlifn7iehcaq@uno.localdomain>","date":"2020-09-23T10:44:41","subject":"Re: [libcamera-devel] [PATCH 05/38] libcamera: meson: Add internal\n\theaders to sources","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Tue, Sep 22, 2020 at 10:35:04PM +0900, Paul Elder wrote:\n> Add libcamera_internal_headers to libcamera_sources.\n>\n\nFor the build-system-uneducated like me: why ?\n\n> Signed-off-by: Paul Elder \n>\n> ---\n> New in v2\n> ---\n> src/libcamera/meson.build | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 18ea3261..27182bfc 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -53,6 +53,7 @@ libcamera_sources = files([\n> ])\n>\n> libcamera_sources += libcamera_public_headers\n> +libcamera_sources += libcamera_internal_headers\n>\n> includes = [\n> libcamera_includes,\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6D833C3B5B\n\tfor ;\n\tWed, 23 Sep 2020 10:40:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4889162FE1;\n\tWed, 23 Sep 2020 12:40:50 +0200 (CEST)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB80362FD2\n\tfor ;\n\tWed, 23 Sep 2020 12:40:48 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 4AC5910000B;\n\tWed, 23 Sep 2020 10:40:47 +0000 (UTC)"],"Date":"Wed, 23 Sep 2020 12:44:41 +0200","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20200923104441.ho3pjlifn7iehcaq@uno.localdomain>","References":"<20200922133537.258098-1-paul.elder@ideasonboard.com>\n\t<20200922133537.258098-6-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200922133537.258098-6-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 05/38] libcamera: meson: Add internal\n\theaders to sources","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12671,"web_url":"https://patchwork.libcamera.org/comment/12671/","msgid":"<20200923122724.GB3980@pendragon.ideasonboard.com>","date":"2020-09-23T12:27:24","subject":"Re: [libcamera-devel] [PATCH 05/38] libcamera: meson: Add internal\n\theaders to sources","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Sep 23, 2020 at 12:44:41PM +0200, Jacopo Mondi wrote:\n> On Tue, Sep 22, 2020 at 10:35:04PM +0900, Paul Elder wrote:\n> > Add libcamera_internal_headers to libcamera_sources.\n> \n> For the build-system-uneducated like me: why ?\n\nEven if I think I know the answer, I agree with Jacopo, I think it\nshould be recorded in the commit message.\n\n> > Signed-off-by: Paul Elder \n> >\n> > ---\n> > New in v2\n> > ---\n> > src/libcamera/meson.build | 1 +\n> > 1 file changed, 1 insertion(+)\n> >\n> > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> > index 18ea3261..27182bfc 100644\n> > --- a/src/libcamera/meson.build\n> > +++ b/src/libcamera/meson.build\n> > @@ -53,6 +53,7 @@ libcamera_sources = files([\n> > ])\n> >\n> > libcamera_sources += libcamera_public_headers\n> > +libcamera_sources += libcamera_internal_headers\n> >\n> > includes = [\n> > libcamera_includes,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A7FCC3B5C\n\tfor ;\n\tWed, 23 Sep 2020 12:28:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 991B562FD2;\n\tWed, 23 Sep 2020 14:28:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B77DD60576\n\tfor ;\n\tWed, 23 Sep 2020 14:28:00 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 335072FD;\n\tWed, 23 Sep 2020 14:27:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"icquZzWr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600864077;\n\tbh=dmenRPObK/kOlyW7yIwyAB2s/rfJb3XAMDyRJ/oJS2E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=icquZzWrE5nRLYId/IE8aoxjUVN8wtJEnQIdBJ82z94m9lCdXUtEEMuXWXTdQkJNR\n\tjCm7mqMGJ7GV/Qb5XbE2kTF9oAcBevGN6dRR/PWB9ltS/hl2WouMZp35cciksiWGu/\n\tLSr5/d1psiQeX6peWnA0jf242MhTsvgnjlyJVLIM=","Date":"Wed, 23 Sep 2020 15:27:24 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200923122724.GB3980@pendragon.ideasonboard.com>","References":"<20200922133537.258098-1-paul.elder@ideasonboard.com>\n\t<20200922133537.258098-6-paul.elder@ideasonboard.com>\n\t<20200923104441.ho3pjlifn7iehcaq@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200923104441.ho3pjlifn7iehcaq@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 05/38] libcamera: meson: Add internal\n\theaders to sources","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12699,"web_url":"https://patchwork.libcamera.org/comment/12699/","msgid":"<20200924013626.GJ45948@pyrite.rasen.tech>","date":"2020-09-24T01:36:26","subject":"Re: [libcamera-devel] [PATCH 05/38] libcamera: meson: Add internal\n\theaders to sources","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Sep 23, 2020 at 03:27:24PM +0300, Laurent Pinchart wrote:\n> On Wed, Sep 23, 2020 at 12:44:41PM +0200, Jacopo Mondi wrote:\n> > On Tue, Sep 22, 2020 at 10:35:04PM +0900, Paul Elder wrote:\n> > > Add libcamera_internal_headers to libcamera_sources.\n> > \n> > For the build-system-uneducated like me: why ?\n> \n> Even if I think I know the answer, I agree with Jacopo, I think it\n> should be recorded in the commit message.\n\nI guess since I've added libcamera_generated_headers to all the meson\nfiles for the generated code, we don't actually need this patch anymore.\n\n\nPaul\n\n> > > Signed-off-by: Paul Elder \n> > >\n> > > ---\n> > > New in v2\n> > > ---\n> > > src/libcamera/meson.build | 1 +\n> > > 1 file changed, 1 insertion(+)\n> > >\n> > > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> > > index 18ea3261..27182bfc 100644\n> > > --- a/src/libcamera/meson.build\n> > > +++ b/src/libcamera/meson.build\n> > > @@ -53,6 +53,7 @@ libcamera_sources = files([\n> > > ])\n> > >\n> > > libcamera_sources += libcamera_public_headers\n> > > +libcamera_sources += libcamera_internal_headers\n> > >\n> > > includes = [\n> > > libcamera_includes,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4B955C3B5B\n\tfor ;\n\tThu, 24 Sep 2020 01:36:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6B6162FDE;\n\tThu, 24 Sep 2020 03:36:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E01F56036A\n\tfor ;\n\tThu, 24 Sep 2020 03:36:34 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1862B2FD;\n\tThu, 24 Sep 2020 03:36:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DujFbjma\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600911394;\n\tbh=6l8qkNlhGeQ+HZthXIdg0/quoP+pXXW+jeLh4f0b1lo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DujFbjmanyByaIaNq1AOG2P+YtKP98hvocJwVxjM/AkcaYtAHBKBOzzZEREFvzcDd\n\twqHomhnPVmV7q1uUIrBqZlAC54XakaG0NjwV6ClCe0HYFKSp5obpJ0/oBHND1FKYwH\n\tFr4/wuBcQ8hvXEDjtuLweMoBwv24azt4voOEtUM8=","Date":"Thu, 24 Sep 2020 10:36:26 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20200924013626.GJ45948@pyrite.rasen.tech>","References":"<20200922133537.258098-1-paul.elder@ideasonboard.com>\n\t<20200922133537.258098-6-paul.elder@ideasonboard.com>\n\t<20200923104441.ho3pjlifn7iehcaq@uno.localdomain>\n\t<20200923122724.GB3980@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200923122724.GB3980@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 05/38] libcamera: meson: Add internal\n\theaders to sources","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]