[{"id":12659,"web_url":"https://patchwork.libcamera.org/comment/12659/","msgid":"<20200923104409.2npxxarw2a7jojxz@uno.localdomain>","date":"2020-09-23T10:44:09","subject":"Re: [libcamera-devel] [PATCH 04/38] libcamera: process:\n\tforward-declare EventNotifier","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Tue, Sep 22, 2020 at 10:35:03PM +0900, Paul Elder wrote:\n> EventNotifier is not included; forward-declare it to satisfy the\n> compiler\n>\n\nWhere is it needed ? I don't see it used in process.h\n\n> Signed-off-by: Paul Elder \n>\n> ---\n> New in v2\n> ---\n> include/libcamera/internal/process.h | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h\n> index 458a2149..254cda85 100644\n> --- a/include/libcamera/internal/process.h\n> +++ b/include/libcamera/internal/process.h\n> @@ -15,6 +15,8 @@\n>\n> namespace libcamera {\n>\n> +class EventNotifier;\n> +\n> class Process final\n> {\n> public:\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A57DC3B5B\n\tfor ;\n\tWed, 23 Sep 2020 10:40:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18E3562FE1;\n\tWed, 23 Sep 2020 12:40:18 +0200 (CEST)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 79BFC62FD2\n\tfor ;\n\tWed, 23 Sep 2020 12:40:16 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 079B32000E;\n\tWed, 23 Sep 2020 10:40:15 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 23 Sep 2020 12:44:09 +0200","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20200923104409.2npxxarw2a7jojxz@uno.localdomain>","References":"<20200922133537.258098-1-paul.elder@ideasonboard.com>\n\t<20200922133537.258098-5-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200922133537.258098-5-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 04/38] libcamera: process:\n\tforward-declare EventNotifier","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12695,"web_url":"https://patchwork.libcamera.org/comment/12695/","msgid":"<20200924005231.GH45948@pyrite.rasen.tech>","date":"2020-09-24T00:52:31","subject":"Re: [libcamera-devel] [PATCH 04/38] libcamera: process:\n\tforward-declare EventNotifier","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Wed, Sep 23, 2020 at 12:44:09PM +0200, Jacopo Mondi wrote:\n> Hi Paul,\n> \n> On Tue, Sep 22, 2020 at 10:35:03PM +0900, Paul Elder wrote:\n> > EventNotifier is not included; forward-declare it to satisfy the\n> > compiler\n> >\n> \n> Where is it needed ? I don't see it used in process.h\n\nLine 71:\n\tvoid sighandler(EventNotifier *notifier);\n\nLine 76:\n\tEventNotifier *sigEvent_;\n\n> > Signed-off-by: Paul Elder \n> >\n> > ---\n> > New in v2\n> > ---\n> > include/libcamera/internal/process.h | 2 ++\n> > 1 file changed, 2 insertions(+)\n> >\n> > diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h\n> > index 458a2149..254cda85 100644\n> > --- a/include/libcamera/internal/process.h\n> > +++ b/include/libcamera/internal/process.h\n> > @@ -15,6 +15,8 @@\n> >\n> > namespace libcamera {\n> >\n> > +class EventNotifier;\n> > +\n> > class Process final\n> > {\n> > public:\n> > --\n> > 2.27.0\n\n\nPaul","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11E55C3B5C\n\tfor ;\n\tThu, 24 Sep 2020 00:52:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 919B962FDE;\n\tThu, 24 Sep 2020 02:52:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 912176036A\n\tfor ;\n\tThu, 24 Sep 2020 02:52:38 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 03CF33B;\n\tThu, 24 Sep 2020 02:52:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vPm8Unof\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600908758;\n\tbh=BkZ9ZEYAVhgMopaJMKMEqO2qPmWn31Er6ZCOm4aeWXY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vPm8UnofcQPq9+dvNtqeE3W3ZcwEGR6yY7+ldZgKLgtUGtq/tH/L7/ioeAGQIl5BO\n\tA5IYQLL+dZOGAEIIW2RjlBYgF5YFsc4IUC+mZfjIiaE++0pqrnmDJqF3HtrstTWote\n\tLwr6m+hBaf30PFWWYl61f03BHdQsdbsFSvzpTT+0=","Date":"Thu, 24 Sep 2020 09:52:31 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20200924005231.GH45948@pyrite.rasen.tech>","References":"<20200922133537.258098-1-paul.elder@ideasonboard.com>\n\t<20200922133537.258098-5-paul.elder@ideasonboard.com>\n\t<20200923104409.2npxxarw2a7jojxz@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200923104409.2npxxarw2a7jojxz@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 04/38] libcamera: process:\n\tforward-declare EventNotifier","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12698,"web_url":"https://patchwork.libcamera.org/comment/12698/","msgid":"<20200924011402.GI3980@pendragon.ideasonboard.com>","date":"2020-09-24T01:14:02","subject":"Re: [libcamera-devel] [PATCH 04/38] libcamera: process:\n\tforward-declare EventNotifier","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Sep 24, 2020 at 09:52:31AM +0900, paul.elder@ideasonboard.com wrote:\n> Hi Jacopo,\n> \n> On Wed, Sep 23, 2020 at 12:44:09PM +0200, Jacopo Mondi wrote:\n> > Hi Paul,\n> > \n> > On Tue, Sep 22, 2020 at 10:35:03PM +0900, Paul Elder wrote:\n> > > EventNotifier is not included; forward-declare it to satisfy the\n> > > compiler\n> > >\n> > \n> > Where is it needed ? I don't see it used in process.h\n> \n> Line 71:\n> \tvoid sighandler(EventNotifier *notifier);\n> \n> Line 76:\n> \tEventNotifier *sigEvent_;\n\nThat's only after moving ProcessManager to process.h though. You should\nsquash this change with 02/38.\n\n> > > Signed-off-by: Paul Elder \n> > >\n> > > ---\n> > > New in v2\n> > > ---\n> > > include/libcamera/internal/process.h | 2 ++\n> > > 1 file changed, 2 insertions(+)\n> > >\n> > > diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h\n> > > index 458a2149..254cda85 100644\n> > > --- a/include/libcamera/internal/process.h\n> > > +++ b/include/libcamera/internal/process.h\n> > > @@ -15,6 +15,8 @@\n> > >\n> > > namespace libcamera {\n> > >\n> > > +class EventNotifier;\n> > > +\n> > > class Process final\n> > > {\n> > > public:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3A805C3B5C\n\tfor ;\n\tThu, 24 Sep 2020 01:14:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC50162FDE;\n\tThu, 24 Sep 2020 03:14:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 748346036A\n\tfor ;\n\tThu, 24 Sep 2020 03:14:36 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E29DF27B;\n\tThu, 24 Sep 2020 03:14:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Li1PZthy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600910076;\n\tbh=PF/zGmbuppK2gCMdkjjAf5wIhdFGhOu5B3mf65PVz8s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Li1PZthyQTM6K4XkZa1r6xt3SNusJN/JteTJmP+y5EkQ/CgxY0addBdDfI7HUkLlt\n\tU+1mLg67uvxVhk8Nn/eKKiTNGbvwc1BWvuLuL5m4uoHnivSESK75Q3VdEpgKXwbyfa\n\tEgWTli+s5jdVVbWP1A8w1ljKE0L1bXIobToji5Ng=","Date":"Thu, 24 Sep 2020 04:14:02 +0300","From":"Laurent Pinchart ","To":"paul.elder@ideasonboard.com","Message-ID":"<20200924011402.GI3980@pendragon.ideasonboard.com>","References":"<20200922133537.258098-1-paul.elder@ideasonboard.com>\n\t<20200922133537.258098-5-paul.elder@ideasonboard.com>\n\t<20200923104409.2npxxarw2a7jojxz@uno.localdomain>\n\t<20200924005231.GH45948@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200924005231.GH45948@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH 04/38] libcamera: process:\n\tforward-declare EventNotifier","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12718,"web_url":"https://patchwork.libcamera.org/comment/12718/","msgid":"<20200924100213.hxako76drnp5sqqf@uno.localdomain>","date":"2020-09-24T10:02:13","subject":"Re: [libcamera-devel] [PATCH 04/38] libcamera: process:\n\tforward-declare EventNotifier","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul, Laurent\n\nOn Thu, Sep 24, 2020 at 04:14:02AM +0300, Laurent Pinchart wrote:\n> On Thu, Sep 24, 2020 at 09:52:31AM +0900, paul.elder@ideasonboard.com wrote:\n> > Hi Jacopo,\n> >\n> > On Wed, Sep 23, 2020 at 12:44:09PM +0200, Jacopo Mondi wrote:\n> > > Hi Paul,\n> > >\n> > > On Tue, Sep 22, 2020 at 10:35:03PM +0900, Paul Elder wrote:\n> > > > EventNotifier is not included; forward-declare it to satisfy the\n> > > > compiler\n> > > >\n> > >\n> > > Where is it needed ? I don't see it used in process.h\n> >\n> > Line 71:\n> > \tvoid sighandler(EventNotifier *notifier);\n> >\n> > Line 76:\n> > \tEventNotifier *sigEvent_;\n>\n> That's only after moving ProcessManager to process.h though. You should\n> squash this change with 02/38.\n>\n\nAh yes, I indeed missed that!\nWith the patch squashed\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> > > > Signed-off-by: Paul Elder \n> > > >\n> > > > ---\n> > > > New in v2\n> > > > ---\n> > > > include/libcamera/internal/process.h | 2 ++\n> > > > 1 file changed, 2 insertions(+)\n> > > >\n> > > > diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h\n> > > > index 458a2149..254cda85 100644\n> > > > --- a/include/libcamera/internal/process.h\n> > > > +++ b/include/libcamera/internal/process.h\n> > > > @@ -15,6 +15,8 @@\n> > > >\n> > > > namespace libcamera {\n> > > >\n> > > > +class EventNotifier;\n> > > > +\n> > > > class Process final\n> > > > {\n> > > > public:\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F008AC3B5B\n\tfor ;\n\tThu, 24 Sep 2020 09:58:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A0E762FF5;\n\tThu, 24 Sep 2020 11:58:24 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51F5D60367\n\tfor ;\n\tThu, 24 Sep 2020 11:58:22 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 46028E000E;\n\tThu, 24 Sep 2020 09:58:20 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Thu, 24 Sep 2020 12:02:13 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20200924100213.hxako76drnp5sqqf@uno.localdomain>","References":"<20200922133537.258098-1-paul.elder@ideasonboard.com>\n\t<20200922133537.258098-5-paul.elder@ideasonboard.com>\n\t<20200923104409.2npxxarw2a7jojxz@uno.localdomain>\n\t<20200924005231.GH45948@pyrite.rasen.tech>\n\t<20200924011402.GI3980@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200924011402.GI3980@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 04/38] libcamera: process:\n\tforward-declare EventNotifier","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]