[{"id":12658,"web_url":"https://patchwork.libcamera.org/comment/12658/","msgid":"<20200923104115.jh35zvyld7yniv5h@uno.localdomain>","date":"2020-09-23T10:41:15","subject":"Re: [libcamera-devel] [PATCH 03/38] libcamera: PipelineHandler:\n\tMove printing pipeline names to CameraManager","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Tue, Sep 22, 2020 at 10:35:02PM +0900, Paul Elder wrote:\n> Since pipeline registration is done with declaring static factory\n> objects, there is a risk that pipeline factories will be constructed\n> before libcamera facilities are ready. For example, logging in the\n> constructor of a pipeline handler factory may cause a segfault if\n> threading isn't ready yet. Avoid this issue by moving printing the\n> registration of the pipeline handler to the camera manager.\n\nDid you ever see this happening ?\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> ---\n> Cosmetic changes in v2\n> ---\n> src/libcamera/camera_manager.cpp | 3 +++\n> src/libcamera/pipeline_handler.cpp | 3 ---\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index b8d3ccc8..756f5b2b 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -142,6 +142,9 @@ void CameraManager::Private::createPipelineHandlers()\n> \t\tPipelineHandlerFactory::factories();\n>\n> \tfor (PipelineHandlerFactory *factory : factories) {\n> +\t\tLOG(Camera, Debug)\n> +\t\t\t<< \"Found registered pipeline handler '\"\n> +\t\t\t<< factory->name() << \"'\";\n> \t\t/*\n> \t\t * Try each pipeline handler until it exhaust\n> \t\t * all pipelines it can provide.\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 918aea1e..894200ee 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -689,9 +689,6 @@ void PipelineHandlerFactory::registerType(PipelineHandlerFactory *factory)\n> \tstd::vector &factories = PipelineHandlerFactory::factories();\n>\n> \tfactories.push_back(factory);\n> -\n> -\tLOG(Pipeline, Debug)\n> -\t\t<< \"Registered pipeline handler \\\"\" << factory->name() << \"\\\"\";\n> }\n>\n> /**\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E73A7C3B5B\n\tfor ;\n\tWed, 23 Sep 2020 10:37:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 591BA62FE1;\n\tWed, 23 Sep 2020 12:37:25 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6CC1962FD2\n\tfor ;\n\tWed, 23 Sep 2020 12:37:23 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id E8621FF805;\n\tWed, 23 Sep 2020 10:37:22 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 23 Sep 2020 12:41:15 +0200","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20200923104115.jh35zvyld7yniv5h@uno.localdomain>","References":"<20200922133537.258098-1-paul.elder@ideasonboard.com>\n\t<20200922133537.258098-4-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200922133537.258098-4-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 03/38] libcamera: PipelineHandler:\n\tMove printing pipeline names to CameraManager","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12696,"web_url":"https://patchwork.libcamera.org/comment/12696/","msgid":"<20200924005338.GI45948@pyrite.rasen.tech>","date":"2020-09-24T00:53:38","subject":"Re: [libcamera-devel] [PATCH 03/38] libcamera: PipelineHandler:\n\tMove printing pipeline names to CameraManager","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Wed, Sep 23, 2020 at 12:41:15PM +0200, Jacopo Mondi wrote:\n> Hi Paul,\n> \n> On Tue, Sep 22, 2020 at 10:35:02PM +0900, Paul Elder wrote:\n> > Since pipeline registration is done with declaring static factory\n> > objects, there is a risk that pipeline factories will be constructed\n> > before libcamera facilities are ready. For example, logging in the\n> > constructor of a pipeline handler factory may cause a segfault if\n> > threading isn't ready yet. Avoid this issue by moving printing the\n> > registration of the pipeline handler to the camera manager.\n> \n> Did you ever see this happening ?\n\nYes, this did actually happen...\n\n> > Signed-off-by: Paul Elder \n> > Reviewed-by: Laurent Pinchart \n> \n> Reviewed-by: Jacopo Mondi \n\n\nThanks,\n\nPaul\n\n> >\n> > ---\n> > Cosmetic changes in v2\n> > ---\n> > src/libcamera/camera_manager.cpp | 3 +++\n> > src/libcamera/pipeline_handler.cpp | 3 ---\n> > 2 files changed, 3 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> > index b8d3ccc8..756f5b2b 100644\n> > --- a/src/libcamera/camera_manager.cpp\n> > +++ b/src/libcamera/camera_manager.cpp\n> > @@ -142,6 +142,9 @@ void CameraManager::Private::createPipelineHandlers()\n> > \t\tPipelineHandlerFactory::factories();\n> >\n> > \tfor (PipelineHandlerFactory *factory : factories) {\n> > +\t\tLOG(Camera, Debug)\n> > +\t\t\t<< \"Found registered pipeline handler '\"\n> > +\t\t\t<< factory->name() << \"'\";\n> > \t\t/*\n> > \t\t * Try each pipeline handler until it exhaust\n> > \t\t * all pipelines it can provide.\n> > diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> > index 918aea1e..894200ee 100644\n> > --- a/src/libcamera/pipeline_handler.cpp\n> > +++ b/src/libcamera/pipeline_handler.cpp\n> > @@ -689,9 +689,6 @@ void PipelineHandlerFactory::registerType(PipelineHandlerFactory *factory)\n> > \tstd::vector &factories = PipelineHandlerFactory::factories();\n> >\n> > \tfactories.push_back(factory);\n> > -\n> > -\tLOG(Pipeline, Debug)\n> > -\t\t<< \"Registered pipeline handler \\\"\" << factory->name() << \"\\\"\";\n> > }\n> >\n> > /**\n> > --\n> > 2.27.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81159C3B5C\n\tfor ;\n\tThu, 24 Sep 2020 00:53:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4EB7562FDE;\n\tThu, 24 Sep 2020 02:53:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 931436036A\n\tfor ;\n\tThu, 24 Sep 2020 02:53:46 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 237653B;\n\tThu, 24 Sep 2020 02:53:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AgXfatqo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600908826;\n\tbh=ocpDbpGk5I/jSEi937ECULXBExPDZvpoz204syVUSsk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=AgXfatqoesIHGXuGnugsjraOhw6LGaF26yb4N9RnWqLi5L5h3UEhV1vadeo3S8Ijd\n\tytnw58tuESJBxMP/zBOQ6nbrl+VRs0p+80X9Qx5GcjVqsha8FBOigxEIT1bV7FHNEn\n\tHjqyymiD6j37O2a6zQ+uT4fdNPZztjfNCWMAecfw=","Date":"Thu, 24 Sep 2020 09:53:38 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20200924005338.GI45948@pyrite.rasen.tech>","References":"<20200922133537.258098-1-paul.elder@ideasonboard.com>\n\t<20200922133537.258098-4-paul.elder@ideasonboard.com>\n\t<20200923104115.jh35zvyld7yniv5h@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200923104115.jh35zvyld7yniv5h@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 03/38] libcamera: PipelineHandler:\n\tMove printing pipeline names to CameraManager","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]