[{"id":12652,"web_url":"https://patchwork.libcamera.org/comment/12652/","msgid":"<20200923081835.nsa3qybkk7jvhvp4@uno.localdomain>","date":"2020-09-23T08:18:35","subject":"Re: [libcamera-devel] [PATCH 1/6] libcamera: Add SensorOutputSize\n\tproperty","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi David,\n\nOn Tue, Sep 22, 2020 at 11:03:55AM +0100, David Plowman wrote:\n> The SensorOutputSize camera property reports the image size that the\n> next step in processing after the sensor and CSI-2 receiver - usually\n> the ISP - will see. It will normally change when a new camera mode is\n> selected, and can be used to implement digital zoom.\n>\n> Signed-off-by: David Plowman \n> ---\n> src/libcamera/property_ids.yaml | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)\n>\n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index 74ad019..c185549 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -640,4 +640,16 @@ controls:\n> \\todo Rename this property to ActiveAreas once we will have property\n> categories (i.e. Properties::PixelArray::ActiveAreas)\n>\n> + - SensorOutputSize:\n> + type: Size\n> + description: |\n> + The size, in pixels, of the image being used to produce the\n> + desired output streams. The image size might correspond to the\n> + size of the frames produced by the image sensor but would also\n> + take into account additional cropping (or even re-scaling)\n> + performed by the CSI-2 receiver to adjust the sensor frame\n> + size to conform to the output image sizes and aspect ratios.\n> + Note that this property changes with every newly selected\n> + camera mode. It can be used to implement digital zoom.\n> +\n\nLooks good to me. As we now have ISPCrop I wonder if naming this\nISPInputSize would make it clear that this property reports the size\nof the frames after the CSI-2 receiver crop/re-scale and not the size\nof the frame transmitted on the bus by the sensor. Am I overthinking\nthis ? I would also record with a \\todo this has to be moved, but this\ncan be done when applying the patch.\n\nLet's wait for others' opinions, naming apart this is fine!\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ...\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DD42DC3B5B\n\tfor ;\n\tWed, 23 Sep 2020 08:14:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4668C62FDC;\n\tWed, 23 Sep 2020 10:14:45 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E169D60363\n\tfor ;\n\tWed, 23 Sep 2020 10:14:43 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id BCF93240009;\n\tWed, 23 Sep 2020 08:14:42 +0000 (UTC)"],"Date":"Wed, 23 Sep 2020 10:18:35 +0200","From":"Jacopo Mondi ","To":"David Plowman ","Message-ID":"<20200923081835.nsa3qybkk7jvhvp4@uno.localdomain>","References":"<20200922100400.30766-1-david.plowman@raspberrypi.com>\n\t<20200922100400.30766-2-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200922100400.30766-2-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 1/6] libcamera: Add SensorOutputSize\n\tproperty","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]