[{"id":12748,"web_url":"https://patchwork.libcamera.org/comment/12748/","msgid":"<4b5467a1-0f59-f57e-055c-ef84f7a43d1e@ideasonboard.com>","date":"2020-09-24T16:10:23","subject":"Re: [libcamera-devel] [PATCH v3 8/8] android: camera_device: Add\n\tstream mapping log","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 22/09/2020 10:47, Jacopo Mondi wrote:\n> To ease following how Android stream gets mapped onto libcamera ones\n> add a (quite verbose) printout before queueing a request to libcamera.\n> \n> The output looks like:\n> 0 - (320x240)[0x00000022] -> (320x240)[NV12] (direct)\n> 1 - (640x480)[0x00000021] -> (640x480)[NV12] (internal)\n\nExcellent, - that's definitely helpful.\n\n> \n> Reviewed-by: Hirokazu Honda \n> Reviewed-by: Niklas Söderlund \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_device.cpp | 15 ++++++++++++++-\n> 1 file changed, 14 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 1b35c72a3de6..316d8293843f 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1474,9 +1474,12 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> \tRequest *request =\n> \t\tcamera_->createRequest(reinterpret_cast(descriptor));\n> \n> +\tLOG(HAL, Debug) << \"Queueing Request to libcamera with \"\n> +\t\t\t<< descriptor->numBuffers << \" streams\";\n\nThis doesn't feel right. You're counting the number of android buffers\nto state the number streams being 'queued' to libcamera.\n\nIn the event that one libcamera stream is shared (i.e. say a JPEG\nencode) to generate two android streams, this would be wrong.\n\n\n\n> \tfor (unsigned int i = 0; i < descriptor->numBuffers; ++i) {\n> +\t\tcamera3_stream *camera3Stream = camera3Buffers[i].stream;\n> \t\tCameraStream *cameraStream =\n> -\t\t\tstatic_cast(camera3Buffers[i].stream->priv);\n> +\t\t\tstatic_cast(camera3Stream->priv);\n> \t\tconst StreamConfiguration &config = config_->at(cameraStream->index());\n> \t\tStream *stream = config.stream();\n> \n> @@ -1487,6 +1490,13 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> \t\tdescriptor->buffers[i].stream = camera3Buffers[i].stream;\n> \t\tdescriptor->buffers[i].buffer = camera3Buffers[i].buffer;\n> \n> +\t\tstd::stringstream ss;\n> +\t\tss << i << \" - (\"\n> +\t\t << camera3Stream->width << \"x\" << camera3Stream->height << \")\"\n> +\t\t << \"[\" << utils::hex(camera3Stream->format) << \"] -> \"\n\nWe should really add a string mapping for this format ... 21 ... 20 ...\nthey're not great for following what's been chosen.\n\nStill, that's it's own patch outright and separate to this I guess.\n\n\n> +\t\t << \"(\" << config.size.toString() << \")[\"\n> +\t\t << config.pixelFormat.toString() << \"]\";\n> +\n> \t\t/*\n> \t\t * Inspect the camera stream type, create buffers opportunely\n> \t\t * and add them to the Request if required.\n> @@ -1498,6 +1508,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> \t\t\t * Mapped streams don't need buffers added to the\n> \t\t\t * Request.\n> \t\t\t */\n> +\t\t\tLOG(HAL, Debug) << ss.str() << \" (mapped)\";\n> \t\t\tcontinue;\n> \n> \t\tcase CameraStream::Type::Direct:\n> @@ -1509,6 +1520,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> \t\t\t */\n> \t\t\tbuffer = createFrameBuffer(*camera3Buffers[i].buffer);\n> \t\t\tdescriptor->frameBuffers.emplace_back(buffer);\n> +\t\t\tLOG(HAL, Debug) << ss.str() << \" (direct)\";\n> \t\t\tbreak;\n> \n> \t\tcase CameraStream::Type::Internal:\n> @@ -1522,6 +1534,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> \t\t\t * allocator once it has been processed.\n> \t\t\t */\n> \t\t\tbuffer = getBuffer(stream);\n> +\t\t\tLOG(HAL, Debug) << ss.str() << \" (internal)\";\n> \t\t\tbreak;\n> \t\t}\n> \t\tif (!buffer) {\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D184C3B5B\n\tfor ;\n\tThu, 24 Sep 2020 16:10:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10D2062FE3;\n\tThu, 24 Sep 2020 18:10:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CB0860363\n\tfor ;\n\tThu, 24 Sep 2020 18:10:28 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DFB712FD;\n\tThu, 24 Sep 2020 18:10:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l7ScKw0c\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600963827;\n\tbh=4Mpm+bbiyFkni/W7hDvxbftCqnDGqMqDaCGW/CHXxiA=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=l7ScKw0cB6MV+KByKTPiqT/G6vPXy9h1tgdT1xIXPZF/YeZ0gHzzmMWgqJzQ9WgOG\n\tT94WL8qeCSkuE3TzQqXp/fuv2rN/yIged50OIrvAP1qPnZShGg2twdHM+QW3JEXJqX\n\t8VZ6Vi/5p1k8V35yoqyzfwEmcRsdA11sFdHMrz2U=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20200922094738.5327-1-jacopo@jmondi.org>\n\t<20200922094738.5327-9-jacopo@jmondi.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<4b5467a1-0f59-f57e-055c-ef84f7a43d1e@ideasonboard.com>","Date":"Thu, 24 Sep 2020 17:10:23 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200922094738.5327-9-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v3 8/8] android: camera_device: Add\n\tstream mapping log","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"hanlinchen@chromium.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12749,"web_url":"https://patchwork.libcamera.org/comment/12749/","msgid":"<20200924162615.gcjpler55j33b4ba@uno.localdomain>","date":"2020-09-24T16:26:15","subject":"Re: [libcamera-devel] [PATCH v3 8/8] android: camera_device: Add\n\tstream mapping log","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran\n\nOn Thu, Sep 24, 2020 at 05:10:23PM +0100, Kieran Bingham wrote:\n> Hi Jacopo,\n>\n> On 22/09/2020 10:47, Jacopo Mondi wrote:\n> > To ease following how Android stream gets mapped onto libcamera ones\n> > add a (quite verbose) printout before queueing a request to libcamera.\n> >\n> > The output looks like:\n> > 0 - (320x240)[0x00000022] -> (320x240)[NV12] (direct)\n> > 1 - (640x480)[0x00000021] -> (640x480)[NV12] (internal)\n>\n> Excellent, - that's definitely helpful.\n>\n> >\n> > Reviewed-by: Hirokazu Honda \n> > Reviewed-by: Niklas Söderlund \n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/android/camera_device.cpp | 15 ++++++++++++++-\n> > 1 file changed, 14 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 1b35c72a3de6..316d8293843f 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -1474,9 +1474,12 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> > \tRequest *request =\n> > \t\tcamera_->createRequest(reinterpret_cast(descriptor));\n> >\n> > +\tLOG(HAL, Debug) << \"Queueing Request to libcamera with \"\n> > +\t\t\t<< descriptor->numBuffers << \" streams\";\n>\n> This doesn't feel right. You're counting the number of android buffers\n> to state the number streams being 'queued' to libcamera.\n\n'android buffers' is actually the number of output streams requested\nby android\n\n>\n> In the event that one libcamera stream is shared (i.e. say a JPEG\n> encode) to generate two android streams, this would be wrong.\n\nIsn't this intended ? I do expect something like\n\nQueueing Request to libcamera with 3 streams\n 0 - (4160x3104)[0x00000023] -> (4160x3104)[NV12] (direct)\n 1 - (4160x3104)[0x00000023] -> (4160x3104)[NV12] (external)\n 2 - (4160x3104)[0x00000023] -> (4160x3104)[NV12] (mapped)\n\nAnyway, we cycle on descriptor->numBuffers, and that's what was\nintended to be print out..\n\n>\n>\n>\n> > \tfor (unsigned int i = 0; i < descriptor->numBuffers; ++i) {\n> > +\t\tcamera3_stream *camera3Stream = camera3Buffers[i].stream;\n> > \t\tCameraStream *cameraStream =\n> > -\t\t\tstatic_cast(camera3Buffers[i].stream->priv);\n> > +\t\t\tstatic_cast(camera3Stream->priv);\n> > \t\tconst StreamConfiguration &config = config_->at(cameraStream->index());\n> > \t\tStream *stream = config.stream();\n> >\n> > @@ -1487,6 +1490,13 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> > \t\tdescriptor->buffers[i].stream = camera3Buffers[i].stream;\n> > \t\tdescriptor->buffers[i].buffer = camera3Buffers[i].buffer;\n> >\n> > +\t\tstd::stringstream ss;\n> > +\t\tss << i << \" - (\"\n> > +\t\t << camera3Stream->width << \"x\" << camera3Stream->height << \")\"\n> > +\t\t << \"[\" << utils::hex(camera3Stream->format) << \"] -> \"\n>\n> We should really add a string mapping for this format ... 21 ... 20 ...\n> they're not great for following what's been chosen.\n>\n> Still, that's it's own patch outright and separate to this I guess.\n>\n>\n> > +\t\t << \"(\" << config.size.toString() << \")[\"\n> > +\t\t << config.pixelFormat.toString() << \"]\";\n> > +\n> > \t\t/*\n> > \t\t * Inspect the camera stream type, create buffers opportunely\n> > \t\t * and add them to the Request if required.\n> > @@ -1498,6 +1508,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> > \t\t\t * Mapped streams don't need buffers added to the\n> > \t\t\t * Request.\n> > \t\t\t */\n> > +\t\t\tLOG(HAL, Debug) << ss.str() << \" (mapped)\";\n> > \t\t\tcontinue;\n> >\n> > \t\tcase CameraStream::Type::Direct:\n> > @@ -1509,6 +1520,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> > \t\t\t */\n> > \t\t\tbuffer = createFrameBuffer(*camera3Buffers[i].buffer);\n> > \t\t\tdescriptor->frameBuffers.emplace_back(buffer);\n> > +\t\t\tLOG(HAL, Debug) << ss.str() << \" (direct)\";\n> > \t\t\tbreak;\n> >\n> > \t\tcase CameraStream::Type::Internal:\n> > @@ -1522,6 +1534,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> > \t\t\t * allocator once it has been processed.\n> > \t\t\t */\n> > \t\t\tbuffer = getBuffer(stream);\n> > +\t\t\tLOG(HAL, Debug) << ss.str() << \" (internal)\";\n> > \t\t\tbreak;\n> > \t\t}\n> > \t\tif (!buffer) {\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6617C3B5C\n\tfor ;\n\tThu, 24 Sep 2020 16:22:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6B7EB62FE3;\n\tThu, 24 Sep 2020 18:22:24 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F53C60363\n\tfor ;\n\tThu, 24 Sep 2020 18:22:23 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id CBD69E000D;\n\tThu, 24 Sep 2020 16:22:22 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Thu, 24 Sep 2020 18:26:15 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20200924162615.gcjpler55j33b4ba@uno.localdomain>","References":"<20200922094738.5327-1-jacopo@jmondi.org>\n\t<20200922094738.5327-9-jacopo@jmondi.org>\n\t<4b5467a1-0f59-f57e-055c-ef84f7a43d1e@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<4b5467a1-0f59-f57e-055c-ef84f7a43d1e@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 8/8] android: camera_device: Add\n\tstream mapping log","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12752,"web_url":"https://patchwork.libcamera.org/comment/12752/","msgid":"","date":"2020-09-24T16:29:44","subject":"Re: [libcamera-devel] [PATCH v3 8/8] android: camera_device: Add\n\tstream mapping log","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 24/09/2020 17:26, Jacopo Mondi wrote:\n> Hi Kieran\n> \n> On Thu, Sep 24, 2020 at 05:10:23PM +0100, Kieran Bingham wrote:\n>> Hi Jacopo,\n>>\n>> On 22/09/2020 10:47, Jacopo Mondi wrote:\n>>> To ease following how Android stream gets mapped onto libcamera ones\n>>> add a (quite verbose) printout before queueing a request to libcamera.\n>>>\n>>> The output looks like:\n>>> 0 - (320x240)[0x00000022] -> (320x240)[NV12] (direct)\n>>> 1 - (640x480)[0x00000021] -> (640x480)[NV12] (internal)\n>>\n>> Excellent, - that's definitely helpful.\n>>\n>>>\n>>> Reviewed-by: Hirokazu Honda \n>>> Reviewed-by: Niklas Söderlund \n>>> Signed-off-by: Jacopo Mondi \n>>> ---\n>>> src/android/camera_device.cpp | 15 ++++++++++++++-\n>>> 1 file changed, 14 insertions(+), 1 deletion(-)\n>>>\n>>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n>>> index 1b35c72a3de6..316d8293843f 100644\n>>> --- a/src/android/camera_device.cpp\n>>> +++ b/src/android/camera_device.cpp\n>>> @@ -1474,9 +1474,12 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n>>> \tRequest *request =\n>>> \t\tcamera_->createRequest(reinterpret_cast(descriptor));\n>>>\n>>> +\tLOG(HAL, Debug) << \"Queueing Request to libcamera with \"\n>>> +\t\t\t<< descriptor->numBuffers << \" streams\";\n>>\n>> This doesn't feel right. You're counting the number of android buffers\n>> to state the number streams being 'queued' to libcamera.\n> \n> 'android buffers' is actually the number of output streams requested\n> by android\n> \n>>\n>> In the event that one libcamera stream is shared (i.e. say a JPEG\n>> encode) to generate two android streams, this would be wrong.\n> \n> Isn't this intended ? I do expect something like\n> \n> Queueing Request to libcamera with 3 streams\n> 0 - (4160x3104)[0x00000023] -> (4160x3104)[NV12] (direct)\n> 1 - (4160x3104)[0x00000023] -> (4160x3104)[NV12] (external)\n> 2 - (4160x3104)[0x00000023] -> (4160x3104)[NV12] (mapped)\n> \n> Anyway, we cycle on descriptor->numBuffers, and that's what was\n> intended to be print out..\n\n\nIt's confusing because - how many streams are there in the libcamera\nrequest... (I don't believe it's 3?)\n\nMaybe you could fix it by saying instead:\n\n\"Queuing Request to libcamera to satisfy 3 streams\"...\nBut the request going to libcamera - does not have 3 streams still - so\nit just sounds odd.\n\n--\nK\n\n> \n>>\n>>\n>>\n>>> \tfor (unsigned int i = 0; i < descriptor->numBuffers; ++i) {\n>>> +\t\tcamera3_stream *camera3Stream = camera3Buffers[i].stream;\n>>> \t\tCameraStream *cameraStream =\n>>> -\t\t\tstatic_cast(camera3Buffers[i].stream->priv);\n>>> +\t\t\tstatic_cast(camera3Stream->priv);\n>>> \t\tconst StreamConfiguration &config = config_->at(cameraStream->index());\n>>> \t\tStream *stream = config.stream();\n>>>\n>>> @@ -1487,6 +1490,13 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n>>> \t\tdescriptor->buffers[i].stream = camera3Buffers[i].stream;\n>>> \t\tdescriptor->buffers[i].buffer = camera3Buffers[i].buffer;\n>>>\n>>> +\t\tstd::stringstream ss;\n>>> +\t\tss << i << \" - (\"\n>>> +\t\t << camera3Stream->width << \"x\" << camera3Stream->height << \")\"\n>>> +\t\t << \"[\" << utils::hex(camera3Stream->format) << \"] -> \"\n>>\n>> We should really add a string mapping for this format ... 21 ... 20 ...\n>> they're not great for following what's been chosen.\n>>\n>> Still, that's it's own patch outright and separate to this I guess.\n>>\n>>\n>>> +\t\t << \"(\" << config.size.toString() << \")[\"\n>>> +\t\t << config.pixelFormat.toString() << \"]\";\n>>> +\n>>> \t\t/*\n>>> \t\t * Inspect the camera stream type, create buffers opportunely\n>>> \t\t * and add them to the Request if required.\n>>> @@ -1498,6 +1508,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n>>> \t\t\t * Mapped streams don't need buffers added to the\n>>> \t\t\t * Request.\n>>> \t\t\t */\n>>> +\t\t\tLOG(HAL, Debug) << ss.str() << \" (mapped)\";\n>>> \t\t\tcontinue;\n>>>\n>>> \t\tcase CameraStream::Type::Direct:\n>>> @@ -1509,6 +1520,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n>>> \t\t\t */\n>>> \t\t\tbuffer = createFrameBuffer(*camera3Buffers[i].buffer);\n>>> \t\t\tdescriptor->frameBuffers.emplace_back(buffer);\n>>> +\t\t\tLOG(HAL, Debug) << ss.str() << \" (direct)\";\n>>> \t\t\tbreak;\n>>>\n>>> \t\tcase CameraStream::Type::Internal:\n>>> @@ -1522,6 +1534,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n>>> \t\t\t * allocator once it has been processed.\n>>> \t\t\t */\n>>> \t\t\tbuffer = getBuffer(stream);\n>>> +\t\t\tLOG(HAL, Debug) << ss.str() << \" (internal)\";\n>>> \t\t\tbreak;\n>>> \t\t}\n>>> \t\tif (!buffer) {\n>>>\n>>\n>> --\n>> Regards\n>> --\n>> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E904C3B5C\n\tfor ;\n\tThu, 24 Sep 2020 16:29:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3BB6862FE3;\n\tThu, 24 Sep 2020 18:29:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D9B760363\n\tfor ;\n\tThu, 24 Sep 2020 18:29:49 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C8F32FD;\n\tThu, 24 Sep 2020 18:29:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Z7ZGVBFE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600964989;\n\tbh=Zlc3H0Fj7eEdLltUxiZCMAFuCoPw5QK1mAYSKMBxZIU=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=Z7ZGVBFETMZdSxm8fOs9CU1QRpYXud8K2gFcSz3iBBY2mQdXuHYz2LNs+Bk5CuuB2\n\tcBcNDu6+8HEZVSiVCczoYsLpQcfmgyKuPOrUWHddDo8FjGHdc1tV2VuEB3ZpBRShJC\n\tB8Xo/t3U4fpAJqveoBkhMeipzT0tSxT5xxHG8qZI=","To":"Jacopo Mondi ","References":"<20200922094738.5327-1-jacopo@jmondi.org>\n\t<20200922094738.5327-9-jacopo@jmondi.org>\n\t<4b5467a1-0f59-f57e-055c-ef84f7a43d1e@ideasonboard.com>\n\t<20200924162615.gcjpler55j33b4ba@uno.localdomain>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 24 Sep 2020 17:29:44 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200924162615.gcjpler55j33b4ba@uno.localdomain>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v3 8/8] android: camera_device: Add\n\tstream mapping log","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"hanlinchen@chromium.org, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12763,"web_url":"https://patchwork.libcamera.org/comment/12763/","msgid":"<20200925093919.vsksg4knzok6nps7@uno.localdomain>","date":"2020-09-25T09:39:19","subject":"Re: [libcamera-devel] [PATCH v3 8/8] android: camera_device: Add\n\tstream mapping log","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Thu, Sep 24, 2020 at 05:29:44PM +0100, Kieran Bingham wrote:\n> On 24/09/2020 17:26, Jacopo Mondi wrote:\n> > Hi Kieran\n> >\n> > On Thu, Sep 24, 2020 at 05:10:23PM +0100, Kieran Bingham wrote:\n> >> Hi Jacopo,\n> >>\n> >> On 22/09/2020 10:47, Jacopo Mondi wrote:\n> >>> To ease following how Android stream gets mapped onto libcamera ones\n> >>> add a (quite verbose) printout before queueing a request to libcamera.\n> >>>\n> >>> The output looks like:\n> >>> 0 - (320x240)[0x00000022] -> (320x240)[NV12] (direct)\n> >>> 1 - (640x480)[0x00000021] -> (640x480)[NV12] (internal)\n> >>\n> >> Excellent, - that's definitely helpful.\n> >>\n> >>>\n> >>> Reviewed-by: Hirokazu Honda \n> >>> Reviewed-by: Niklas Söderlund \n> >>> Signed-off-by: Jacopo Mondi \n> >>> ---\n> >>> src/android/camera_device.cpp | 15 ++++++++++++++-\n> >>> 1 file changed, 14 insertions(+), 1 deletion(-)\n> >>>\n> >>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> >>> index 1b35c72a3de6..316d8293843f 100644\n> >>> --- a/src/android/camera_device.cpp\n> >>> +++ b/src/android/camera_device.cpp\n> >>> @@ -1474,9 +1474,12 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> >>> \tRequest *request =\n> >>> \t\tcamera_->createRequest(reinterpret_cast(descriptor));\n> >>>\n> >>> +\tLOG(HAL, Debug) << \"Queueing Request to libcamera with \"\n> >>> +\t\t\t<< descriptor->numBuffers << \" streams\";\n> >>\n> >> This doesn't feel right. You're counting the number of android buffers\n> >> to state the number streams being 'queued' to libcamera.\n> >\n> > 'android buffers' is actually the number of output streams requested\n> > by android\n> >\n> >>\n> >> In the event that one libcamera stream is shared (i.e. say a JPEG\n> >> encode) to generate two android streams, this would be wrong.\n> >\n> > Isn't this intended ? I do expect something like\n> >\n> > Queueing Request to libcamera with 3 streams\n> > 0 - (4160x3104)[0x00000023] -> (4160x3104)[NV12] (direct)\n> > 1 - (4160x3104)[0x00000023] -> (4160x3104)[NV12] (external)\n> > 2 - (4160x3104)[0x00000023] -> (4160x3104)[NV12] (mapped)\n> >\n> > Anyway, we cycle on descriptor->numBuffers, and that's what was\n> > intended to be print out..\n>\n>\n> It's confusing because - how many streams are there in the libcamera\n> request... (I don't believe it's 3?)\n>\n> Maybe you could fix it by saying instead:\n>\n> \"Queuing Request to libcamera to satisfy 3 streams\"...\n> But the request going to libcamera - does not have 3 streams still - so\n> it just sounds odd.\n\nuff\n\nWhat I meant is that android has queued a request to the libcamera HAL\nlayer with #n streams of the reported format and size and the reported\nmapping mode.\n\n>\n> --\n> K\n>\n> >\n> >>\n> >>\n> >>\n> >>> \tfor (unsigned int i = 0; i < descriptor->numBuffers; ++i) {\n> >>> +\t\tcamera3_stream *camera3Stream = camera3Buffers[i].stream;\n> >>> \t\tCameraStream *cameraStream =\n> >>> -\t\t\tstatic_cast(camera3Buffers[i].stream->priv);\n> >>> +\t\t\tstatic_cast(camera3Stream->priv);\n> >>> \t\tconst StreamConfiguration &config = config_->at(cameraStream->index());\n> >>> \t\tStream *stream = config.stream();\n> >>>\n> >>> @@ -1487,6 +1490,13 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> >>> \t\tdescriptor->buffers[i].stream = camera3Buffers[i].stream;\n> >>> \t\tdescriptor->buffers[i].buffer = camera3Buffers[i].buffer;\n> >>>\n> >>> +\t\tstd::stringstream ss;\n> >>> +\t\tss << i << \" - (\"\n> >>> +\t\t << camera3Stream->width << \"x\" << camera3Stream->height << \")\"\n> >>> +\t\t << \"[\" << utils::hex(camera3Stream->format) << \"] -> \"\n> >>\n> >> We should really add a string mapping for this format ... 21 ... 20 ...\n> >> they're not great for following what's been chosen.\n> >>\n> >> Still, that's it's own patch outright and separate to this I guess.\n> >>\n> >>\n> >>> +\t\t << \"(\" << config.size.toString() << \")[\"\n> >>> +\t\t << config.pixelFormat.toString() << \"]\";\n> >>> +\n> >>> \t\t/*\n> >>> \t\t * Inspect the camera stream type, create buffers opportunely\n> >>> \t\t * and add them to the Request if required.\n> >>> @@ -1498,6 +1508,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> >>> \t\t\t * Mapped streams don't need buffers added to the\n> >>> \t\t\t * Request.\n> >>> \t\t\t */\n> >>> +\t\t\tLOG(HAL, Debug) << ss.str() << \" (mapped)\";\n> >>> \t\t\tcontinue;\n> >>>\n> >>> \t\tcase CameraStream::Type::Direct:\n> >>> @@ -1509,6 +1520,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> >>> \t\t\t */\n> >>> \t\t\tbuffer = createFrameBuffer(*camera3Buffers[i].buffer);\n> >>> \t\t\tdescriptor->frameBuffers.emplace_back(buffer);\n> >>> +\t\t\tLOG(HAL, Debug) << ss.str() << \" (direct)\";\n> >>> \t\t\tbreak;\n> >>>\n> >>> \t\tcase CameraStream::Type::Internal:\n> >>> @@ -1522,6 +1534,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> >>> \t\t\t * allocator once it has been processed.\n> >>> \t\t\t */\n> >>> \t\t\tbuffer = getBuffer(stream);\n> >>> +\t\t\tLOG(HAL, Debug) << ss.str() << \" (internal)\";\n> >>> \t\t\tbreak;\n> >>> \t\t}\n> >>> \t\tif (!buffer) {\n> >>>\n> >>\n> >> --\n> >> Regards\n> >> --\n> >> Kieran\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F06EC3B5C\n\tfor ;\n\tFri, 25 Sep 2020 09:35:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6872363028;\n\tFri, 25 Sep 2020 11:35:27 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B282160576\n\tfor ;\n\tFri, 25 Sep 2020 11:35:25 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id EF5171BF20C;\n\tFri, 25 Sep 2020 09:35:24 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Fri, 25 Sep 2020 11:39:19 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20200925093919.vsksg4knzok6nps7@uno.localdomain>","References":"<20200922094738.5327-1-jacopo@jmondi.org>\n\t<20200922094738.5327-9-jacopo@jmondi.org>\n\t<4b5467a1-0f59-f57e-055c-ef84f7a43d1e@ideasonboard.com>\n\t<20200924162615.gcjpler55j33b4ba@uno.localdomain>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v3 8/8] android: camera_device: Add\n\tstream mapping log","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12848,"web_url":"https://patchwork.libcamera.org/comment/12848/","msgid":"<20200929013705.GK14614@pendragon.ideasonboard.com>","date":"2020-09-29T01:37:05","subject":"Re: [libcamera-devel] [PATCH v3 8/8] android: camera_device: Add\n\tstream mapping log","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Sep 25, 2020 at 11:39:19AM +0200, Jacopo Mondi wrote:\n> On Thu, Sep 24, 2020 at 05:29:44PM +0100, Kieran Bingham wrote:\n> > On 24/09/2020 17:26, Jacopo Mondi wrote:\n> > > On Thu, Sep 24, 2020 at 05:10:23PM +0100, Kieran Bingham wrote:\n> > >> On 22/09/2020 10:47, Jacopo Mondi wrote:\n> > >>> To ease following how Android stream gets mapped onto libcamera ones\n\ns/stream gets/streams get/\ns/onto/to/\n\n> > >>> add a (quite verbose) printout before queueing a request to libcamera.\n> > >>>\n> > >>> The output looks like:\n> > >>> 0 - (320x240)[0x00000022] -> (320x240)[NV12] (direct)\n> > >>> 1 - (640x480)[0x00000021] -> (640x480)[NV12] (internal)\n> > >>\n> > >> Excellent, - that's definitely helpful.\n> > >>\n> > >>> Reviewed-by: Hirokazu Honda \n> > >>> Reviewed-by: Niklas Söderlund \n> > >>> Signed-off-by: Jacopo Mondi \n> > >>> ---\n> > >>> src/android/camera_device.cpp | 15 ++++++++++++++-\n> > >>> 1 file changed, 14 insertions(+), 1 deletion(-)\n> > >>>\n> > >>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > >>> index 1b35c72a3de6..316d8293843f 100644\n> > >>> --- a/src/android/camera_device.cpp\n> > >>> +++ b/src/android/camera_device.cpp\n> > >>> @@ -1474,9 +1474,12 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> > >>> \tRequest *request =\n> > >>> \t\tcamera_->createRequest(reinterpret_cast(descriptor));\n> > >>>\n> > >>> +\tLOG(HAL, Debug) << \"Queueing Request to libcamera with \"\n> > >>> +\t\t\t<< descriptor->numBuffers << \" streams\";\n> > >>\n> > >> This doesn't feel right. You're counting the number of android buffers\n> > >> to state the number streams being 'queued' to libcamera.\n> > >\n> > > 'android buffers' is actually the number of output streams requested\n> > > by android\n> > >\n> > >> In the event that one libcamera stream is shared (i.e. say a JPEG\n> > >> encode) to generate two android streams, this would be wrong.\n> > >\n> > > Isn't this intended ? I do expect something like\n> > >\n> > > Queueing Request to libcamera with 3 streams\n> > > 0 - (4160x3104)[0x00000023] -> (4160x3104)[NV12] (direct)\n> > > 1 - (4160x3104)[0x00000023] -> (4160x3104)[NV12] (external)\n> > > 2 - (4160x3104)[0x00000023] -> (4160x3104)[NV12] (mapped)\n> > >\n> > > Anyway, we cycle on descriptor->numBuffers, and that's what was\n> > > intended to be print out..\n> >\n> > It's confusing because - how many streams are there in the libcamera\n> > request... (I don't believe it's 3?)\n> >\n> > Maybe you could fix it by saying instead:\n> >\n> > \"Queuing Request to libcamera to satisfy 3 streams\"...\n> > But the request going to libcamera - does not have 3 streams still - so\n> > it just sounds odd.\n> \n> uff\n> \n> What I meant is that android has queued a request to the libcamera HAL\n> layer with #n streams of the reported format and size and the reported\n> mapping mode.\n\nI also think the message is slightly confusing. How about \"Queuing\nRequest to libcamera for 3 HAL streams\" ? That's a simple change and\nwould make sure it can't be understood as queuing a request with 3\nlibcamera streams.\n\nThe change is good, it really helps understanding what happens.\n\n> > >>> \tfor (unsigned int i = 0; i < descriptor->numBuffers; ++i) {\n> > >>> +\t\tcamera3_stream *camera3Stream = camera3Buffers[i].stream;\n> > >>> \t\tCameraStream *cameraStream =\n> > >>> -\t\t\tstatic_cast(camera3Buffers[i].stream->priv);\n> > >>> +\t\t\tstatic_cast(camera3Stream->priv);\n> > >>> \t\tconst StreamConfiguration &config = config_->at(cameraStream->index());\n> > >>> \t\tStream *stream = config.stream();\n> > >>>\n> > >>> @@ -1487,6 +1490,13 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> > >>> \t\tdescriptor->buffers[i].stream = camera3Buffers[i].stream;\n> > >>> \t\tdescriptor->buffers[i].buffer = camera3Buffers[i].buffer;\n> > >>>\n> > >>> +\t\tstd::stringstream ss;\n> > >>> +\t\tss << i << \" - (\"\n> > >>> +\t\t << camera3Stream->width << \"x\" << camera3Stream->height << \")\"\n> > >>> +\t\t << \"[\" << utils::hex(camera3Stream->format) << \"] -> \"\n> > >>\n> > >> We should really add a string mapping for this format ... 21 ... 20 ...\n> > >> they're not great for following what's been chosen.\n> > >>\n> > >> Still, that's it's own patch outright and separate to this I guess.\n> > >>\n> > >>> +\t\t << \"(\" << config.size.toString() << \")[\"\n> > >>> +\t\t << config.pixelFormat.toString() << \"]\";\n\nThe output would be a bit different, but you could use config.toString()\nto simplify this.\n\nReviewed-by: Laurent Pinchart \n\n> > >>> +\n> > >>> \t\t/*\n> > >>> \t\t * Inspect the camera stream type, create buffers opportunely\n> > >>> \t\t * and add them to the Request if required.\n> > >>> @@ -1498,6 +1508,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> > >>> \t\t\t * Mapped streams don't need buffers added to the\n> > >>> \t\t\t * Request.\n> > >>> \t\t\t */\n> > >>> +\t\t\tLOG(HAL, Debug) << ss.str() << \" (mapped)\";\n> > >>> \t\t\tcontinue;\n> > >>>\n> > >>> \t\tcase CameraStream::Type::Direct:\n> > >>> @@ -1509,6 +1520,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> > >>> \t\t\t */\n> > >>> \t\t\tbuffer = createFrameBuffer(*camera3Buffers[i].buffer);\n> > >>> \t\t\tdescriptor->frameBuffers.emplace_back(buffer);\n> > >>> +\t\t\tLOG(HAL, Debug) << ss.str() << \" (direct)\";\n> > >>> \t\t\tbreak;\n> > >>>\n> > >>> \t\tcase CameraStream::Type::Internal:\n> > >>> @@ -1522,6 +1534,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> > >>> \t\t\t * allocator once it has been processed.\n> > >>> \t\t\t */\n> > >>> \t\t\tbuffer = getBuffer(stream);\n> > >>> +\t\t\tLOG(HAL, Debug) << ss.str() << \" (internal)\";\n> > >>> \t\t\tbreak;\n> > >>> \t\t}\n> > >>> \t\tif (!buffer) {\n> > >>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12587C3B5C\n\tfor ;\n\tTue, 29 Sep 2020 01:37:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8123461FE5;\n\tTue, 29 Sep 2020 03:37:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB81960365\n\tfor ;\n\tTue, 29 Sep 2020 03:37:41 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 80AAC3B;\n\tTue, 29 Sep 2020 03:37:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y1HLsZV/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601343460;\n\tbh=EcLU/eCU8rzDuBTj5fS6FWkioU4Sjy3tc+DUGwED8l0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Y1HLsZV/UG9gBWS+tGUMkvL3ClIhAg+71rlt7pBj2ZezCPDsYSvzuwg/vEmM9H0Wd\n\tm03nDqQkSButDU2Nll74KQdT6MvVDhpW5CDOpyAozF5mkRYwODXSuiPwwIQxGoq2CQ\n\tAm0nAsyCQ1mmQcCRvPsnhcGP1f2haSM0ZHq9RMC0=","Date":"Tue, 29 Sep 2020 04:37:05 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200929013705.GK14614@pendragon.ideasonboard.com>","References":"<20200922094738.5327-1-jacopo@jmondi.org>\n\t<20200922094738.5327-9-jacopo@jmondi.org>\n\t<4b5467a1-0f59-f57e-055c-ef84f7a43d1e@ideasonboard.com>\n\t<20200924162615.gcjpler55j33b4ba@uno.localdomain>\n\t\n\t<20200925093919.vsksg4knzok6nps7@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200925093919.vsksg4knzok6nps7@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v3 8/8] android: camera_device: Add\n\tstream mapping log","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]