{"id":9687,"url":"https://patchwork.libcamera.org/api/patches/9687/?format=json","web_url":"https://patchwork.libcamera.org/patch/9687/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200922094738.5327-4-jacopo@jmondi.org>","date":"2020-09-22T09:47:33","name":"[libcamera-devel,v3,3/8] libcamera: frame_buffer_allocator: Add clear()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d07e16169b4cd973494802bee7a22e16ee3dafc9","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9687/mbox/","series":[{"id":1306,"url":"https://patchwork.libcamera.org/api/series/1306/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1306","date":"2020-09-22T09:47:30","name":"android: camera_device: Add support for internal buffers","version":3,"mbox":"https://patchwork.libcamera.org/series/1306/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9687/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9687/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D3F5ABF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Sep 2020 09:44:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B220F62FD4;\n\tTue, 22 Sep 2020 11:44:11 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F86160364\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Sep 2020 11:44:11 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 743CBE000D;\n\tTue, 22 Sep 2020 09:44:05 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 22 Sep 2020 11:47:33 +0200","Message-Id":"<20200922094738.5327-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20200922094738.5327-1-jacopo@jmondi.org>","References":"<20200922094738.5327-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 3/8] libcamera: frame_buffer_allocator:\n\tAdd clear()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"hanlinchen@chromium.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Add a clear() method to the FrameBufferAllocator class that\nfrees all the buffers previously reserved by the allocator.\n\nReviewed-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/framebuffer_allocator.h | 1 +\n src/libcamera/framebuffer_allocator.cpp   | 8 ++++++++\n 2 files changed, 9 insertions(+)","diff":"diff --git a/include/libcamera/framebuffer_allocator.h b/include/libcamera/framebuffer_allocator.h\nindex 78f1353964eb..2a4d538a0cb2 100644\n--- a/include/libcamera/framebuffer_allocator.h\n+++ b/include/libcamera/framebuffer_allocator.h\n@@ -28,6 +28,7 @@ public:\n \n \tint allocate(Stream *stream);\n \tint free(Stream *stream);\n+\tvoid clear();\n \n \tbool allocated() const { return !buffers_.empty(); }\n \tconst std::vector<std::unique_ptr<FrameBuffer>> &buffers(Stream *stream) const;\ndiff --git a/src/libcamera/framebuffer_allocator.cpp b/src/libcamera/framebuffer_allocator.cpp\nindex 2fbba37a1b0b..7ed80011c845 100644\n--- a/src/libcamera/framebuffer_allocator.cpp\n+++ b/src/libcamera/framebuffer_allocator.cpp\n@@ -125,6 +125,14 @@ int FrameBufferAllocator::free(Stream *stream)\n \treturn 0;\n }\n \n+/**\n+ * \\brief Free all the buffers previously allocated\n+ */\n+void FrameBufferAllocator::clear()\n+{\n+\tbuffers_.clear();\n+}\n+\n /**\n  * \\fn FrameBufferAllocator::allocated()\n  * \\brief Check if the allocator has allocated buffers for any stream\n","prefixes":["libcamera-devel","v3","3/8"]}