[{"id":12668,"web_url":"https://patchwork.libcamera.org/comment/12668/","msgid":"<91837ef2-26ff-1d3e-0b46-9cef906a4373@ideasonboard.com>","date":"2020-09-23T11:47:46","subject":"Re: [libcamera-devel] [PATCH v3 2/8] android: camera_device: Add\n\tframe allocator","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 22/09/2020 10:47, Jacopo Mondi wrote:\n> Add to the CameraDevice class a FrameBufferAllocator class member.\n\n\"Add a FrameBufferAllocator to the CameraDevice class.\"\n\nOr rather:\n\nAdd a FrameBufferAllocator to the CameraDevice class to handle any\nallocations required to satisfy internal stream requirements.\n\n\n> Reviewed-by: Niklas Söderlund \n> Reviewed-by: Hirokazu Honda \n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_device.cpp | 5 +++--\n> src/android/camera_device.h | 2 ++\n> 2 files changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index e4ffbc02c2da..98b8159ebd8c 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -14,6 +14,7 @@\n> \n> #include \n> #include \n> +#include \n> #include \n> \n> #include \"libcamera/internal/formats.h\"\n> @@ -211,8 +212,8 @@ CameraDevice::Camera3RequestDescriptor::~Camera3RequestDescriptor()\n> */\n> \n> CameraDevice::CameraDevice(unsigned int id, const std::shared_ptr &camera)\n> -\t: id_(id), running_(false), camera_(camera), staticMetadata_(nullptr),\n> -\t facing_(CAMERA_FACING_FRONT), orientation_(0)\n> +\t: id_(id), running_(false), camera_(camera), allocator_(camera),\n> +\t staticMetadata_(nullptr), facing_(CAMERA_FACING_FRONT), orientation_(0)\n> {\n> \tcamera_->requestCompleted.connect(this, &CameraDevice::requestComplete);\n> \n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index 9a9406cc257c..84f636f7a93c 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -16,6 +16,7 @@\n> \n> #include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -206,6 +207,7 @@ private:\n> \tbool running_;\n> \tstd::shared_ptr camera_;\n> \tstd::unique_ptr config_;\n> +\tlibcamera::FrameBufferAllocator allocator_;\n> \n> \tCameraMetadata *staticMetadata_;\n> \tstd::map requestTemplates_;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 072D7C3B5C\n\tfor ;\n\tWed, 23 Sep 2020 11:47:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7482C62FE1;\n\tWed, 23 Sep 2020 13:47:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B21DF62FD2\n\tfor ;\n\tWed, 23 Sep 2020 13:47:53 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A05C2FD;\n\tWed, 23 Sep 2020 13:47:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sLAknPlG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600861669;\n\tbh=FKbHG8bGYds95Bpftg6lUojB4mRRgFh5I7pec9FBUYY=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=sLAknPlGWcMr5/0fpZ0gjT8Un1AiDVBfBvlJgl8UW4P20LNN7gZUzDg3KkpmloJ/T\n\tzYF9iK4/lQZyF9xJbuvEI/wRtf8hCp9BnrKHttO3JlcudsezuTtSpSznx6MWAKVTWy\n\tuhz029ysexIhkcfEi2gba3bVqEkHkWXkbjGRquog=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20200922094738.5327-1-jacopo@jmondi.org>\n\t<20200922094738.5327-3-jacopo@jmondi.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<91837ef2-26ff-1d3e-0b46-9cef906a4373@ideasonboard.com>","Date":"Wed, 23 Sep 2020 12:47:46 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200922094738.5327-3-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v3 2/8] android: camera_device: Add\n\tframe allocator","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"hanlinchen@chromium.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12847,"web_url":"https://patchwork.libcamera.org/comment/12847/","msgid":"<20200929013007.GJ14614@pendragon.ideasonboard.com>","date":"2020-09-29T01:30:07","subject":"Re: [libcamera-devel] [PATCH v3 2/8] android: camera_device: Add\n\tframe allocator","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Sep 23, 2020 at 12:47:46PM +0100, Kieran Bingham wrote:\n> On 22/09/2020 10:47, Jacopo Mondi wrote:\n> > Add to the CameraDevice class a FrameBufferAllocator class member.\n> \n> \"Add a FrameBufferAllocator to the CameraDevice class.\"\n> \n> Or rather:\n> \n> Add a FrameBufferAllocator to the CameraDevice class to handle any\n> allocations required to satisfy internal stream requirements.\n> \n> > Reviewed-by: Niklas Söderlund \n> > Reviewed-by: Hirokazu Honda \n> \n> Reviewed-by: Kieran Bingham \n> \n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/android/camera_device.cpp | 5 +++--\n> > src/android/camera_device.h | 2 ++\n> > 2 files changed, 5 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index e4ffbc02c2da..98b8159ebd8c 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -14,6 +14,7 @@\n> > \n> > #include \n> > #include \n> > +#include \n\nYou can drop this, the header is included in camera_device.h.\n\nReviewed-by: Laurent Pinchart \n\n> > #include \n> > \n> > #include \"libcamera/internal/formats.h\"\n> > @@ -211,8 +212,8 @@ CameraDevice::Camera3RequestDescriptor::~Camera3RequestDescriptor()\n> > */\n> > \n> > CameraDevice::CameraDevice(unsigned int id, const std::shared_ptr &camera)\n> > -\t: id_(id), running_(false), camera_(camera), staticMetadata_(nullptr),\n> > -\t facing_(CAMERA_FACING_FRONT), orientation_(0)\n> > +\t: id_(id), running_(false), camera_(camera), allocator_(camera),\n> > +\t staticMetadata_(nullptr), facing_(CAMERA_FACING_FRONT), orientation_(0)\n> > {\n> > \tcamera_->requestCompleted.connect(this, &CameraDevice::requestComplete);\n> > \n> > diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> > index 9a9406cc257c..84f636f7a93c 100644\n> > --- a/src/android/camera_device.h\n> > +++ b/src/android/camera_device.h\n> > @@ -16,6 +16,7 @@\n> > \n> > #include \n> > #include \n> > +#include \n> > #include \n> > #include \n> > #include \n> > @@ -206,6 +207,7 @@ private:\n> > \tbool running_;\n> > \tstd::shared_ptr camera_;\n> > \tstd::unique_ptr config_;\n> > +\tlibcamera::FrameBufferAllocator allocator_;\n> > \n> > \tCameraMetadata *staticMetadata_;\n> > \tstd::map requestTemplates_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F298EC3B5B\n\tfor ;\n\tTue, 29 Sep 2020 01:30:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8565A62033;\n\tTue, 29 Sep 2020 03:30:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2660A60365\n\tfor ;\n\tTue, 29 Sep 2020 03:30:44 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B1169CC;\n\tTue, 29 Sep 2020 03:30:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LxshqKpz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601343042;\n\tbh=KYfTqxaav870nTM7o/TKkyeLNXdT4MLOKMC6soAUYZU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LxshqKpz3yIEWWZqq7MA1fyLr80dY8FbU8T38UoUwKDLc3sJ/Kb0oc6vbB1pAPQKA\n\trcdZY8yrFOK9VHoe/dV3rCB8LVo0YUuexkmm9FU/HzImnVAZ4Sft2eR0jxHk334iOT\n\tNKx5SWiXU6cOKZrjbvJ2CZAt8HH1m1gYk2GogFmU=","Date":"Tue, 29 Sep 2020 04:30:07 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200929013007.GJ14614@pendragon.ideasonboard.com>","References":"<20200922094738.5327-1-jacopo@jmondi.org>\n\t<20200922094738.5327-3-jacopo@jmondi.org>\n\t<91837ef2-26ff-1d3e-0b46-9cef906a4373@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<91837ef2-26ff-1d3e-0b46-9cef906a4373@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 2/8] android: camera_device: Add\n\tframe allocator","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]