[{"id":12633,"web_url":"https://patchwork.libcamera.org/comment/12633/","msgid":"<20200921191647.GA18343@pendragon.ideasonboard.com>","date":"2020-09-21T19:16:47","subject":"Re: [libcamera-devel] [RFC] libcamera: buffer: Remove copyFrom()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Sep 21, 2020 at 08:32:05PM +0200, Niklas Söderlund wrote:\n> There are no user left of the copyFrom() operation, remove it.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> include/libcamera/buffer.h | 2 --\n> src/libcamera/buffer.cpp | 59 --------------------------------------\n> 2 files changed, 61 deletions(-)\n> ---\n> \n> Hello,\n> \n> I'm not sure it's wise to leave this operation in the code while we have \n> no users. But I do fear we might need it the future, but as we don't use \n> or test it I'm sure we will have modified FrameBuffer enough to make \n> this incomplete at that that so I think it's best to remove it. What do \n> you guys think?\n\nDrop it :-)\n\nReviewed-by: Laurent Pinchart \n\nWe can always bring code back if needed.\n\n> diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\n> index 6bb2e4f8558f03ac..a26c8927d37a812e 100644\n> --- a/include/libcamera/buffer.h\n> +++ b/include/libcamera/buffer.h\n> @@ -57,8 +57,6 @@ public:\n> \n> \tunsigned int cookie() const { return cookie_; }\n> \tvoid setCookie(unsigned int cookie) { cookie_ = cookie; }\n> -\n> -\tint copyFrom(const FrameBuffer *src);\n> private:\n> \tfriend class Request; /* Needed to update request_. */\n> \tfriend class V4L2VideoDevice; /* Needed to update metadata_. */\n> diff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\n> index 03f628e8b585a1f9..75b2693281a74cdc 100644\n> --- a/src/libcamera/buffer.cpp\n> +++ b/src/libcamera/buffer.cpp\n> @@ -226,65 +226,6 @@ FrameBuffer::FrameBuffer(const std::vector &planes, unsigned int cookie)\n> * core never modifies the buffer cookie.\n> */\n> \n> -/**\n> - * \\brief Copy the contents from another buffer\n> - * \\param[in] src FrameBuffer to copy\n> - *\n> - * Copy the buffer contents and metadata from \\a src to this buffer. The\n> - * destination FrameBuffer shall have the same number of planes as the source\n> - * buffer, and each destination plane shall be larger than or equal to the\n> - * corresponding source plane.\n> - *\n> - * The complete metadata of the source buffer is copied to the destination\n> - * buffer. If an error occurs during the copy, the destination buffer's metadata\n> - * status is set to FrameMetadata::FrameError, and other metadata fields are not\n> - * modified.\n> - *\n> - * The operation is performed using memcpy() so is very slow, users needs to\n> - * consider this before copying buffers.\n> - *\n> - * \\return 0 on success or a negative error code otherwise\n> - */\n> -int FrameBuffer::copyFrom(const FrameBuffer *src)\n> -{\n> -\tif (planes_.size() != src->planes_.size()) {\n> -\t\tLOG(Buffer, Error) << \"Different number of planes\";\n> -\t\tmetadata_.status = FrameMetadata::FrameError;\n> -\t\treturn -EINVAL;\n> -\t}\n> -\n> -\tfor (unsigned int i = 0; i < planes_.size(); i++) {\n> -\t\tif (planes_[i].length < src->planes_[i].length) {\n> -\t\t\tLOG(Buffer, Error) << \"Plane \" << i << \" is too small\";\n> -\t\t\tmetadata_.status = FrameMetadata::FrameError;\n> -\t\t\treturn -EINVAL;\n> -\t\t}\n> -\t}\n> -\n> -\tMappedFrameBuffer source(src, PROT_READ);\n> -\tMappedFrameBuffer destination(this, PROT_WRITE);\n> -\n> -\tif (!source.isValid()) {\n> -\t\tLOG(Buffer, Error) << \"Failed to map source planes\";\n> -\t\treturn -EINVAL;\n> -\t}\n> -\n> -\tif (!destination.isValid()) {\n> -\t\tLOG(Buffer, Error) << \"Failed to map destination planes\";\n> -\t\treturn -EINVAL;\n> -\t}\n> -\n> -\tfor (unsigned int i = 0; i < planes_.size(); i++) {\n> -\t\tmemcpy(destination.maps()[i].data(),\n> -\t\t source.maps()[i].data(),\n> -\t\t source.maps()[i].size());\n> -\t}\n> -\n> -\tmetadata_ = src->metadata_;\n> -\n> -\treturn 0;\n> -}\n> -\n> /**\n> * \\class MappedBuffer\n> * \\brief Provide an interface to support managing memory mapped buffers","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50C4AC3B5B\n\tfor ;\n\tMon, 21 Sep 2020 19:17:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B433C62FD3;\n\tMon, 21 Sep 2020 21:17:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DA2462B90\n\tfor ;\n\tMon, 21 Sep 2020 21:17:23 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B467A2D7;\n\tMon, 21 Sep 2020 21:17:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kqU91HSc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600715843;\n\tbh=/Q5TfyNWJMSZY3QV9bQbCIwzeLvCOcC93JBxG4xXSqs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kqU91HSc/UHKgNJVprJ5Z3Ganb5ppxqWW21iDJyqbN+mZG70BD/R5kcigbxzFxtwQ\n\tB1EXE+vnfJjzyKpjdEzGUvp2T5fhQRTtAIw6vOeDPJzigMNQ+JN6Ku3SjDFw1nIhk6\n\t0s5CLgp7JshvgdtmYqGrh/cnUX4E8vDBlFZa+HDg=","Date":"Mon, 21 Sep 2020 22:16:47 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200921191647.GA18343@pendragon.ideasonboard.com>","References":"<20200921183205.2516132-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200921183205.2516132-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [RFC] libcamera: buffer: Remove copyFrom()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12634,"web_url":"https://patchwork.libcamera.org/comment/12634/","msgid":"<0962ac19-90af-26fe-a0cf-e993a7d482b1@ideasonboard.com>","date":"2020-09-21T20:33:02","subject":"Re: [libcamera-devel] [RFC] libcamera: buffer: Remove copyFrom()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 21/09/2020 20:16, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> Thank you for the patch.\n> \n> On Mon, Sep 21, 2020 at 08:32:05PM +0200, Niklas Söderlund wrote:\n>> There are no user left of the copyFrom() operation, remove it.\n>>\n>> Signed-off-by: Niklas Söderlund \n>> ---\n>> include/libcamera/buffer.h | 2 --\n>> src/libcamera/buffer.cpp | 59 --------------------------------------\n>> 2 files changed, 61 deletions(-)\n>> ---\n>>\n>> Hello,\n>>\n>> I'm not sure it's wise to leave this operation in the code while we have \n>> no users. But I do fear we might need it the future, but as we don't use \n>> or test it I'm sure we will have modified FrameBuffer enough to make \n>> this incomplete at that that so I think it's best to remove it. What do \n>> you guys think?\n> \n> Drop it :-)\n> \n> Reviewed-by: Laurent Pinchart \n> \n> We can always bring code back if needed.\n> \n\nAgreed, No users, no tests, no requirement, and an undesired 'feature'.\n\nReviewed-by: Kieran Bingham \n\nWhat can you envisage in the future that might require bringing it back?\n\n\n\n>> diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\n>> index 6bb2e4f8558f03ac..a26c8927d37a812e 100644\n>> --- a/include/libcamera/buffer.h\n>> +++ b/include/libcamera/buffer.h\n>> @@ -57,8 +57,6 @@ public:\n>> \n>> \tunsigned int cookie() const { return cookie_; }\n>> \tvoid setCookie(unsigned int cookie) { cookie_ = cookie; }\n>> -\n>> -\tint copyFrom(const FrameBuffer *src);\n>> private:\n>> \tfriend class Request; /* Needed to update request_. */\n>> \tfriend class V4L2VideoDevice; /* Needed to update metadata_. */\n>> diff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\n>> index 03f628e8b585a1f9..75b2693281a74cdc 100644\n>> --- a/src/libcamera/buffer.cpp\n>> +++ b/src/libcamera/buffer.cpp\n>> @@ -226,65 +226,6 @@ FrameBuffer::FrameBuffer(const std::vector &planes, unsigned int cookie)\n>> * core never modifies the buffer cookie.\n>> */\n>> \n>> -/**\n>> - * \\brief Copy the contents from another buffer\n>> - * \\param[in] src FrameBuffer to copy\n>> - *\n>> - * Copy the buffer contents and metadata from \\a src to this buffer. The\n>> - * destination FrameBuffer shall have the same number of planes as the source\n>> - * buffer, and each destination plane shall be larger than or equal to the\n>> - * corresponding source plane.\n>> - *\n>> - * The complete metadata of the source buffer is copied to the destination\n>> - * buffer. If an error occurs during the copy, the destination buffer's metadata\n>> - * status is set to FrameMetadata::FrameError, and other metadata fields are not\n>> - * modified.\n>> - *\n>> - * The operation is performed using memcpy() so is very slow, users needs to\n>> - * consider this before copying buffers.\n>> - *\n>> - * \\return 0 on success or a negative error code otherwise\n>> - */\n>> -int FrameBuffer::copyFrom(const FrameBuffer *src)\n>> -{\n>> -\tif (planes_.size() != src->planes_.size()) {\n>> -\t\tLOG(Buffer, Error) << \"Different number of planes\";\n>> -\t\tmetadata_.status = FrameMetadata::FrameError;\n>> -\t\treturn -EINVAL;\n>> -\t}\n>> -\n>> -\tfor (unsigned int i = 0; i < planes_.size(); i++) {\n>> -\t\tif (planes_[i].length < src->planes_[i].length) {\n>> -\t\t\tLOG(Buffer, Error) << \"Plane \" << i << \" is too small\";\n>> -\t\t\tmetadata_.status = FrameMetadata::FrameError;\n>> -\t\t\treturn -EINVAL;\n>> -\t\t}\n>> -\t}\n>> -\n>> -\tMappedFrameBuffer source(src, PROT_READ);\n>> -\tMappedFrameBuffer destination(this, PROT_WRITE);\n>> -\n>> -\tif (!source.isValid()) {\n>> -\t\tLOG(Buffer, Error) << \"Failed to map source planes\";\n>> -\t\treturn -EINVAL;\n>> -\t}\n>> -\n>> -\tif (!destination.isValid()) {\n>> -\t\tLOG(Buffer, Error) << \"Failed to map destination planes\";\n>> -\t\treturn -EINVAL;\n>> -\t}\n>> -\n>> -\tfor (unsigned int i = 0; i < planes_.size(); i++) {\n>> -\t\tmemcpy(destination.maps()[i].data(),\n>> -\t\t source.maps()[i].data(),\n>> -\t\t source.maps()[i].size());\n>> -\t}\n>> -\n>> -\tmetadata_ = src->metadata_;\n>> -\n>> -\treturn 0;\n>> -}\n>> -\n>> /**\n>> * \\class MappedBuffer\n>> * \\brief Provide an interface to support managing memory mapped buffers\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 603D4BF01C\n\tfor ;\n\tMon, 21 Sep 2020 20:33:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DDDA762FAD;\n\tMon, 21 Sep 2020 22:33:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 63E4B62B90\n\tfor ;\n\tMon, 21 Sep 2020 22:33:06 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B67DF2D7;\n\tMon, 21 Sep 2020 22:33:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EvupEYIk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600720386;\n\tbh=m2KSbstCaZbqD2LLEsb22po7FiPZ3LoQsnV3mJ/bBfQ=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=EvupEYIkZTOfKpZa8p6+3zACuqytZ/NnmOL7JYsvYiu87CVVT3mL7HeYIkNTRMcU/\n\tnnUYmG/LKebncVxFlhRFcKqkk2k1lInrpXIv1RtN99b7VNejUpoBZwAun+3ZLfWSc9\n\tgF5bP5BZ58Q8KH8PYSDBgpVwjhRfsP97yg9/YiO0=","To":"Laurent Pinchart , =?utf-8?q?Niklas?=\n\t=?utf-8?q?_S=C3=B6derlund?= ","References":"<20200921183205.2516132-1-niklas.soderlund@ragnatech.se>\n\t<20200921191647.GA18343@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<0962ac19-90af-26fe-a0cf-e993a7d482b1@ideasonboard.com>","Date":"Mon, 21 Sep 2020 21:33:02 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200921191647.GA18343@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [RFC] libcamera: buffer: Remove copyFrom()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12637,"web_url":"https://patchwork.libcamera.org/comment/12637/","msgid":"<20200922100251.GA502216@oden.dyn.berto.se>","date":"2020-09-22T10:02:51","subject":"Re: [libcamera-devel] [RFC] libcamera: buffer: Remove copyFrom()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hello,\n\nOn 2020-09-21 21:33:02 +0100, Kieran Bingham wrote:\n> On 21/09/2020 20:16, Laurent Pinchart wrote:\n> > Hi Niklas,\n> > \n> > Thank you for the patch.\n> > \n> > On Mon, Sep 21, 2020 at 08:32:05PM +0200, Niklas Söderlund wrote:\n> >> There are no user left of the copyFrom() operation, remove it.\n> >>\n> >> Signed-off-by: Niklas Söderlund \n> >> ---\n> >> include/libcamera/buffer.h | 2 --\n> >> src/libcamera/buffer.cpp | 59 --------------------------------------\n> >> 2 files changed, 61 deletions(-)\n> >> ---\n> >>\n> >> Hello,\n> >>\n> >> I'm not sure it's wise to leave this operation in the code while we have \n> >> no users. But I do fear we might need it the future, but as we don't use \n> >> or test it I'm sure we will have modified FrameBuffer enough to make \n> >> this incomplete at that that so I think it's best to remove it. What do \n> >> you guys think?\n> > \n> > Drop it :-)\n> > \n> > Reviewed-by: Laurent Pinchart \n> > \n> > We can always bring code back if needed.\n> > \n> \n> Agreed, No users, no tests, no requirement, and an undesired 'feature'.\n> \n> Reviewed-by: Kieran Bingham \n\nThanks then i will move ahead and drop this code.\n\n> \n> What can you envisage in the future that might require bringing it back?\n\nI'm primary thinking about exposing statistics/embeddedmetadata to \napplications by copying them. As we are not sure how to best do that I \nfear a copy could be involved, or not :-)\n\n> \n> \n> \n> >> diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\n> >> index 6bb2e4f8558f03ac..a26c8927d37a812e 100644\n> >> --- a/include/libcamera/buffer.h\n> >> +++ b/include/libcamera/buffer.h\n> >> @@ -57,8 +57,6 @@ public:\n> >> \n> >> \tunsigned int cookie() const { return cookie_; }\n> >> \tvoid setCookie(unsigned int cookie) { cookie_ = cookie; }\n> >> -\n> >> -\tint copyFrom(const FrameBuffer *src);\n> >> private:\n> >> \tfriend class Request; /* Needed to update request_. */\n> >> \tfriend class V4L2VideoDevice; /* Needed to update metadata_. */\n> >> diff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\n> >> index 03f628e8b585a1f9..75b2693281a74cdc 100644\n> >> --- a/src/libcamera/buffer.cpp\n> >> +++ b/src/libcamera/buffer.cpp\n> >> @@ -226,65 +226,6 @@ FrameBuffer::FrameBuffer(const std::vector &planes, unsigned int cookie)\n> >> * core never modifies the buffer cookie.\n> >> */\n> >> \n> >> -/**\n> >> - * \\brief Copy the contents from another buffer\n> >> - * \\param[in] src FrameBuffer to copy\n> >> - *\n> >> - * Copy the buffer contents and metadata from \\a src to this buffer. The\n> >> - * destination FrameBuffer shall have the same number of planes as the source\n> >> - * buffer, and each destination plane shall be larger than or equal to the\n> >> - * corresponding source plane.\n> >> - *\n> >> - * The complete metadata of the source buffer is copied to the destination\n> >> - * buffer. If an error occurs during the copy, the destination buffer's metadata\n> >> - * status is set to FrameMetadata::FrameError, and other metadata fields are not\n> >> - * modified.\n> >> - *\n> >> - * The operation is performed using memcpy() so is very slow, users needs to\n> >> - * consider this before copying buffers.\n> >> - *\n> >> - * \\return 0 on success or a negative error code otherwise\n> >> - */\n> >> -int FrameBuffer::copyFrom(const FrameBuffer *src)\n> >> -{\n> >> -\tif (planes_.size() != src->planes_.size()) {\n> >> -\t\tLOG(Buffer, Error) << \"Different number of planes\";\n> >> -\t\tmetadata_.status = FrameMetadata::FrameError;\n> >> -\t\treturn -EINVAL;\n> >> -\t}\n> >> -\n> >> -\tfor (unsigned int i = 0; i < planes_.size(); i++) {\n> >> -\t\tif (planes_[i].length < src->planes_[i].length) {\n> >> -\t\t\tLOG(Buffer, Error) << \"Plane \" << i << \" is too small\";\n> >> -\t\t\tmetadata_.status = FrameMetadata::FrameError;\n> >> -\t\t\treturn -EINVAL;\n> >> -\t\t}\n> >> -\t}\n> >> -\n> >> -\tMappedFrameBuffer source(src, PROT_READ);\n> >> -\tMappedFrameBuffer destination(this, PROT_WRITE);\n> >> -\n> >> -\tif (!source.isValid()) {\n> >> -\t\tLOG(Buffer, Error) << \"Failed to map source planes\";\n> >> -\t\treturn -EINVAL;\n> >> -\t}\n> >> -\n> >> -\tif (!destination.isValid()) {\n> >> -\t\tLOG(Buffer, Error) << \"Failed to map destination planes\";\n> >> -\t\treturn -EINVAL;\n> >> -\t}\n> >> -\n> >> -\tfor (unsigned int i = 0; i < planes_.size(); i++) {\n> >> -\t\tmemcpy(destination.maps()[i].data(),\n> >> -\t\t source.maps()[i].data(),\n> >> -\t\t source.maps()[i].size());\n> >> -\t}\n> >> -\n> >> -\tmetadata_ = src->metadata_;\n> >> -\n> >> -\treturn 0;\n> >> -}\n> >> -\n> >> /**\n> >> * \\class MappedBuffer\n> >> * \\brief Provide an interface to support managing memory mapped buffers\n> > \n> \n> -- \n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 513EDBF01C\n\tfor ;\n\tTue, 22 Sep 2020 10:02:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA66162FD3;\n\tTue, 22 Sep 2020 12:02:54 +0200 (CEST)","from mail-lj1-x234.google.com (mail-lj1-x234.google.com\n\t[IPv6:2a00:1450:4864:20::234])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D817260365\n\tfor ;\n\tTue, 22 Sep 2020 12:02:53 +0200 (CEST)","by mail-lj1-x234.google.com with SMTP id a15so13629084ljk.2\n\tfor ;\n\tTue, 22 Sep 2020 03:02:53 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tb14sm3327428lfp.176.2020.09.22.03.02.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Sep 2020 03:02:52 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"qR4sBjEc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=7wnY29La9k5rkAChPDBKGR54UQooerLYSf6PfwaXJKY=;\n\tb=qR4sBjEcAgQzIJVI2e1wdJ3kiHhtlM8pY6SEuQrPdalF5qwKeAMFf76s0GR0AuVYwK\n\tjsNj9mSJr/4/QsrbNcC+H7bxsfmLRc/PSvlJTYoUSHjCoEqdfAhz56+cs1sqYUIqZcPn\n\tgVBt08kAQGBnf2eSdG1km/6sQjoPtz/2PXi3TjJHb1z8zQAmYolG9dyLhjagWZZ3Iek0\n\teFengDrsyi/ayre3dM9koNfqYtTkRZZeOmZKHr2UJyDKx8lc02D41lJr7/Dyt2GoaFeJ\n\tg0tx4EuiA77k8lJURjiIr6elMUF/Az/ru2+bGfnaVrd1qT0CaX66OAu0lkMclbwP9njm\n\txkBw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=7wnY29La9k5rkAChPDBKGR54UQooerLYSf6PfwaXJKY=;\n\tb=f4v8O5JFbnQ2a+nGbQlPkIwHNIiJAT7CtfHjiz97dcbM1Kciv2RvXKkBJvHc1xJNjy\n\t9Fd20mAs++wj2HIlggRHXg2Nt66CmVuGRkdHeonPYyznAJrypIH1Hp+aPjISwc4kFW4A\n\tUcREINywkIl7IARBoqrV/FGBTDzUYGtC+9Zj9NXcyKeV03g/yEll4SJandvGU8P/QySV\n\tEBih/wfhBLZluY7V7Yrk+Ud01XABrzoagq4/+3QfWi6Myd7pLFEYl6z2ibONDI78rk1c\n\tOl6SKXB3oaAP7IQhxSyDohmabMqm7zs9mZnikfW+VfGNYMJQholgNCas90Tum/hMng+D\n\tMajQ==","X-Gm-Message-State":"AOAM533uc19etT+NZerDH25+ufimqxOU+0PNjyJ+gFR+6t5ycDKdRutR\n\t5UwFxTSo6SMUacuvOpin1k2ZCg==","X-Google-Smtp-Source":"ABdhPJxiPCtiwgzuklR1Gt0e22AjJRAiiDvrApOcs7vtDAl938/8U11Qk65NPb1mwy/bG08fmgNiSw==","X-Received":"by 2002:a2e:8e63:: with SMTP id t3mr1165176ljk.132.1600768973008;\n\tTue, 22 Sep 2020 03:02:53 -0700 (PDT)","Date":"Tue, 22 Sep 2020 12:02:51 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Message-ID":"<20200922100251.GA502216@oden.dyn.berto.se>","References":"<20200921183205.2516132-1-niklas.soderlund@ragnatech.se>\n\t<20200921191647.GA18343@pendragon.ideasonboard.com>\n\t<0962ac19-90af-26fe-a0cf-e993a7d482b1@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<0962ac19-90af-26fe-a0cf-e993a7d482b1@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC] libcamera: buffer: Remove copyFrom()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12644,"web_url":"https://patchwork.libcamera.org/comment/12644/","msgid":"","date":"2020-09-22T16:03:15","subject":"Re: [libcamera-devel] [RFC] libcamera: buffer: Remove copyFrom()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 22/09/2020 11:02, Niklas Söderlund wrote:\n> Hello,\n> \n> On 2020-09-21 21:33:02 +0100, Kieran Bingham wrote:\n>> On 21/09/2020 20:16, Laurent Pinchart wrote:\n>>> Hi Niklas,\n>>>\n>>> Thank you for the patch.\n>>>\n>>> On Mon, Sep 21, 2020 at 08:32:05PM +0200, Niklas Söderlund wrote:\n>>>> There are no user left of the copyFrom() operation, remove it.\n>>>>\n>>>> Signed-off-by: Niklas Söderlund \n>>>> ---\n>>>> include/libcamera/buffer.h | 2 --\n>>>> src/libcamera/buffer.cpp | 59 --------------------------------------\n>>>> 2 files changed, 61 deletions(-)\n>>>> ---\n>>>>\n>>>> Hello,\n>>>>\n>>>> I'm not sure it's wise to leave this operation in the code while we have \n>>>> no users. But I do fear we might need it the future, but as we don't use \n>>>> or test it I'm sure we will have modified FrameBuffer enough to make \n>>>> this incomplete at that that so I think it's best to remove it. What do \n>>>> you guys think?\n>>>\n>>> Drop it :-)\n>>>\n>>> Reviewed-by: Laurent Pinchart \n>>>\n>>> We can always bring code back if needed.\n>>>\n>>\n>> Agreed, No users, no tests, no requirement, and an undesired 'feature'.\n>>\n>> Reviewed-by: Kieran Bingham \n> \n> Thanks then i will move ahead and drop this code.\n> \n>>\n>> What can you envisage in the future that might require bringing it back?\n> \n> I'm primary thinking about exposing statistics/embeddedmetadata to \n> applications by copying them. As we are not sure how to best do that I \n> fear a copy could be involved, or not :-)\n\nAha I see ... I guess it depends on how the data gets exposed indeed,\nand whether the 'raw' data is sent to applications, or if we translate\nit in anyway to make it more generically consumable.\n\nInitially I would assume there would be a need to translate to generic\nformats, otherwise each application might have to be pipeline specific -\nbut then again - for camera tuning applications, it might *be* pipeline\nspecific ...\n\nDropping seems fine for me for now all the same, it's easy to bring back\nif we hit that later.\n\n--\nKieran\n\n\n>>>> diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\n>>>> index 6bb2e4f8558f03ac..a26c8927d37a812e 100644\n>>>> --- a/include/libcamera/buffer.h\n>>>> +++ b/include/libcamera/buffer.h\n>>>> @@ -57,8 +57,6 @@ public:\n>>>> \n>>>> \tunsigned int cookie() const { return cookie_; }\n>>>> \tvoid setCookie(unsigned int cookie) { cookie_ = cookie; }\n>>>> -\n>>>> -\tint copyFrom(const FrameBuffer *src);\n>>>> private:\n>>>> \tfriend class Request; /* Needed to update request_. */\n>>>> \tfriend class V4L2VideoDevice; /* Needed to update metadata_. */\n>>>> diff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\n>>>> index 03f628e8b585a1f9..75b2693281a74cdc 100644\n>>>> --- a/src/libcamera/buffer.cpp\n>>>> +++ b/src/libcamera/buffer.cpp\n>>>> @@ -226,65 +226,6 @@ FrameBuffer::FrameBuffer(const std::vector &planes, unsigned int cookie)\n>>>> * core never modifies the buffer cookie.\n>>>> */\n>>>> \n>>>> -/**\n>>>> - * \\brief Copy the contents from another buffer\n>>>> - * \\param[in] src FrameBuffer to copy\n>>>> - *\n>>>> - * Copy the buffer contents and metadata from \\a src to this buffer. The\n>>>> - * destination FrameBuffer shall have the same number of planes as the source\n>>>> - * buffer, and each destination plane shall be larger than or equal to the\n>>>> - * corresponding source plane.\n>>>> - *\n>>>> - * The complete metadata of the source buffer is copied to the destination\n>>>> - * buffer. If an error occurs during the copy, the destination buffer's metadata\n>>>> - * status is set to FrameMetadata::FrameError, and other metadata fields are not\n>>>> - * modified.\n>>>> - *\n>>>> - * The operation is performed using memcpy() so is very slow, users needs to\n>>>> - * consider this before copying buffers.\n>>>> - *\n>>>> - * \\return 0 on success or a negative error code otherwise\n>>>> - */\n>>>> -int FrameBuffer::copyFrom(const FrameBuffer *src)\n>>>> -{\n>>>> -\tif (planes_.size() != src->planes_.size()) {\n>>>> -\t\tLOG(Buffer, Error) << \"Different number of planes\";\n>>>> -\t\tmetadata_.status = FrameMetadata::FrameError;\n>>>> -\t\treturn -EINVAL;\n>>>> -\t}\n>>>> -\n>>>> -\tfor (unsigned int i = 0; i < planes_.size(); i++) {\n>>>> -\t\tif (planes_[i].length < src->planes_[i].length) {\n>>>> -\t\t\tLOG(Buffer, Error) << \"Plane \" << i << \" is too small\";\n>>>> -\t\t\tmetadata_.status = FrameMetadata::FrameError;\n>>>> -\t\t\treturn -EINVAL;\n>>>> -\t\t}\n>>>> -\t}\n>>>> -\n>>>> -\tMappedFrameBuffer source(src, PROT_READ);\n>>>> -\tMappedFrameBuffer destination(this, PROT_WRITE);\n>>>> -\n>>>> -\tif (!source.isValid()) {\n>>>> -\t\tLOG(Buffer, Error) << \"Failed to map source planes\";\n>>>> -\t\treturn -EINVAL;\n>>>> -\t}\n>>>> -\n>>>> -\tif (!destination.isValid()) {\n>>>> -\t\tLOG(Buffer, Error) << \"Failed to map destination planes\";\n>>>> -\t\treturn -EINVAL;\n>>>> -\t}\n>>>> -\n>>>> -\tfor (unsigned int i = 0; i < planes_.size(); i++) {\n>>>> -\t\tmemcpy(destination.maps()[i].data(),\n>>>> -\t\t source.maps()[i].data(),\n>>>> -\t\t source.maps()[i].size());\n>>>> -\t}\n>>>> -\n>>>> -\tmetadata_ = src->metadata_;\n>>>> -\n>>>> -\treturn 0;\n>>>> -}\n>>>> -\n>>>> /**\n>>>> * \\class MappedBuffer\n>>>> * \\brief Provide an interface to support managing memory mapped buffers","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A1D23C3B5B\n\tfor ;\n\tTue, 22 Sep 2020 16:03:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2875C62FD8;\n\tTue, 22 Sep 2020 18:03:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B11960576\n\tfor ;\n\tTue, 22 Sep 2020 18:03:29 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BECAA555;\n\tTue, 22 Sep 2020 18:03:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qR7UDHcc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600790599;\n\tbh=pynHSgXS4eu4D/7WykxocbOGNnIY+4YwD3/d8WNJOCM=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=qR7UDHcc9eyQ+NS1f69HJ43vR+SBSRDxy5sRSpLCeELvGxCCedXuvHyvq/2G91p5V\n\txkhh62oJjSi2LwpRebGeKM5nNGI9DZVJFBg7BSYJD/Wn3LzG8byryedNjQ0kxU81xY\n\tQcErEs3tXCdxt7GeE198MSMK7+b35F0DT6w5BQgA=","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","References":"<20200921183205.2516132-1-niklas.soderlund@ragnatech.se>\n\t<20200921191647.GA18343@pendragon.ideasonboard.com>\n\t<0962ac19-90af-26fe-a0cf-e993a7d482b1@ideasonboard.com>\n\t<20200922100251.GA502216@oden.dyn.berto.se>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 22 Sep 2020 17:03:15 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200922100251.GA502216@oden.dyn.berto.se>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [RFC] libcamera: buffer: Remove copyFrom()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]