[{"id":12611,"web_url":"https://patchwork.libcamera.org/comment/12611/","msgid":"<20200921092204.GJ2692107@oden.dyn.berto.se>","date":"2020-09-21T09:22:04","subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: camera_manager: Make\n\tCameraManager::Private::mutex_ mutable","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-09-21 06:10:55 +0300, Laurent Pinchart wrote:\n> The mutex_ stored in the CameraManager::Private class is used to protect\n> members that may need to be accessed from const functions. Make it\n> mutable to allow this.\n> \n> Signed-off-by: Laurent Pinchart \n\nI was unaware of the mutable keyword so I learnt something, thanks.\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/camera_manager.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index 47d56256abd6..780a66a7ac10 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -46,7 +46,7 @@ public:\n> \t * - initialized_ and status_ during initialization\n> \t * - cameras_ and camerasByDevnum_ after initialization\n> \t */\n> -\tMutex mutex_;\n> +\tmutable Mutex mutex_;\n> \tstd::vector> cameras_;\n> \tstd::map> camerasByDevnum_;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54281C3B5B\n\tfor ;\n\tMon, 21 Sep 2020 09:22:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 227A062FC8;\n\tMon, 21 Sep 2020 11:22:07 +0200 (CEST)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8190960367\n\tfor ;\n\tMon, 21 Sep 2020 11:22:05 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id q8so13189263lfb.6\n\tfor ;\n\tMon, 21 Sep 2020 02:22:05 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tj8sm2558346lji.91.2020.09.21.02.22.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 21 Sep 2020 02:22:04 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"WqQhAz9u\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=dXQSW8wmBEv0gJeSDdpgl1P7hqaga7tXykz9zMG4vvQ=;\n\tb=WqQhAz9uAeSCj3Y8FBPjsMWwlBxAow/lTgZ1zRzkRyw+MaOPi+j8HMk74j9D6Nr+rM\n\tpDU12xSUdDGi0UUpb1mrtw4mzmClRv//9c8VI+naoGJ1Jp+HSQ7x7NpXrYjnw2aCgNoJ\n\t1mzc4Y46IQTV/yITGeJ9LxoZQ4FlXDAbSdLpBNZXgEavrrVNDYgfvXvev++149dDHpOP\n\t0HcJ4ArP6hlA5SUqtGKnkMZajHAH5O7MV36c4Ghyz8Zg7KyzejmZPNPtP3FkBhTTYlO3\n\tEWUTg6u/HrbcRhDMmqWbXwHi3/Y/4c3s+3lAU/SY9mBOyoQJTvF9nZDHzOQVxka7kaYi\n\tydUA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=dXQSW8wmBEv0gJeSDdpgl1P7hqaga7tXykz9zMG4vvQ=;\n\tb=neoae3zgzW7fvcO5o5Aw8kKt40nVAJ4Olk0mEdAN4i4BD+g+rTZI8sUGTff09m5xmL\n\tAlbnV4yVWKF7+xPeIiQvidqX0q44i3gMTo3a9BnKXLPPzCVBhCju8n0tjs/h/xQmAYj6\n\tHRNM19vIHpZiWDwnh6jIQ0qy+aIN3WbjPIxHtgGa6CQI16uHcj+0ThWi5uDsxfZYs0Ws\n\tCeVkf2+hLhnriW/8HGkCp5QG2vMZHTydlelgvUfEKRlQSa+HcnjmVMCTYX2Io30Cb6l7\n\tE/EAE13pm7gXj4ignElxkh7Lc621BQPNy5d+Put8iDFGfEJYrAy64QbERpeB9e61cQiQ\n\t0oPg==","X-Gm-Message-State":"AOAM5300t1GNuCvqjVZ3l2crTAoSFPDBmioUWe+dO0K0i3aYaCXqqyLt\n\tFiWt00hgHDDfdQIz64k4xHHdYA==","X-Google-Smtp-Source":"ABdhPJxCPZVIDD0JJGNx4U1vO2kQ94UqRCY+DrqUcGUkFLAMa80R9yRDSaLMi7TAiqXu0Qqxc/mQ4w==","X-Received":"by 2002:ac2:5463:: with SMTP id\n\te3mr14431469lfn.474.1600680125000; \n\tMon, 21 Sep 2020 02:22:05 -0700 (PDT)","Date":"Mon, 21 Sep 2020 11:22:04 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200921092204.GJ2692107@oden.dyn.berto.se>","References":"<20200921031057.3564-1-laurent.pinchart@ideasonboard.com>\n\t<20200921031057.3564-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200921031057.3564-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: camera_manager: Make\n\tCameraManager::Private::mutex_ mutable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12614,"web_url":"https://patchwork.libcamera.org/comment/12614/","msgid":"<20200921095202.if7twgkctqecjjtr@uno.localdomain>","date":"2020-09-21T09:52:02","subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: camera_manager: Make\n\tCameraManager::Private::mutex_ mutable","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Mon, Sep 21, 2020 at 06:10:55AM +0300, Laurent Pinchart wrote:\n> The mutex_ stored in the CameraManager::Private class is used to protect\n> members that may need to be accessed from const functions. Make it\n> mutable to allow this.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n\n> ---\n> src/libcamera/camera_manager.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index 47d56256abd6..780a66a7ac10 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -46,7 +46,7 @@ public:\n> \t * - initialized_ and status_ during initialization\n> \t * - cameras_ and camerasByDevnum_ after initialization\n> \t */\n> -\tMutex mutex_;\n> +\tmutable Mutex mutex_;\n> \tstd::vector> cameras_;\n> \tstd::map> camerasByDevnum_;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93A3EBF01C\n\tfor ;\n\tMon, 21 Sep 2020 09:48:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6FF9B62FBF;\n\tMon, 21 Sep 2020 11:48:11 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B879060367\n\tfor ;\n\tMon, 21 Sep 2020 11:48:09 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 5F8761BF20C;\n\tMon, 21 Sep 2020 09:48:09 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Mon, 21 Sep 2020 11:52:02 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20200921095202.if7twgkctqecjjtr@uno.localdomain>","References":"<20200921031057.3564-1-laurent.pinchart@ideasonboard.com>\n\t<20200921031057.3564-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200921031057.3564-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: camera_manager: Make\n\tCameraManager::Private::mutex_ mutable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]